From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jingoo Han Subject: [PATCH 20/52] net: fealnx: remove unnecessary pci_set_drvdata() Date: Wed, 11 Sep 2013 16:40:08 +0900 Message-ID: <005e01ceaec2$23e32420$6ba96c60$%han@samsung.com> References: <004a01ceaebf$43f920f0$cbeb62d0$%han@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, 'Jingoo Han' To: "'David S. Miller'" Return-path: Received: from mailout3.samsung.com ([203.254.224.33]:53694 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750974Ab3IKHkK (ORCPT ); Wed, 11 Sep 2013 03:40:10 -0400 Received: from epcpsbgr3.samsung.com (u143.gpu120.samsung.co.kr [203.254.230.143]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MSY0054QAMX89T0@mailout3.samsung.com> for netdev@vger.kernel.org; Wed, 11 Sep 2013 16:40:09 +0900 (KST) In-reply-to: <004a01ceaebf$43f920f0$cbeb62d0$%han@samsung.com> Content-language: ko Sender: netdev-owner@vger.kernel.org List-ID: The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/net/ethernet/fealnx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/fealnx.c b/drivers/net/ethernet/fealnx.c index c706b7a..99194d1 100644 --- a/drivers/net/ethernet/fealnx.c +++ b/drivers/net/ethernet/fealnx.c @@ -699,9 +699,9 @@ static void fealnx_remove_one(struct pci_dev *pdev) pci_iounmap(pdev, np->mem); free_netdev(dev); pci_release_regions(pdev); - pci_set_drvdata(pdev, NULL); - } else + } else { printk(KERN_ERR "fealnx: remove for unknown device\n"); + } } -- 1.7.10.4