From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F33A10FB for ; Mon, 22 May 2023 11:09:27 +0000 (UTC) Received: from smtpbg151.qq.com (smtpbg151.qq.com [18.169.211.239]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4EC2D1BDB for ; Mon, 22 May 2023 04:09:00 -0700 (PDT) X-QQ-mid:Yeas48t1684753100t145t45753 Received: from 3DB253DBDE8942B29385B9DFB0B7E889 (jiawenwu@trustnetic.com [122.235.247.1]) X-QQ-SSF:00400000000000F0FNF000000000000 From: =?utf-8?b?Smlhd2VuIFd1?= X-BIZMAIL-ID: 5886321521965178754 To: "'Andrew Lunn'" , "'Michael Walle'" , "'Shreeya Patel'" Cc: "'Andy Shevchenko'" , , , , , , , , , , , References: <20230515063200.301026-1-jiawenwu@trustnetic.com> <20230515063200.301026-7-jiawenwu@trustnetic.com> <00cd01d9879f$8e444950$aaccdbf0$@trustnetic.com> <016701d9886a$f9b415a0$ed1c40e0$@trustnetic.com> <90ef7fb8-feac-4288-98e9-6e67cd38cdf1@lunn.ch> <025b01d9897e$d8894660$899bd320$@trustnetic.com> <1e1615b3-566c-490c-8b1a-78f5521ca0b0@lunn.ch> <028601d989f9$230ee120$692ca360$@trustnetic.com> <005a01d98c8b$e48d2b60$ada78220$@trustnetic.com> In-Reply-To: <005a01d98c8b$e48d2b60$ada78220$@trustnetic.com> Subject: RE: [PATCH net-next v8 6/9] net: txgbe: Support GPIO to SFP socket Date: Mon, 22 May 2023 18:58:19 +0800 Message-ID: <005e01d98c9c$5181fb00$f485f100$@trustnetic.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQHvj8QD3pC+6Aq9H9h6P1+q5LrHRgMH5FTyAkITzAABJU2Y7wJ7xjhgAYjDQqsBr+FHUgDJ87o1AYTHtNcC/cxtnwIXsv+OAc8FI2Cuj14aYA== Content-Language: zh-cn X-QQ-SENDSIZE: 520 Feedback-ID: Yeas:trustnetic.com:qybglogicsvrgz:qybglogicsvrgz5a-1 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FROM_EXCESS_BASE64, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Monday, May 22, 2023 5:01 PM, Jiawen Wu wrote: > On Friday, May 19, 2023 9:13 PM, Andrew Lunn wrote: > > > I have one MSI-X interrupt for all general MAC interrupt (see TXGBE_PX_MISC_IEN_MASK). > > > It has 32 bits to indicate various interrupts, GPIOs are the one of them. When GPIO > > > interrupt is determined, GPIO_INT_STATUS register should be read to determine > > > which GPIO line has changed state. > > > > So you have another interrupt controller above the GPIO interrupt > > controller. regmap-gpio is pushing you towards describing this > > interrupt controller as a Linux interrupt controller. > > > > When you look at drivers handling interrupts, most leaf interrupt > > controllers are not described as Linux interrupt controllers. The > > driver interrupt handler reads the interrupt status register and > > internally dispatches to the needed handler. This works well when > > everything is internal to one driver. > > > > However, here, you have two drivers involved, your MAC driver and a > > GPIO driver instantiated by the MAC driver. So i think you are going > > to need to described the MAC interrupt controller as a Linux interrupt > > controller. > > > > Take a look at the mv88e6xxx driver, which does this. It has two > > interrupt controller embedded within it, and they are chained. > > Now I add two interrupt controllers, the first one for the MAC interrupt, > and the second one for regmap-gpio. In the second adding flow, > > irq = irq_find_mapping(txgbe->misc.domain, TXGBE_PX_MISC_GPIO_OFFSET); > err = regmap_add_irq_chip_fwnode(fwnode, regmap, irq, 0, 0, > chip, &chip_data); > > and then, > > config.irq_domain = regmap_irq_get_domain(chip_data); > gpio_regmap = gpio_regmap_register(&config); > > "txgbe->misc.domain" is the MAC interrupt domain. I think this flow should > be correct, but still failed to get gpio_irq from gpio_desc with err -517. > > And I still have doubts about what I said earlier: > https://lore.kernel.org/netdev/20230515063200.301026-1- > jiawenwu@trustnetic.com/T/#me1be68e1a1e44426ecc0dd8edf0f6b224e50630d > > There really is nothing wrong with gpiochip_to_irq()?? There is indeed something wrong in gpiochip_to_irq(), since commit 5467801 ("gpio: Restrict usage of GPIO chip irq members before initialization"): https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit?id=5467801f1fcbdc46bc7298a84dbf3ca1ff2a7320 When I use gpio_regmap_register() to add gpiochip, gpiochip_add_irqchip() will just return 0 since irqchip = NULL, then gc->irq.initialized = false. Cc the committer: Shreeya Patel.