From: <markus.stockhausen@gmx.de>
To: <linux@armlinux.org.uk>, <andrew@lunn.ch>, <hkallweit1@gmail.com>,
<netdev@vger.kernel.org>
Cc: "'Jonas Jelonek'" <jelonek.jonas@gmail.com>, <jan@3e8.eu>
Subject: pre-boot plugged SFP autoneg advertisement
Date: Sat, 18 Apr 2026 11:27:40 +0200 [thread overview]
Message-ID: <007c01dccf15$9b4622c0$d1d26840$@gmx.de> (raw)
Hi,
I'm currently analyzing an issue where a pre-boot-plugged SFP module
comes up with autoneg=no advertisement during boot. After an
unplug/replug autoneg=yes advertisement is chosen.
The following addition in phylink_start() just before the call to
phylink_mac_initial_config() mitigiates this.
+ /* If an SFP module was already present before phylink_start() was
+ * called, phylink_sfp_set_config() was unable to call
+ * phylink_mac_initial_config() as phylink was not yet started.
+ * Ensure the SFP capabilities are reflected in advertising.
+ */
+ if (pl->sfp_bus && !linkmode_empty(pl->sfp_support))
+ linkmode_copy(pl->link_config.advertising, pl->sfp_support);
Remark! This is about the OpenWrt Realtek Switch ecosystem with
kernel 6.18 where we are working hard to get hardware up and
running. We still rely heavily on pcs/dsa downstream drivers. So
I'm unsure if my observation/idea regarding upstream phylink is
right.
Thanks for your feedback in advance.
Markus
next reply other threads:[~2026-04-18 9:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-18 9:27 markus.stockhausen [this message]
2026-04-18 15:25 ` pre-boot plugged SFP autoneg advertisement Andrew Lunn
2026-04-19 8:49 ` AW: " markus.stockhausen
2026-04-20 16:16 ` markus.stockhausen
2026-04-20 17:57 ` Andrew Lunn
2026-04-20 19:10 ` AW: " markus.stockhausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='007c01dccf15$9b4622c0$d1d26840$@gmx.de' \
--to=markus.stockhausen@gmx.de \
--cc=andrew@lunn.ch \
--cc=hkallweit1@gmail.com \
--cc=jan@3e8.eu \
--cc=jelonek.jonas@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox