From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Laight <David.Laight@ACULAB.COM>
Subject: RE: [iproute PATCH 4/4] lib: Enable colored output only for TTYs
Date: Wed, 15 Aug 2018 15:34:31 +0000
Message-ID: <007d7ef0e49243ec82fafe3efa1d9ba3@AcuMS.aculab.com>
References: <20180815090610.16646-1-phil@nwl.cc>
        <20180815090610.16646-5-phil@nwl.cc>
        <8f48ba0a-ba36-67f8-8dee-f0d86b72e8e0@gmail.com>
 <20180815080406.7110bd76@xeon-e3>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Cc: Phil Sutter <phil@nwl.cc>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Till Maas <opensource@till.name>
To: 'Stephen Hemminger' <stephen@networkplumber.org>,
        David Ahern <dsahern@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from eu-smtp-delivery-211.mimecast.com ([146.101.78.211]:55050 "EHLO
        eu-smtp-delivery-211.mimecast.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1729388AbeHOSZg (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 15 Aug 2018 14:25:36 -0400
In-Reply-To: <20180815080406.7110bd76@xeon-e3>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Stephen Hemminger
> Sent: 15 August 2018 16:04
...
> > This also disables color sequence when the output is piped to a pager
> > such as less which with the -R argument can handle it just fine.
> >
> > ie., the user needs to remove the color arg when that output is not wanted.
> 
> If you are going to change the color enabling, why not make it compatible
> with what ls does?

Indeed - otherwise it is very hard to debug the colour escape sequences.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)