AW: [PATCH net-next v3 3/8] net: phy: add (*notify_phy_attach/detach)() hooks to struct mii_bus

["Markus Stockhausen" <markus.stockhausen@gmx.de>]

Hi Andrew,

I need some guidance on these Sashiko findings [1].

> Von: sashiko-bot@kernel.org <sashiko-bot@kernel.org> 
> Gesendet: Montag, 6. Juli 2026 18:36
> An: Markus Stockhausen <markus.stockhausen@gmx.de>
> Cc: robh@kernel.org; conor+dt@kernel.org; devicetree@vger.kernel.org
> Betreff: Re: [PATCH net-next v3 3/8] net: phy: add (*notify_phy_attach/detach)() hooks to struct mii_bus
> 
> Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
> 
> New issues:
> [Medium] The newly added `notify_phy_detach` callback is invoked unconditionally 
> during `phy_detach()`, violating attach/detach symmetry if attachment fails.

Is this accepted or should I add an bus_notified boolean attribute 
for state tracking to struct phy_device?

> Pre-existing issues:
> [High] Calling `phy_attach_direct` on an already-attached PHY destructively removes 
> ist existing attachment.

Is this even possible?

Thanks in advance.

Markus

[1] https://sashiko.dev/#/message/20260706163627.A22DC1F000E9%40smtp.kernel.org