From: "Jongsung Kim" <neidhard.kim@lge.com>
To: "'Sergei Shtylyov'" <sergei.shtylyov@cogentembedded.com>
Cc: <davem@davemloft.net>, <peppe.cavallaro@st.com>,
<chohnstaedt@innominate.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: RE: net: phy: realtek: add rtl8201f driver
Date: Thu, 9 May 2013 11:35:03 +0900 [thread overview]
Message-ID: <008d01ce4c5d$cfd36410$6f7a2c30$@lge.com> (raw)
In-Reply-To: <518A7284.4000504@cogentembedded.com>
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> :
> Removal of unused #define's is a matter of a separate cleanup patch...
Sorry. I won't touch them.
>> +static int rtl8201f_ack_interrupt(struct phy_device *phydev) {
>> + int err;
>> +
>> + err = phy_read(phydev, RTL8201F_ISR);
>
> This could be an initializer and so make the function shorter.
>
Agreed. I just thought it's better to make it similar to the
rtl821x_ack_interrupt. Then, may I make shorter the rtl821x_ack_interrupt as
well as rtl8201f_ack_interrupt?
>
> You haven't run this patch thru scripts/checkpatch.pl -- there should
be a space between *if* and (.
>
Sorry.. what a mistake..
next prev parent reply other threads:[~2013-05-09 2:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-08 10:10 net: phy: realtek: add rtl8201f driver Jongsung Kim
2013-05-08 10:41 ` Francois Romieu
2013-05-09 2:26 ` Jongsung Kim
2013-05-08 15:43 ` Sergei Shtylyov
2013-05-09 2:35 ` Jongsung Kim [this message]
2013-05-09 16:58 ` Sergei Shtylyov
2013-05-10 3:44 ` Jongsung Kim
2013-05-10 7:29 ` [PATCH v2 1/4] net: phy: realtek: simplify multiple drivers registration Jongsung Kim
2013-05-10 7:29 ` [PATCH v2 2/4] net: phy: realtek: add support for the RTL8201F Jongsung Kim
2013-05-10 7:29 ` [PATCH v2 3/4] net: phy: realtek: add suspend/resume handlers for the RTL8211B Jongsung Kim
2013-05-10 7:29 ` [PATCH v2 4/4] net: phy: realtek: cleanup code Jongsung Kim
2013-05-10 11:18 ` Sergei Shtylyov
2013-05-13 2:48 ` Jongsung Kim
2013-05-13 9:58 ` [PATCH v3 1/4] net: phy: realtek: simplify multiple drivers registration Jongsung Kim
2013-05-13 9:58 ` [PATCH v3 2/4] net: phy: realtek: add support for the RTL8201F Jongsung Kim
2013-05-13 9:58 ` [PATCH v3 3/4] net: phy: realtek: add suspend/resume handlers for the RTL8211B Jongsung Kim
2013-05-13 9:58 ` [PATCH v3 4/4] net: phy: realtek: cleanup code Jongsung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='008d01ce4c5d$cfd36410$6f7a2c30$@lge.com' \
--to=neidhard.kim@lge.com \
--cc=chohnstaedt@innominate.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).