From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Hua Zhong" Subject: RE: [RFC PATCH 0/8]: uninline & uninline Date: Sat, 23 Feb 2008 11:58:30 -0800 Message-ID: <00ac01c87656$777c02a0$667407e0$@com> References: <1203515238-22848-1-git-send-email-ilpo.jarvinen@helsinki.fi> <20080223000220.e9229c99.akpm@linux-foundation.org> <20080223105517.4d706511.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: =?ISO-8859-1?Q?'Ilpo_J=E4rvinen'?= , , , "'David Miller'" , "'Arnaldo Carvalho de Melo'" To: "'Andrew Morton'" , "'Andi Kleen'" Return-path: Received: from wr-out-0506.google.com ([64.233.184.238]:57777 "EHLO wr-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762069AbYBWT6i (ORCPT ); Sat, 23 Feb 2008 14:58:38 -0500 Received: by wr-out-0506.google.com with SMTP id c48so1347361wra.23 for ; Sat, 23 Feb 2008 11:58:36 -0800 (PST) In-Reply-To: <20080223105517.4d706511.akpm@linux-foundation.org> Content-Language: en-us Sender: netdev-owner@vger.kernel.org List-ID: > > Is there any reason they couldn't just be merged to mainline? > > > > I think it's a useful facility. > > ummm, now why did we made that decision... I think we decided that > it's the sort of thing which one person can run once per few months > and that will deliver its full value. I can maintain it in -mm and > we're happy - no need to add it to mainline. No strong feelings > either way really. Apparently nobody has been doing it for a while. :-) Last time I did it it was around the submission time and I actually patched it into mainline kernel to do so. Not particularly hard to do, but sitting in mm-only does make it a bit harder, and there are the vdso problem you just mentioned that one has to fix for himself if it exists in mainline. > It does have the downside that the kernel explodes if someone adds > unlikely or likely to the vdso code and I need to occasionally hunt > down new additions and revert them in that patch. That makes it a > bit of a maintenance burden. Is it possible to catch this automatically, like, by re-defining likely/unlikely to the raw form in specific file(s)? Hua