From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C440C43381 for ; Thu, 21 Feb 2019 04:04:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C5B5F214AF for ; Thu, 21 Feb 2019 04:04:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=dektech.com.au header.i=@dektech.com.au header.b="IrUrnLuK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726369AbfBUEE4 (ORCPT ); Wed, 20 Feb 2019 23:04:56 -0500 Received: from f0-dek.dektech.com.au ([210.10.221.142]:36837 "EHLO mail.dektech.com.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726113AbfBUEE4 (ORCPT ); Wed, 20 Feb 2019 23:04:56 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.dektech.com.au (Postfix) with ESMTP id DCF77E522A; Thu, 21 Feb 2019 15:04:51 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=dektech.com.au; h=content-language:x-mailer:content-transfer-encoding :content-type:content-type:mime-version:message-id:date:date :subject:subject:in-reply-to:references:from:from:received :received:received; s=mail_dkim; t=1550721891; bh=a8Y/kmLrAGTP9G Z48F6N5sAmq8N1sbZakYUIZTFuCuk=; b=IrUrnLuKM9h5yMbxfpSqw0/6BKoi9x fOLn6MpNSr34kQanfLophrQ3th1+eipSh1xcZuT+236j9RLQnAqBLsjdAhb4VWk/ vQcVd9ZQLscPbvcXWXiHjSOTozdxreRONLfxBBISXjr0fdG+0lGthd5dLObf2+fX VwX2C1YkSJLlk= X-Virus-Scanned: amavisd-new at dektech.com.au Received: from mail.dektech.com.au ([127.0.0.1]) by localhost (mail2.dektech.com.au [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id G4RscZFciFDw; Thu, 21 Feb 2019 15:04:51 +1100 (AEDT) Received: from mail.dektech.com.au (localhost [127.0.0.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.dektech.com.au (Postfix) with ESMTPS id B328DF8F94; Thu, 21 Feb 2019 15:04:51 +1100 (AEDT) Received: from VNLAP253VNPC (unknown [14.161.14.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.dektech.com.au (Postfix) with ESMTPSA id B640AE522A; Thu, 21 Feb 2019 15:04:50 +1100 (AEDT) From: "tung quang nguyen" To: "'David Miller'" Cc: , References: <20190219070310.23888-2-tung.q.nguyen@dektech.com.au> <20190221033121.4220-1-tung.q.nguyen@dektech.com.au> <20190220.195104.1394349830331192977.davem@davemloft.net> In-Reply-To: <20190220.195104.1394349830331192977.davem@davemloft.net> Subject: RE: [tipc-discussion][net v2 1/1] tipc: fix race condition causing hung sendto Date: Thu, 21 Feb 2019 11:04:46 +0700 Message-ID: <00af01d4c99a$97324e30$c596ea90$@dektech.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Content-Language: en-us Thread-Index: AQLbCC1+l9Tkyy7lr/L7JgT90/I8lgF5yU6tAmJphqmjvj/HkA== Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi David, I compiled previous version and tested it. But I forgot to observe kernel warning. For the way to reproduce the issue: calling sendto() and printf() right after that to print out a log to see if sendto() was successful. On some occasions, the log was never printed and stack trace showed sendto() was not returned. By applying the patch, the issue disappeared. Thanks. Best regards, Tung Nguyen -----Original Message----- From: David Miller Sent: Thursday, February 21, 2019 10:51 AM To: tung.q.nguyen@dektech.com.au Cc: netdev@vger.kernel.org; tipc-discussion@lists.sourceforge.net Subject: Re: [tipc-discussion][net v2 1/1] tipc: fix race condition causing hung sendto So if the previous version didn't even compile, I have to ask. How did you test this?