From: Jingoo Han <jg1.han@samsung.com>
To: "'David S. Miller'" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, 'Jingoo Han' <jg1.han@samsung.com>,
'Paul Gortmaker' <paul.gortmaker@windriver.com>
Subject: [PATCH 02/15] net: 8390: remove unnecessary pci_set_drvdata()
Date: Fri, 18 Oct 2013 09:18:18 +0900 [thread overview]
Message-ID: <00b101cecb97$8bc4bdf0$a34e39d0$%han@samsung.com> (raw)
In-Reply-To: <00ae01cecb97$44d45770$ce7d0650$%han@samsung.com>
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/ethernet/8390/ne2k-pci.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/ethernet/8390/ne2k-pci.c b/drivers/net/ethernet/8390/ne2k-pci.c
index 9220108..fc14a85 100644
--- a/drivers/net/ethernet/8390/ne2k-pci.c
+++ b/drivers/net/ethernet/8390/ne2k-pci.c
@@ -389,9 +389,7 @@ err_out_free_netdev:
free_netdev (dev);
err_out_free_res:
release_region (ioaddr, NE_IO_EXTENT);
- pci_set_drvdata (pdev, NULL);
return -ENODEV;
-
}
/*
@@ -655,7 +653,6 @@ static void ne2k_pci_remove_one(struct pci_dev *pdev)
release_region(dev->base_addr, NE_IO_EXTENT);
free_netdev(dev);
pci_disable_device(pdev);
- pci_set_drvdata(pdev, NULL);
}
#ifdef CONFIG_PM
--
1.7.10.4
next prev parent reply other threads:[~2013-10-18 0:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-18 0:16 [PATCH 00/15] net: ethernet: remove unnecessary pci_set_drvdata() part 1 Jingoo Han
2013-10-18 0:17 ` [PATCH 01/15] net: typhoon: remove unnecessary pci_set_drvdata() Jingoo Han
2013-10-18 0:18 ` Jingoo Han [this message]
2013-10-18 0:18 ` [PATCH 03/15] net: starfire: " Jingoo Han
2013-10-18 0:19 ` [PATCH 04/15] net: pcnet32: " Jingoo Han
2013-10-18 0:19 ` [PATCH 05/15] net: amd8111e: " Jingoo Han
2013-10-18 0:20 ` [PATCH 06/15] net: alx: " Jingoo Han
2013-10-18 0:21 ` [PATCH 07/15] net: bnx2: " Jingoo Han
2013-10-18 0:21 ` [PATCH 08/15] net: bnx2x: " Jingoo Han
2013-10-18 0:21 ` [PATCH 09/15] net: tg3: " Jingoo Han
2013-10-18 0:22 ` [PATCH 10/15] net: bna: " Jingoo Han
2013-10-18 0:23 ` [PATCH 11/15] net: cxgb4: " Jingoo Han
2013-10-18 0:23 ` [PATCH 12/15] net: cxgb3: " Jingoo Han
2013-10-18 0:24 ` [PATCH 13/15] net: cxgb2: " Jingoo Han
2013-10-18 0:24 ` [PATCH 14/15] net: cxgb4vf: " Jingoo Han
2013-10-18 0:25 ` [PATCH 15/15] net: enic: " Jingoo Han
2013-10-18 16:00 ` Neel Patel (neepatel)
2013-10-21 14:02 ` Sujith Sankar (ssujith)
2013-10-18 4:04 ` [PATCH 00/15] net: ethernet: remove unnecessary pci_set_drvdata() part 1 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00b101cecb97$8bc4bdf0$a34e39d0$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).