From: Jose Abreu <Jose.Abreu@synopsys.com>
To: Florian Fainelli <f.fainelli@gmail.com>,
Jose Abreu <Jose.Abreu@synopsys.com>, <netdev@vger.kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Joao Pinto <Joao.Pinto@synopsys.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@st.com>
Subject: Re: [PATCH v3 net-next 1/9] net: stmmac: Add XGMAC 2.10 HWIF entry
Date: Mon, 6 Aug 2018 08:55:13 +0100 [thread overview]
Message-ID: <00b26a5f-afdc-95ce-3b64-72710b30789b@synopsys.com> (raw)
In-Reply-To: <4f309bf8-c669-ae9d-750c-8946715f0fe1@gmail.com>
Hi Florian,
On 03-08-2018 19:54, Florian Fainelli wrote:
> On 08/03/2018 08:50 AM, Jose Abreu wrote:
>> @@ -87,6 +88,7 @@ static const struct stmmac_hwif_entry {
>> {
>> .gmac = false,
>> .gmac4 = false,
>> + .xgmac = false,
> In a future clean-up you would like want to remove this and replace this
> an enumeration which is less error prone than having to define a boolean
> for each of these previous generations only to say "this is not an xgmac".
Its a good idea! I really don't like the pattern of "if
(priv->plat->has_something)" in the code. I will think about
adding this but for now let's merge xgmac2 and I will try to
refactor the code later because I will need to change many files
and the patchset would be bigger.
Thanks and Best Regards,
Jose Miguel Abreu
next prev parent reply other threads:[~2018-08-06 10:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-03 15:50 [PATCH v3 net-next 0/9] Add support for XGMAC2 in stmmac Jose Abreu
2018-08-03 15:50 ` [PATCH v3 net-next 1/9] net: stmmac: Add XGMAC 2.10 HWIF entry Jose Abreu
2018-08-03 18:54 ` Florian Fainelli
2018-08-06 7:55 ` Jose Abreu [this message]
2018-08-03 15:50 ` [PATCH v3 net-next 2/9] net: stmmac: Add MAC related callbacks for XGMAC2 Jose Abreu
2018-08-03 15:50 ` [PATCH v3 net-next 3/9] net: stmmac: Add DMA " Jose Abreu
2018-08-03 18:58 ` Florian Fainelli
2018-08-06 7:56 ` Jose Abreu
2018-08-03 15:50 ` [PATCH v3 net-next 4/9] net: stmmac: Add descriptor " Jose Abreu
2018-08-03 15:50 ` [PATCH v3 net-next 5/9] net: stmmac: Add MDIO related functions " Jose Abreu
2018-08-03 16:56 ` Andrew Lunn
2018-08-03 19:06 ` Florian Fainelli
2018-08-06 7:59 ` Jose Abreu
2018-08-06 15:25 ` Florian Fainelli
2018-08-07 13:35 ` Jose Abreu
2018-08-07 15:29 ` Jose Abreu
2018-08-07 17:31 ` Florian Fainelli
2018-08-03 15:50 ` [PATCH v3 net-next 6/9] net: stmmac: Add PTP support " Jose Abreu
2018-08-03 15:50 ` [PATCH v3 net-next 7/9] net: stmmac: Integrate XGMAC into main driver flow Jose Abreu
2018-08-03 15:50 ` [PATCH v3 net-next 8/9] net: stmmac: Add the bindings parsing for XGMAC2 Jose Abreu
2018-08-03 15:50 ` [PATCH v3 net-next 9/9] dt-bindings: net: stmmac: Add the bindings documentation " Jose Abreu
2018-08-07 17:36 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00b26a5f-afdc-95ce-3b64-72710b30789b@synopsys.com \
--to=jose.abreu@synopsys.com \
--cc=Joao.Pinto@synopsys.com \
--cc=alexandre.torgue@st.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).