From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gal Pressman <galp@mellanox.com>
Subject: Re: [PATCH net-next v2 1/6] net: Fix netdev_WARN_ONCE macro
Date: Tue, 9 Jan 2018 11:51:36 +0200
Message-ID: <00b85bdb-4d8b-41e7-6f1d-8eae9c65c1b0@mellanox.com>
References: <1515319720-18428-1-git-send-email-galp@mellanox.com>
 <1515319720-18428-2-git-send-email-galp@mellanox.com>
 <1515465721.9619.78.camel@perches.com>
 <20180108.220541.1359488060683672177.davem@davemloft.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, tariqt@mellanox.com, saeedm@mellanox.com
To: David Miller <davem@davemloft.net>, joe@perches.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-he1eur01on0077.outbound.protection.outlook.com ([104.47.0.77]:58880
        "EHLO EUR01-HE1-obe.outbound.protection.outlook.com"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1752581AbeAIJvp (ORCPT <rfc822;netdev@vger.kernel.org>);
        Tue, 9 Jan 2018 04:51:45 -0500
In-Reply-To: <20180108.220541.1359488060683672177.davem@davemloft.net>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 09-Jan-18 05:05, David Miller wrote:
> From: Joe Perches <joe@perches.com>
> Date: Mon, 08 Jan 2018 18:42:01 -0800
> 
>> On Sun, 2018-01-07 at 12:08 +0200, Gal Pressman wrote:
>>> netdev_WARN_ONCE is broken (whoops..), this fix will remove the
>>> unnecessary "condition" parameter, add the missing comma and change
>>> "arg" to "args".
>>>
>>> Fixes: 375ef2b1f0d0 ("net: Introduce netdev_*_once functions")
>>> Signed-off-by: Gal Pressman <galp@mellanox.com>
>>> Reviewed-by: Saeed Mahameed <saeedm@mellanox.com>
>>> ---
>>>  include/linux/netdevice.h | 4 ++--
>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
>>> index 352066e..5ff1ef9 100644
>>> --- a/include/linux/netdevice.h
>>> +++ b/include/linux/netdevice.h
>>> @@ -4407,8 +4407,8 @@ do {								\
>>>  	WARN(1, "netdevice: %s%s\n" format, netdev_name(dev),	\
>>>  	     netdev_reg_state(dev), ##args)
>>>  
>>> -#define netdev_WARN_ONCE(dev, condition, format, arg...)		\
>>> -	WARN_ONCE(1, "netdevice: %s%s\n" format, netdev_name(dev)	\
>>> +#define netdev_WARN_ONCE(dev, format, args...)				\
>>> +	WARN_ONCE(1, "netdevice: %s%s\n" format, netdev_name(dev),	\
>>
>> You sure you want the newline before the format?
> 
> Hmmm, Gal please send me a relative fix for this.
> 

The newline is removed in the next patch, which handles the formatting of both macros.
Do you want to remove it as part of this bug fix?