Re: [PATCH net-next v04 05/14] hinic3: Command Queue flush interfaces

[Vadim Fedorenko <vadim.fedorenko@linux.dev>]

On 05/09/2025 09:28, Fan Gong wrote:

[...]

> +struct comm_cmd_clear_doorbell {
> +	struct mgmt_msg_head head;
> +	u16                  func_id;
> +	u16                  rsvd1[3];
> +};
> +
> +struct comm_cmd_clear_resource {
> +	struct mgmt_msg_head head;
> +	u16                  func_id;
> +	u16                  rsvd1[3];
> +};

I don't see any difference in these 2 structures. And the code
implementation doesn't check types. Probably it's better to refactor
things and try to implement it using common thing.

[...]

> +void hinic3_enable_doorbell(struct hinic3_hwif *hwif)
> +{
> +	u32 addr, attr4;
> +
> +	addr = HINIC3_CSR_FUNC_ATTR4_ADDR;
> +	attr4 = hinic3_hwif_read_reg(hwif, addr);
> +
> +	attr4 &= ~HINIC3_AF4_DOORBELL_CTRL_MASK;
> +	attr4 |= HINIC3_AF4_SET(ENABLE_DOORBELL, DOORBELL_CTRL);
> +
> +	hinic3_hwif_write_reg(hwif, addr, attr4);
> +}
> +
> +void hinic3_disable_doorbell(struct hinic3_hwif *hwif)
> +{
> +	u32 addr, attr4;
> +
> +	addr = HINIC3_CSR_FUNC_ATTR4_ADDR;
> +	attr4 = hinic3_hwif_read_reg(hwif, addr);
> +
> +	attr4 &= ~HINIC3_AF4_DOORBELL_CTRL_MASK;
> +	attr4 |= HINIC3_AF4_SET(DISABLE_DOORBELL, DOORBELL_CTRL);
> +
> +	hinic3_hwif_write_reg(hwif, addr, attr4);
> +}

These 2 functions differ only in one bit. It might be better to
implement it once and use extra boolean parameter?