From: Andrew Lunn <andrew@lunn.ch>
To: Sean Chang <seanwascoding@gmail.com>
Cc: nicolas.ferre@microchip.com, claudiu.beznea@tuxon.dev,
trond.myklebust@hammerspace.com, anna@kernel.org,
netdev@vger.kernel.org, linux-nfs@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] net: macb: fix format-truncation warning
Date: Tue, 17 Feb 2026 18:46:47 +0100 [thread overview]
Message-ID: <00ebdd77-d6ef-48f2-a25d-8d8b3c7dc7a8@lunn.ch> (raw)
In-Reply-To: <CAAb=EJWNSvTHuUX862vLmA2s1uKO0vy_x9OSZ6VXqY9X-+JNsg@mail.gmail.com>
> Regarding the architecture-specific nature of the warning: I have verified that
> this warning is not triggered on x86_64, even with W=1. It appears to
> be specific
> to the RISC-V toolchain's diagnostic analysis.
Given the other patches in there series, i have to wounder, is the
diagnostic analysis correct? Or is the RISC-V toolchain buggy?
> Regardless, converting to ethtool_sprintf() is the correct approach
> which does not throw any warning on the both platforms.
I do agree ethtool_sprintf() is better. But we want the commit message
to reflect why we are making this change. Is it because
ethtool_sprintf() is better, or are we working around toolchain bugs?
Andrew
next prev parent reply other threads:[~2026-02-17 17:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-16 17:49 [PATCH v2 0/2] Fix warnings for RISC-V builds Sean Chang
2026-02-16 17:49 ` [PATCH v2 1/2] nfs: fix unused variable warnings Sean Chang
2026-02-16 20:06 ` Andrew Lunn
2026-02-17 9:55 ` Sean
2026-02-16 17:49 ` [PATCH v2 2/2] net: macb: fix format-truncation warning Sean Chang
2026-02-16 18:35 ` Andrew Lunn
2026-02-17 17:28 ` Sean Chang
2026-02-17 17:46 ` Andrew Lunn [this message]
2026-02-17 19:14 ` Sean Chang
2026-02-17 20:33 ` Andrew Lunn
2026-02-18 12:16 ` Sean Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00ebdd77-d6ef-48f2-a25d-8d8b3c7dc7a8@lunn.ch \
--to=andrew@lunn.ch \
--cc=anna@kernel.org \
--cc=claudiu.beznea@tuxon.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=seanwascoding@gmail.com \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox