From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: smtp.subspace.kernel.org; dkim=none
Received: from smtpbg153.qq.com (smtpbg153.qq.com [13.245.218.24])
	by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 394F41A4
	for <netdev@vger.kernel.org>; Thu, 23 Nov 2023 01:23:05 -0800 (PST)
X-QQ-mid:Yeas7t1700731238t090t49816
Received: from 3DB253DBDE8942B29385B9DFB0B7E889 (jiawenwu@trustnetic.com [183.128.129.197])
X-QQ-SSF:00400000000000F0FSF000000000000
From: =?utf-8?b?Smlhd2VuIFd1?= <jiawenwu@trustnetic.com>
X-BIZMAIL-ID: 5760696767292244872
To: "'Andrew Lunn'" <andrew@lunn.ch>
Cc: <netdev@vger.kernel.org>,
	<davem@davemloft.net>,
	<edumazet@google.com>,
	<kuba@kernel.org>,
	<pabeni@redhat.com>,
	<linux@armlinux.org.uk>,
	<horms@kernel.org>,
	<mengyuanlou@net-swift.com>
References: <20231122102226.986265-1-jiawenwu@trustnetic.com> <20231122102226.986265-2-jiawenwu@trustnetic.com> <6218df6e-db11-4640-a296-946088d32916@lunn.ch>
In-Reply-To: <6218df6e-db11-4640-a296-946088d32916@lunn.ch>
Subject: RE: [PATCH net-next 1/5] net: wangxun: add flow control support
Date: Thu, 23 Nov 2023 17:20:37 +0800
Message-ID: <00f701da1dee$51bfb0b0$f53f1210$@trustnetic.com>
Precedence: bulk
X-Mailing-List: netdev@vger.kernel.org
List-Id: <netdev.vger.kernel.org>
List-Subscribe: <mailto:netdev+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:netdev+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Outlook 16.0
Content-Language: zh-cn
Thread-Index: AQIZ7m4FfqhO6yXRbjtvxmXj2jKlSQLU6mPhAVK4luWv5sA6cA==
X-QQ-SENDSIZE: 520
Feedback-ID: Yeas:trustnetic.com:qybglogicsvrgz:qybglogicsvrgz5a-1

On Thursday, November 23, 2023 12:15 AM, Andrew Lunn wrote:
> > +	/* Calculate max LAN frame size */
> > +	link = dev->mtu + ETH_HLEN + ETH_FCS_LEN + WX_ETH_FRAMING;
> > +	tc = link;
> > +
> > +	/* Calculate delay value for device */
> > +	dv_id = WX_DV(link, tc);
> 
> That looks odd. tc == link. So why pass both? Or is it a typo?

This is because I've temporarily removed the FCOE related code,
as something to support later. So now tc == link, which looks odd.