From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44D7AC32750 for ; Tue, 13 Aug 2019 22:53:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 01F032067D for ; Tue, 13 Aug 2019 22:53:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Pb50OZN9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727304AbfHMWx6 (ORCPT ); Tue, 13 Aug 2019 18:53:58 -0400 Received: from mail-pl1-f193.google.com ([209.85.214.193]:46185 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727136AbfHMWx5 (ORCPT ); Tue, 13 Aug 2019 18:53:57 -0400 Received: by mail-pl1-f193.google.com with SMTP id c2so49859190plz.13 for ; Tue, 13 Aug 2019 15:53:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=pbVdg3P6Nli4sDSZcBwe1vlftJvMHPf7gF04TEBBEao=; b=Pb50OZN9j8ao3wzLJW/wt63VpLhN20HfZrL87vwMS8viPsLXCIbjl+tMf4C5FGhL4S 9aRwE4UACMPM0QPfXWeIUIUIc/6bVQAjN26GO6vZl+SDEoNK5rV53lAmHv/2/HJMr2tm 0Fb6dsH1UmBCFue06HU/5uYmkV/s4DAKMHOXvHyFf+jKP4n6OWI5s8u30ai2wuoE7kZK AmhtZeRA6IXU5ocERAQbiUIVbr5VFzPGMVksyUSz/VTrsCMMjsGz1clVxxZBGoXeqyZF ZwRSD/bCU/aj6tr+hc4cPr4b0rcrAb531I9rK9OtfjpkLh7q/dsaIgHxl2F5jjwGVPTX yg/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=pbVdg3P6Nli4sDSZcBwe1vlftJvMHPf7gF04TEBBEao=; b=h+8NyH7g6udW/lj6m6YFbRxRvR6HiehVo90ujzq3wuc/834uX7uPZgZi0fylwhX0Xn m0nnZvEsc6d3FhRhlLR/UBR/DtzdTsv0wrreqdkqG0sB9+Taov9AIkCVNNxjik2zIBVa Ra7QuO7KmWVQGTB4sALFaj3J+dRQZk8h2DSz87OpXSOpx6zNnsV2RFZbRJU98thVCiPd 0YKKZ3aBYn/UbXotF4ONS0nHWh0MJZpYeWZ/k8RPq3S+700Z2wJkpcJ2qA4MN+uXPHoK HSOz3fHQvG3NClcdyqkWE4BuF3vRZDgfeIVRH9lWtKV75KdkMREedyimzPC5f/6hED64 URQQ== X-Gm-Message-State: APjAAAU504PlKJv84eqRVpGNW2c4qwFWqpkhjfauIJljZ1M0iJHuSGH1 Fy8H9gMlx/9miSlzOgMH9k9lavdS X-Google-Smtp-Source: APXvYqyiUybqKLU92f+Thi0EBcn+YcMR0ijPB2Jq3nn2a2lv6L5LzPfotRzsnDpVDRux7ZIOOmJHsw== X-Received: by 2002:a17:902:b497:: with SMTP id y23mr40227564plr.68.1565736836056; Tue, 13 Aug 2019 15:53:56 -0700 (PDT) Received: from [10.67.49.31] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id t7sm113180115pfh.101.2019.08.13.15.53.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Aug 2019 15:53:55 -0700 (PDT) Subject: Re: [PATCH RFC 2/4] net: phy: allow to bind genphy driver at probe time To: Heiner Kallweit , Andrew Lunn , Marek Behun , David Miller Cc: "netdev@vger.kernel.org" References: From: Florian Fainelli Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9Za0Dx0yyp44iD1OvHtkEI M5kY0ACeNhCZJvZ5g4C2Lc9fcTHu8jxmEkI= Message-ID: <010ae64f-7e48-5e1e-2928-af3c4364f6e3@gmail.com> Date: Tue, 13 Aug 2019 15:53:54 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 8/13/19 2:25 PM, Heiner Kallweit wrote: > In cases like a fixed phy that is never attached to a net_device we > may want to bind the genphy driver at probe time. Setting a PHY ID of > 0xffffffff to bind the genphy driver would fail due to a check in > get_phy_device(). Therefore let's change the PHY ID the genphy driver > binds to to 0xfffffffe. This still shouldn't match any real PHY, > and it will pass the check in get_phy_devcie(). > > Signed-off-by: Heiner Kallweit > --- > drivers/net/phy/phy_device.c | 3 +-- > include/linux/phy.h | 4 ++++ > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c > index 163295dbc..54f80af31 100644 > --- a/drivers/net/phy/phy_device.c > +++ b/drivers/net/phy/phy_device.c > @@ -2388,8 +2388,7 @@ void phy_drivers_unregister(struct phy_driver *drv, int n) > EXPORT_SYMBOL(phy_drivers_unregister); > > static struct phy_driver genphy_driver = { > - .phy_id = 0xffffffff, > - .phy_id_mask = 0xffffffff, > + PHY_ID_MATCH_EXACT(GENPHY_ID), > .name = "Generic PHY", > .soft_reset = genphy_no_soft_reset, > .get_features = genphy_read_abilities, > diff --git a/include/linux/phy.h b/include/linux/phy.h > index 5ac7d2137..3b07bce78 100644 > --- a/include/linux/phy.h > +++ b/include/linux/phy.h > @@ -37,6 +37,10 @@ > #define PHY_1000BT_FEATURES (SUPPORTED_1000baseT_Half | \ > SUPPORTED_1000baseT_Full) > > +#define GENPHY_ID_HIGH 0xffffU > +#define GENPHY_ID_LOW 0xfffeU > +#define GENPHY_ID ((GENPHY_ID_HIGH << 16) | GENPHY_ID_LOW) This is a possible user ABI change here, if there is anything that relies on reading 0xffff_ffff as a valid PHY OUI, you would be breaking it. We might as well try to assign ourselves a specific PHY OUI, very much like the Linux USB hubs show up with a Linux Foundation vendor ID. -- Florian