From: Andrew Lunn <andrew@lunn.ch>
To: Ren Wei <n05ec@lzu.edu.cn>
Cc: netdev@vger.kernel.org, Felix Maurer <fmaurer@redhat.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, horms@kernel.org, kees@kernel.org,
kexinsun@smail.nju.edu.cn, luka.gejak@linux.dev,
Arvid.Brodin@xdin.com, m-karicheri2@ti.com, yuantan098@gmail.com,
yifanwucs@gmail.com, tomapufckgml@gmail.com, bird@lzu.edu.cn,
xuyuqiabc@gmail.com, royenheart@gmail.com
Subject: Re: [PATCH net v3 1/1] net: hsr: limit node table growth
Date: Tue, 21 Apr 2026 17:18:22 +0200 [thread overview]
Message-ID: <010f9f4c-c03c-4159-aa18-f55be8faf7b4@lunn.ch> (raw)
In-Reply-To: <3bdbe54e81bd89c1443b05500368fb45bddc3191.1776754203.git.royenheart@gmail.com>
> +static unsigned int hsr_node_table_size = 1024;
> +module_param_named(node_table_size, hsr_node_table_size, uint, 0644);
> +MODULE_PARM_DESC(node_table_size,
> + "Maximum number of learned entries in each HSR/PRP node table (0 = unlimited)");
> +
Please don't use module parameters. Look at other parts of the network
stack where such limits are imposed. They all use sysctl values.
Andrew
---
pw-bot: cr
next prev parent reply other threads:[~2026-04-21 15:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-21 14:50 [PATCH net v3 1/1] net: hsr: limit node table growth Ren Wei
2026-04-21 15:18 ` Andrew Lunn [this message]
2026-04-22 8:31 ` Felix Maurer
2026-04-22 8:52 ` Sebastian Andrzej Siewior
2026-04-22 9:45 ` Felix Maurer
2026-04-22 10:58 ` Sebastian Andrzej Siewior
2026-04-22 12:38 ` Felix Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=010f9f4c-c03c-4159-aa18-f55be8faf7b4@lunn.ch \
--to=andrew@lunn.ch \
--cc=Arvid.Brodin@xdin.com \
--cc=bigeasy@linutronix.de \
--cc=bird@lzu.edu.cn \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fmaurer@redhat.com \
--cc=horms@kernel.org \
--cc=kees@kernel.org \
--cc=kexinsun@smail.nju.edu.cn \
--cc=kuba@kernel.org \
--cc=luka.gejak@linux.dev \
--cc=m-karicheri2@ti.com \
--cc=n05ec@lzu.edu.cn \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=royenheart@gmail.com \
--cc=tomapufckgml@gmail.com \
--cc=xuyuqiabc@gmail.com \
--cc=yifanwucs@gmail.com \
--cc=yuantan098@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox