From: "Steve Wise" <swise@opengridcomputing.com>
To: "'David Miller'" <davem@davemloft.net>, <varun@chelsio.com>
Cc: <netdev@vger.kernel.org>, <linux-scsi@vger.kernel.org>,
<target-devel@vger.kernel.org>, <nab@linux-iscsi.org>,
<gerlitz.or@gmail.com>, <james.bottomley@hansenpartnership.com>,
<indranil@chelsio.com>
Subject: RE: [net-next 0/6] common library for Chelsio drivers
Date: Mon, 11 Jul 2016 14:55:11 -0500 [thread overview]
Message-ID: <012801d1dbae$22288b90$6679a2b0$@opengridcomputing.com> (raw)
In-Reply-To: <20160711.125021.1679165284508297380.davem@davemloft.net>
> > Hi,
> >
> > This patch series adds common library module(libcxgb.ko)
> > for Chelsio drivers to remove duplicate code.
> >
> > This series moves common iSCSI DDP Page Pod manager
> > code from cxgb4.ko to libcxgb.ko, earlier this code
> > was used by only cxgbit.ko now it is used by
> > three Chelsio iSCSI drivers cxgb3i, cxgb4i, cxgbit.
> >
> > In future this module will have common connection
> > management and hardware specific code that can
> > be shared by multiple Chelsio drivers(cxgb4,
> > csiostor, iw_cxgb4, cxgb4i, cxgbit).
> >
> > Please review.
>
> As currently implemented the user is prompted for the Kconfig symbol
> for the library. That really needs to be hidden from the user and
> they should be able to select these drivers without having to know
> about this implementation detail at all.
Maybe adding something like:
select CHELSIO_LIB
to the Kconfig files for the drivers that are depenedent on CHELSIO_LIB?
prev parent reply other threads:[~2016-07-11 19:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-08 17:33 [net-next 0/6] common library for Chelsio drivers Varun Prakash
2016-07-08 17:33 ` [net-next 1/6] libcxgb: add library module " Varun Prakash
2016-07-15 14:02 ` Steve Wise
2016-07-08 17:33 ` [net-next 2/6] cxgb3i,cxgb4i,libcxgbi: remove iSCSI DDP support Varun Prakash
2016-07-15 14:05 ` Steve Wise
2016-07-16 15:44 ` Varun Prakash
2016-07-08 17:33 ` [net-next 3/6] cxgb4i,libcxgbi: add " Varun Prakash
2016-07-15 14:13 ` Steve Wise
2016-07-16 15:54 ` Varun Prakash
2016-07-08 17:33 ` [net-next 4/6] cxgb3i: " Varun Prakash
2016-07-15 14:14 ` Steve Wise
2016-07-08 17:33 ` [net-next 5/6] libcxgb: export ppm release and tagmask set api Varun Prakash
2016-07-15 14:15 ` Steve Wise
2016-07-08 17:33 ` [net-next 6/6] cxgb3i,cxgb4i: fix symbol not declared sparse warning Varun Prakash
2016-07-15 14:17 ` Steve Wise
2016-07-11 19:50 ` [net-next 0/6] common library for Chelsio drivers David Miller
2016-07-11 19:55 ` Steve Wise [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='012801d1dbae$22288b90$6679a2b0$@opengridcomputing.com' \
--to=swise@opengridcomputing.com \
--cc=davem@davemloft.net \
--cc=gerlitz.or@gmail.com \
--cc=indranil@chelsio.com \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=netdev@vger.kernel.org \
--cc=target-devel@vger.kernel.org \
--cc=varun@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).