From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH net] net: phy: consider PHY_IGNORE_INTERRUPT in phy_start_aneg_priv Date: Fri, 20 Jul 2018 02:36:21 -0700 Message-ID: <013532d7-ed33-354b-81d9-f69ad534ebe3@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: "netdev@vger.kernel.org" To: Heiner Kallweit , Andrew Lunn , David Miller Return-path: Received: from mail-wr1-f68.google.com ([209.85.221.68]:46926 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727266AbeGTKXw (ORCPT ); Fri, 20 Jul 2018 06:23:52 -0400 Received: by mail-wr1-f68.google.com with SMTP id s11-v6so10647163wra.13 for ; Fri, 20 Jul 2018 02:36:27 -0700 (PDT) In-Reply-To: Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 07/18/2018 11:15 PM, Heiner Kallweit wrote: > The situation described in the comment can occur also with > PHY_IGNORE_INTERRUPT, therefore change the condition to include it. Yes indeed! You might want to locate the offending commit to provide a fixes tag so this could be backported to stable trees. Also, for net-next, we may want to introduce a helper which checks for phydev->irq != PHY_POLL that we can use consistently as a way to tell that the conditions applies to either PHY_IGNORE_INTERRUPT or phydev->irq is valid? > > Signed-off-by: Heiner Kallweit > --- > drivers/net/phy/phy.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c > index d2baedc4..914fe8e6 100644 > --- a/drivers/net/phy/phy.c > +++ b/drivers/net/phy/phy.c > @@ -519,7 +519,7 @@ static int phy_start_aneg_priv(struct phy_device *phydev, bool sync) > * negotiation may already be done and aneg interrupt may not be > * generated. > */ > - if (phy_interrupt_is_valid(phydev) && (phydev->state == PHY_AN)) { > + if (phydev->irq != PHY_POLL && phydev->state == PHY_AN) { > err = phy_aneg_done(phydev); > if (err > 0) { > trigger = true; > -- Florian