netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 5/5] Solve host error problem in low performance embedded system when continune down and up.
@ 2006-10-14 19:57 Jesse Huang
  2006-10-31  5:39 ` How about current IP100A status? 10/31/2006 Jesse Huang
  0 siblings, 1 reply; 4+ messages in thread
From: Jesse Huang @ 2006-10-14 19:57 UTC (permalink / raw)
  To: linux-kernel, netdev, akpm, jgarzik, jesse

From: Jesse Huang <jesse@icplus.com.tw>

Change Logs:
Solve host error problem in low performance embedded system when continune 
down and up. It will cause IP100A DMA TargetAbort. So we need more safe process
to up and down IP100A with wait hardware completely stop and software cur_tx/ 
dirty_tx/cur_task/last_tx be clear.

Signed-off-by: Jesse Huang <jesse@icplus.com.tw>
---

 drivers/net/sundance.c |   26 +++++++++++++++++++++++---
 1 files changed, 23 insertions(+), 3 deletions(-)

c06c70e20a85facd640528ca66e0b579fc3ee745
diff --git a/drivers/net/sundance.c b/drivers/net/sundance.c
index 14b4933..b4a6010 100755
--- a/drivers/net/sundance.c
+++ b/drivers/net/sundance.c
@@ -1643,6 +1643,14 @@ static int netdev_close(struct net_devic
 	struct sk_buff *skb;
 	int i;
 
+	/* Wait and kill tasklet */
+	tasklet_kill(&np->rx_tasklet);
+	tasklet_kill(&np->tx_tasklet);
+	np->cur_tx = 0;
+	np->dirty_tx = 0;
+	np->cur_task = 0;
+	np->last_tx = 0;
+
 	netif_stop_queue(dev);
 
 	if (netif_msg_ifdown(np)) {
@@ -1663,9 +1671,20 @@ static int netdev_close(struct net_devic
 	/* Stop the chip's Tx and Rx processes. */
 	iowrite16(TxDisable | RxDisable | StatsDisable, ioaddr + MACCtrl1);
 
-	/* Wait and kill tasklet */
-	tasklet_kill(&np->rx_tasklet);
-	tasklet_kill(&np->tx_tasklet);
+    	for (i = 2000; i > 0; i--) {
+ 		if ((ioread32(ioaddr + DMACtrl) &0xC000) == 0)
+			break;
+		mdelay(1);
+    	}
+
+    	iowrite16(GlobalReset | DMAReset | FIFOReset | NetworkReset, ioaddr +ASICCtrl + 2);
+
+    	for (i = 2000; i > 0; i--)
+    	{
+ 		if ((ioread16(ioaddr + ASICCtrl +2) &ResetBusy) == 0)
+			break;
+		mdelay(1);
+    	}
 
 #ifdef __i386__
 	if (netif_msg_hw(np)) {
@@ -1703,6 +1722,7 @@ #endif /* __i386__ debugging only */
 		}
 	}
 	for (i = 0; i < TX_RING_SIZE; i++) {
+		np->tx_ring[i].next_desc = 0;
 		skb = np->tx_skbuff[i];
 		if (skb) {
 			pci_unmap_single(np->pci_dev,
-- 
1.3.GIT




^ permalink raw reply related	[flat|nested] 4+ messages in thread

* How about current IP100A status? 10/31/2006
  2006-10-14 19:57 [PATCH 5/5] Solve host error problem in low performance embedded system when continune down and up Jesse Huang
@ 2006-10-31  5:39 ` Jesse Huang
  0 siblings, 0 replies; 4+ messages in thread
From: Jesse Huang @ 2006-10-31  5:39 UTC (permalink / raw)
  To: Jesse Huang, linux-kernel, netdev, akpm, jgarzik

Dear All:

How about current IP100A, sundance.c status? Should it be put into kernel or
not?
Is there any sentence should I need to modify?

Thanks for your help!

Jesse Huang

----- Original Message ----- 
From: "Jesse Huang" <jesse@icplus.com.tw>
To: <linux-kernel@vger.kernel.org>; <netdev@vger.kernel.org>;
<akpm@osdl.org>; <jgarzik@pobox.com>; <jesse@icplus.com.tw>
Sent: Sunday, October 15, 2006 3:57 AM
Subject: [PATCH 5/5] Solve host error problem in low performance
embeddedsystem when continune down and up.


From: Jesse Huang <jesse@icplus.com.tw>




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: How about current IP100A status? 10/31/2006
       [not found] <002101c6fe3e$369ca1e0$4964a8c0@icplus.com.tw>
@ 2006-11-02  5:21 ` Jeff Garzik
  2006-11-02  7:56   ` Jesse Huang
  0 siblings, 1 reply; 4+ messages in thread
From: Jeff Garzik @ 2006-11-02  5:21 UTC (permalink / raw)
  To: Jesse Huang; +Cc: linux-kernel, netdev, akpm

Jesse Huang wrote:
> Dear All:
> 
> How about current IP100A, sundance.c status? Should it be put into kernel or
> not?
> Is there any sentence should I need to modify?

It's in my queue.  We are in a bug fix-only cycle right now, so it has
been a bit lower priority, but I will queue it for 2.6.20.

	Jeff




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: How about current IP100A status? 10/31/2006
  2006-11-02  5:21 ` Jeff Garzik
@ 2006-11-02  7:56   ` Jesse Huang
  0 siblings, 0 replies; 4+ messages in thread
From: Jesse Huang @ 2006-11-02  7:56 UTC (permalink / raw)
  To: Jeff Garzik; +Cc: linux-kernel, netdev, akpm

Dear Jeff:

    Thanks for your help. We are happy to see new version of
our driver will be support in the new kernel.

Best Regards,
Jesse Huang


----- Original Message ----- 
From: "Jeff Garzik" <jgarzik@pobox.com>
To: "Jesse Huang" <jesse@icplus.com.tw>
Cc: <linux-kernel@vger.kernel.org>; <netdev@vger.kernel.org>;
<akpm@osdl.org>
Sent: Thursday, November 02, 2006 1:21 PM
Subject: Re: How about current IP100A status? 10/31/2006


Jesse Huang wrote:
> Dear All:
>
> How about current IP100A, sundance.c status? Should it be put into kernel
or
> not?
> Is there any sentence should I need to modify?

It's in my queue.  We are in a bug fix-only cycle right now, so it has
been a bit lower priority, but I will queue it for 2.6.20.

Jeff

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2006-11-02  7:56 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-14 19:57 [PATCH 5/5] Solve host error problem in low performance embedded system when continune down and up Jesse Huang
2006-10-31  5:39 ` How about current IP100A status? 10/31/2006 Jesse Huang
     [not found] <002101c6fe3e$369ca1e0$4964a8c0@icplus.com.tw>
2006-11-02  5:21 ` Jeff Garzik
2006-11-02  7:56   ` Jesse Huang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).