netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v8 0/2] arm64: dts: fsd: Add Ethernet support for FSD SoC
       [not found] <CGME20250307045516epcas5p3b4006a5e2005beda04170179dc92ad16@epcas5p3.samsung.com>
@ 2025-03-07  4:49 ` Swathi K S
  2025-03-07  4:49   ` [PATCH v8 1/2] arm64: dts: fsd: Add Ethernet support for FSYS0 Block of " Swathi K S
                     ` (4 more replies)
  0 siblings, 5 replies; 7+ messages in thread
From: Swathi K S @ 2025-03-07  4:49 UTC (permalink / raw)
  To: krzk+dt, linux-fsd, robh, conor+dt, richardcochran, alim.akhtar
  Cc: jayati.sahu, swathi.ks, linux-arm-kernel, linux-samsung-soc,
	devicetree, linux-kernel, netdev, pankaj.dubey, ravi.patel,
	gost.dev

FSD platform has two instances of EQoS IP, one is in FSYS0 block and
another one is in PERIC block. This patch series add required DT file
modifications for the same.

Changes since v1:
1. Addressed the format related corrections.
2. Addressed the MAC address correction.

Changes since v2:
1. Corrected intendation issues.

Changes since v3:
1. Removed alias names of ethernet nodes

Changes since v4:
1. Added more details to the commit message as per review comment.

Changes since v5:
1. Avoided inserting node in the end and inserted it in between as per
address.
2. Changed the node label.
3. Separating DT patches from net patches and posting in different
branches.

Changes since v6:
1. Addressed Andrew's review comment and removed phy-mode from .dtsi to
.dts

Changes since v7:
1. Addressed Russell's review comment-Implemented clock tree setup in DT

Swathi K S (2):
  arm64: dts: fsd: Add Ethernet support for FSYS0 Block of FSD SoC
  arm64: dts: fsd: Add Ethernet support for PERIC Block of FSD SoC

 arch/arm64/boot/dts/tesla/fsd-evb.dts      |  20 ++++
 arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi | 112 +++++++++++++++++++++
 arch/arm64/boot/dts/tesla/fsd.dtsi         |  50 +++++++++
 3 files changed, 182 insertions(+)

-- 
2.17.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH v8 1/2] arm64: dts: fsd: Add Ethernet support for FSYS0 Block of FSD SoC
  2025-03-07  4:49 ` [PATCH v8 0/2] arm64: dts: fsd: Add Ethernet support for FSD SoC Swathi K S
@ 2025-03-07  4:49   ` Swathi K S
  2025-03-07  4:49   ` [PATCH v8 2/2] arm64: dts: fsd: Add Ethernet support for PERIC " Swathi K S
                     ` (3 subsequent siblings)
  4 siblings, 0 replies; 7+ messages in thread
From: Swathi K S @ 2025-03-07  4:49 UTC (permalink / raw)
  To: krzk+dt, linux-fsd, robh, conor+dt, richardcochran, alim.akhtar
  Cc: jayati.sahu, swathi.ks, linux-arm-kernel, linux-samsung-soc,
	devicetree, linux-kernel, netdev, pankaj.dubey, ravi.patel,
	gost.dev

The FSD SoC contains two instances of Synopsys DWC QoS Ethernet IP, one
in FSYS0 block and other in PERIC block.
The ethernet interface is managed by a switch which is not managed by
Linux.

Adds device tree node for Ethernet in FSYS0 Block and enables the same for
FSD platform.

Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
Signed-off-by: Jayati Sahu <jayati.sahu@samsung.com>
Signed-off-by: Swathi K S <swathi.ks@samsung.com>
---
 arch/arm64/boot/dts/tesla/fsd-evb.dts      | 10 ++++
 arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi | 56 ++++++++++++++++++++++
 arch/arm64/boot/dts/tesla/fsd.dtsi         | 20 ++++++++
 3 files changed, 86 insertions(+)

diff --git a/arch/arm64/boot/dts/tesla/fsd-evb.dts b/arch/arm64/boot/dts/tesla/fsd-evb.dts
index 8d7794642900..321270a07651 100644
--- a/arch/arm64/boot/dts/tesla/fsd-evb.dts
+++ b/arch/arm64/boot/dts/tesla/fsd-evb.dts
@@ -64,6 +64,16 @@
 	};
 };
 
+&ethernet0 {
+	status = "okay";
+
+	phy-mode = "rgmii-id";
+	fixed-link {
+		speed = <1000>;
+		full-duplex;
+	};
+};
+
 &fin_pll {
 	clock-frequency = <24000000>;
 };
diff --git a/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi
index 3f898cf4874c..cb437483ff6e 100644
--- a/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi
+++ b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi
@@ -64,6 +64,62 @@
 		samsung,pin-pud = <FSD_PIN_PULL_UP>;
 		samsung,pin-drv = <FSD_PIN_DRV_LV4>;
 	};
+
+	eth0_tx_clk: eth0-tx-clk-pins {
+		samsung,pins = "gpf0-0";
+		samsung,pin-function = <FSD_PIN_FUNC_2>;
+		samsung,pin-pud = <FSD_PIN_PULL_DOWN>;
+		samsung,pin-drv = <FSD_PIN_DRV_LV6>;
+	};
+
+	eth0_tx_data: eth0-tx-data-pins {
+		samsung,pins = "gpf0-1", "gpf0-2", "gpf0-3", "gpf0-4";
+		samsung,pin-function = <FSD_PIN_FUNC_2>;
+		samsung,pin-pud = <FSD_PIN_PULL_UP>;
+		samsung,pin-drv = <FSD_PIN_DRV_LV6>;
+	};
+
+	eth0_tx_ctrl: eth0-tx-ctrl-pins {
+		samsung,pins = "gpf0-5";
+		samsung,pin-function = <FSD_PIN_FUNC_2>;
+		samsung,pin-pud = <FSD_PIN_PULL_UP>;
+		samsung,pin-drv = <FSD_PIN_DRV_LV6>;
+	};
+
+	eth0_phy_intr: eth0-phy-intr-pins {
+		samsung,pins = "gpf0-6";
+		samsung,pin-function = <FSD_PIN_FUNC_2>;
+		samsung,pin-pud = <FSD_PIN_PULL_NONE>;
+		samsung,pin-drv = <FSD_PIN_DRV_LV4>;
+	};
+
+	eth0_rx_clk: eth0-rx-clk-pins {
+		samsung,pins = "gpf1-0";
+		samsung,pin-function = <FSD_PIN_FUNC_2>;
+		samsung,pin-pud = <FSD_PIN_PULL_UP>;
+		samsung,pin-drv = <FSD_PIN_DRV_LV6>;
+	};
+
+	eth0_rx_data: eth0-rx-data-pins {
+		samsung,pins = "gpf1-1", "gpf1-2", "gpf1-3", "gpf1-4";
+		samsung,pin-function = <FSD_PIN_FUNC_2>;
+		samsung,pin-pud = <FSD_PIN_PULL_UP>;
+		samsung,pin-drv = <FSD_PIN_DRV_LV6>;
+	};
+
+	eth0_rx_ctrl: eth0-rx-ctrl-pins {
+		samsung,pins = "gpf1-5";
+		samsung,pin-function = <FSD_PIN_FUNC_2>;
+		samsung,pin-pud = <FSD_PIN_PULL_UP>;
+		samsung,pin-drv = <FSD_PIN_DRV_LV6>;
+	};
+
+	eth0_mdio: eth0-mdio-pins {
+		samsung,pins = "gpf1-6", "gpf1-7";
+		samsung,pin-function = <FSD_PIN_FUNC_2>;
+		samsung,pin-pud = <FSD_PIN_PULL_NONE>;
+		samsung,pin-drv = <FSD_PIN_DRV_LV4>;
+	};
 };
 
 &pinctrl_peric {
diff --git a/arch/arm64/boot/dts/tesla/fsd.dtsi b/arch/arm64/boot/dts/tesla/fsd.dtsi
index 690b4ed9c29b..01850fbf761f 100644
--- a/arch/arm64/boot/dts/tesla/fsd.dtsi
+++ b/arch/arm64/boot/dts/tesla/fsd.dtsi
@@ -1007,6 +1007,26 @@
 			clocks = <&clock_fsys0 UFS0_MPHY_REFCLK_IXTAL26>;
 			clock-names = "ref_clk";
 		};
+
+		ethernet0: ethernet@15300000 {
+			compatible = "tesla,fsd-ethqos";
+			reg = <0x0 0x15300000 0x0 0x10000>;
+			interrupts = <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "macirq";
+			clocks = <&clock_fsys0 FSYS0_EQOS_TOP0_IPCLKPORT_CLK_PTP_REF_I>,
+				 <&clock_fsys0 FSYS0_EQOS_TOP0_IPCLKPORT_ACLK_I>,
+				 <&clock_fsys0 FSYS0_EQOS_TOP0_IPCLKPORT_HCLK_I>,
+				 <&clock_fsys0 FSYS0_EQOS_TOP0_IPCLKPORT_RGMII_CLK_I>,
+				 <&clock_fsys0 FSYS0_EQOS_TOP0_IPCLKPORT_CLK_RX_I>;
+			clock-names = "ptp_ref", "master_bus", "slave_bus", "tx", "rx";
+			pinctrl-names = "default";
+			pinctrl-0 = <&eth0_tx_clk>, <&eth0_tx_data>, <&eth0_tx_ctrl>,
+				    <&eth0_phy_intr>, <&eth0_rx_clk>, <&eth0_rx_data>,
+				    <&eth0_rx_ctrl>, <&eth0_mdio>;
+			local-mac-address = [00 00 00 00 00 00];
+			iommus = <&smmu_fsys0 0x0 0x1>;
+			status = "disabled";
+		};
 	};
 };
 
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH v8 2/2] arm64: dts: fsd: Add Ethernet support for PERIC Block of FSD SoC
  2025-03-07  4:49 ` [PATCH v8 0/2] arm64: dts: fsd: Add Ethernet support for FSD SoC Swathi K S
  2025-03-07  4:49   ` [PATCH v8 1/2] arm64: dts: fsd: Add Ethernet support for FSYS0 Block of " Swathi K S
@ 2025-03-07  4:49   ` Swathi K S
  2025-03-18 10:52   ` [PATCH v8 0/2] arm64: dts: fsd: Add Ethernet support for " Swathi K S
                     ` (2 subsequent siblings)
  4 siblings, 0 replies; 7+ messages in thread
From: Swathi K S @ 2025-03-07  4:49 UTC (permalink / raw)
  To: krzk+dt, linux-fsd, robh, conor+dt, richardcochran, alim.akhtar
  Cc: jayati.sahu, swathi.ks, linux-arm-kernel, linux-samsung-soc,
	devicetree, linux-kernel, netdev, pankaj.dubey, ravi.patel,
	gost.dev

The FSD SoC contains two instances of Synopsys DWC QoS Ethernet IP, one in
FSYS0 block and other in PERIC block.
The ethernet interface is connected to a switch which is not managed by
Linux.

Adds device tree node for Ethernet in PERIC Block and enables the same for
FSD platform.

Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
Signed-off-by: Jayati Sahu <jayati.sahu@samsung.com>
Signed-off-by: Swathi K S <swathi.ks@samsung.com>
---
 arch/arm64/boot/dts/tesla/fsd-evb.dts      | 10 ++++
 arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi | 56 ++++++++++++++++++++++
 arch/arm64/boot/dts/tesla/fsd.dtsi         | 30 ++++++++++++
 3 files changed, 96 insertions(+)

diff --git a/arch/arm64/boot/dts/tesla/fsd-evb.dts b/arch/arm64/boot/dts/tesla/fsd-evb.dts
index 321270a07651..9ff22e1c8723 100644
--- a/arch/arm64/boot/dts/tesla/fsd-evb.dts
+++ b/arch/arm64/boot/dts/tesla/fsd-evb.dts
@@ -74,6 +74,16 @@
 	};
 };
 
+&ethernet1 {
+	status = "okay";
+
+	phy-mode = "rgmii-id";
+	fixed-link {
+		speed = <1000>;
+		full-duplex;
+	};
+};
+
 &fin_pll {
 	clock-frequency = <24000000>;
 };
diff --git a/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi
index cb437483ff6e..6f4658f57453 100644
--- a/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi
+++ b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi
@@ -437,6 +437,62 @@
 		samsung,pin-pud = <FSD_PIN_PULL_DOWN>;
 		samsung,pin-drv = <FSD_PIN_DRV_LV4>;
 	};
+
+	eth1_tx_clk: eth1-tx-clk-pins {
+		samsung,pins = "gpf2-0";
+		samsung,pin-function = <FSD_PIN_FUNC_2>;
+		samsung,pin-pud = <FSD_PIN_PULL_DOWN>;
+		samsung,pin-drv = <FSD_PIN_DRV_LV6>;
+	};
+
+	eth1_tx_data: eth1-tx-data-pins {
+		samsung,pins = "gpf2-1", "gpf2-2", "gpf2-3", "gpf2-4";
+		samsung,pin-function = <FSD_PIN_FUNC_2>;
+		samsung,pin-pud = <FSD_PIN_PULL_UP>;
+		samsung,pin-drv = <FSD_PIN_DRV_LV6>;
+	};
+
+	eth1_tx_ctrl: eth1-tx-ctrl-pins {
+		samsung,pins = "gpf2-5";
+		samsung,pin-function = <FSD_PIN_FUNC_2>;
+		samsung,pin-pud = <FSD_PIN_PULL_UP>;
+		samsung,pin-drv = <FSD_PIN_DRV_LV6>;
+	};
+
+	eth1_phy_intr: eth1-phy-intr-pins {
+		samsung,pins = "gpf2-6";
+		samsung,pin-function = <FSD_PIN_FUNC_2>;
+		samsung,pin-pud = <FSD_PIN_PULL_UP>;
+		samsung,pin-drv = <FSD_PIN_DRV_LV4>;
+	};
+
+	eth1_rx_clk: eth1-rx-clk-pins {
+		samsung,pins = "gpf3-0";
+		samsung,pin-function = <FSD_PIN_FUNC_2>;
+		samsung,pin-pud = <FSD_PIN_PULL_UP>;
+		samsung,pin-drv = <FSD_PIN_DRV_LV6>;
+	};
+
+	eth1_rx_data: eth1-rx-data-pins {
+		samsung,pins = "gpf3-1", "gpf3-2", "gpf3-3", "gpf3-4";
+		samsung,pin-function = <FSD_PIN_FUNC_2>;
+		samsung,pin-pud = <FSD_PIN_PULL_UP>;
+		samsung,pin-drv = <FSD_PIN_DRV_LV6>;
+	};
+
+	eth1_rx_ctrl: eth1-rx-ctrl-pins {
+		samsung,pins = "gpf3-5";
+		samsung,pin-function = <FSD_PIN_FUNC_2>;
+		samsung,pin-pud = <FSD_PIN_PULL_UP>;
+		samsung,pin-drv = <FSD_PIN_DRV_LV6>;
+	};
+
+	eth1_mdio: eth1-mdio-pins {
+		samsung,pins = "gpf3-6", "gpf3-7";
+		samsung,pin-function = <FSD_PIN_FUNC_2>;
+		samsung,pin-pud = <FSD_PIN_PULL_UP>;
+		samsung,pin-drv = <FSD_PIN_DRV_LV4>;
+	};
 };
 
 &pinctrl_pmu {
diff --git a/arch/arm64/boot/dts/tesla/fsd.dtsi b/arch/arm64/boot/dts/tesla/fsd.dtsi
index 01850fbf761f..0fb1b508be52 100644
--- a/arch/arm64/boot/dts/tesla/fsd.dtsi
+++ b/arch/arm64/boot/dts/tesla/fsd.dtsi
@@ -979,6 +979,36 @@
 			memory-region = <&mfc_left>;
 		};
 
+		ethernet1: ethernet@14300000 {
+			compatible = "tesla,fsd-ethqos";
+			reg = <0x0 0x14300000 0x0 0x10000>;
+			interrupts = <GIC_SPI 176 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "macirq";
+			clocks = <&clock_peric PERIC_EQOS_TOP_IPCLKPORT_CLK_PTP_REF_I>,
+				 <&clock_peric PERIC_EQOS_TOP_IPCLKPORT_ACLK_I>,
+				 <&clock_peric PERIC_EQOS_TOP_IPCLKPORT_HCLK_I>,
+				 <&clock_peric PERIC_EQOS_TOP_IPCLKPORT_RGMII_CLK_I>,
+				 <&clock_peric PERIC_EQOS_TOP_IPCLKPORT_CLK_RX_I>,
+				 <&clock_peric PERIC_BUS_D_PERIC_IPCLKPORT_EQOSCLK>,
+				 <&clock_peric PERIC_BUS_P_PERIC_IPCLKPORT_EQOSCLK>,
+				 <&clock_peric PERIC_EQOS_PHYRXCLK_MUX>,
+				 <&clock_peric PERIC_EQOS_PHYRXCLK>,
+				 <&clock_peric PERIC_DOUT_RGMII_CLK>;
+			clock-names = "ptp_ref", "master_bus", "slave_bus", "tx", "rx",
+				      "master2_bus", "slave2_bus", "eqos_rxclk_mux",
+				      "eqos_phyrxclk", "dout_peric_rgmii_clk";
+			assigned-clocks = <&clock_peric PERIC_EQOS_PHYRXCLK_MUX>,
+					  <&clock_peric PERIC_EQOS_PHYRXCLK>;
+			assigned-clock-parents = <&clock_peric PERIC_EQOS_PHYRXCLK>;
+			pinctrl-names = "default";
+			pinctrl-0 = <&eth1_tx_clk>, <&eth1_tx_data>, <&eth1_tx_ctrl>,
+				    <&eth1_phy_intr>, <&eth1_rx_clk>, <&eth1_rx_data>,
+				    <&eth1_rx_ctrl>, <&eth1_mdio>;
+			local-mac-address = [00 00 00 00 00 00];
+			iommus = <&smmu_peric 0x0 0x1>;
+			status = "disabled";
+		};
+
 		ufs: ufs@15120000 {
 			compatible = "tesla,fsd-ufs";
 			reg = <0x0 0x15120000 0x0 0x200>,  /* 0: HCI standard */
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* RE: [PATCH v8 0/2] arm64: dts: fsd: Add Ethernet support for FSD SoC
  2025-03-07  4:49 ` [PATCH v8 0/2] arm64: dts: fsd: Add Ethernet support for FSD SoC Swathi K S
  2025-03-07  4:49   ` [PATCH v8 1/2] arm64: dts: fsd: Add Ethernet support for FSYS0 Block of " Swathi K S
  2025-03-07  4:49   ` [PATCH v8 2/2] arm64: dts: fsd: Add Ethernet support for PERIC " Swathi K S
@ 2025-03-18 10:52   ` Swathi K S
  2025-03-28  8:36   ` Swathi K S
  2025-04-08 16:25   ` Krzysztof Kozlowski
  4 siblings, 0 replies; 7+ messages in thread
From: Swathi K S @ 2025-03-18 10:52 UTC (permalink / raw)
  To: krzk+dt, linux-fsd, robh, conor+dt, richardcochran, alim.akhtar
  Cc: jayati.sahu, linux-arm-kernel, linux-samsung-soc, devicetree,
	linux-kernel, netdev, pankaj.dubey, ravi.patel, gost.dev



> -----Original Message-----
> From: Swathi K S <swathi.ks@samsung.com>
> Sent: 07 March 2025 10:19
> To: krzk+dt@kernel.org; linux-fsd@tesla.com; robh@kernel.org;
> conor+dt@kernel.org; richardcochran@gmail.com;
> alim.akhtar@samsung.com
> Cc: jayati.sahu@samsung.com; swathi.ks@samsung.com; linux-arm-
> kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
> netdev@vger.kernel.org; pankaj.dubey@samsung.com;
> ravi.patel@samsung.com; gost.dev@samsung.com
> Subject: [PATCH v8 0/2] arm64: dts: fsd: Add Ethernet support for FSD SoC
> 
> FSD platform has two instances of EQoS IP, one is in FSYS0 block and another
> one is in PERIC block. This patch series add required DT file modifications for
> the same.
> 
> Changes since v1:
> 1. Addressed the format related corrections.
> 2. Addressed the MAC address correction.
> 
> Changes since v2:
> 1. Corrected intendation issues.
> 
> Changes since v3:
> 1. Removed alias names of ethernet nodes
> 
> Changes since v4:
> 1. Added more details to the commit message as per review comment.
> 
> Changes since v5:
> 1. Avoided inserting node in the end and inserted it in between as per
> address.
> 2. Changed the node label.
> 3. Separating DT patches from net patches and posting in different branches.
> 
> Changes since v6:
> 1. Addressed Andrew's review comment and removed phy-mode from .dtsi
> to .dts
> 
> Changes since v7:
> 1. Addressed Russell's review comment-Implemented clock tree setup in DT
> 

Hi, 
The DT binding and driver patches corresponding to this patch is now reflecting in linux-next
https://web.git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/diff/Documentation/devicetree/bindings/net/tesla,fsd-ethqos.yaml?id=f654ead4682a1d351d4d780b1b59ab02477b1185

Could you consider these DT file patches for review/merge or do I need to resend these?

-Swathi

> Swathi K S (2):
>   arm64: dts: fsd: Add Ethernet support for FSYS0 Block of FSD SoC
>   arm64: dts: fsd: Add Ethernet support for PERIC Block of FSD SoC
> 
>  arch/arm64/boot/dts/tesla/fsd-evb.dts      |  20 ++++
>  arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi | 112 +++++++++++++++++++++
>  arch/arm64/boot/dts/tesla/fsd.dtsi         |  50 +++++++++
>  3 files changed, 182 insertions(+)
> 
> --
> 2.17.1



^ permalink raw reply	[flat|nested] 7+ messages in thread

* RE: [PATCH v8 0/2] arm64: dts: fsd: Add Ethernet support for FSD SoC
  2025-03-07  4:49 ` [PATCH v8 0/2] arm64: dts: fsd: Add Ethernet support for FSD SoC Swathi K S
                     ` (2 preceding siblings ...)
  2025-03-18 10:52   ` [PATCH v8 0/2] arm64: dts: fsd: Add Ethernet support for " Swathi K S
@ 2025-03-28  8:36   ` Swathi K S
  2025-03-28  9:37     ` Krzysztof Kozlowski
  2025-04-08 16:25   ` Krzysztof Kozlowski
  4 siblings, 1 reply; 7+ messages in thread
From: Swathi K S @ 2025-03-28  8:36 UTC (permalink / raw)
  To: krzk+dt, linux-fsd, robh, conor+dt, richardcochran, alim.akhtar
  Cc: jayati.sahu, linux-arm-kernel, linux-samsung-soc, devicetree,
	linux-kernel, netdev, pankaj.dubey, ravi.patel, gost.dev



> -----Original Message-----
> From: Swathi K S <swathi.ks@samsung.com>
> Sent: 18 March 2025 16:22
> To: 'krzk+dt@kernel.org' <krzk+dt@kernel.org>; 'linux-fsd@tesla.com'
> <linux-fsd@tesla.com>; 'robh@kernel.org' <robh@kernel.org>;
> 'conor+dt@kernel.org' <conor+dt@kernel.org>; 'richardcochran@gmail.com'
> <richardcochran@gmail.com>; 'alim.akhtar@samsung.com'
> <alim.akhtar@samsung.com>
> Cc: 'jayati.sahu@samsung.com' <jayati.sahu@samsung.com>; 'linux-arm-
> kernel@lists.infradead.org' <linux-arm-kernel@lists.infradead.org>; 'linux-
> samsung-soc@vger.kernel.org' <linux-samsung-soc@vger.kernel.org>;
> 'devicetree@vger.kernel.org' <devicetree@vger.kernel.org>; 'linux-
> kernel@vger.kernel.org' <linux-kernel@vger.kernel.org>;
> 'netdev@vger.kernel.org' <netdev@vger.kernel.org>;
> 'pankaj.dubey@samsung.com' <pankaj.dubey@samsung.com>;
> 'ravi.patel@samsung.com' <ravi.patel@samsung.com>;
> 'gost.dev@samsung.com' <gost.dev@samsung.com>
> Subject: RE: [PATCH v8 0/2] arm64: dts: fsd: Add Ethernet support for FSD
> SoC
> 
> 
> 
> > -----Original Message-----
> > From: Swathi K S <swathi.ks@samsung.com>
> > Sent: 07 March 2025 10:19
> > To: krzk+dt@kernel.org; linux-fsd@tesla.com; robh@kernel.org;
> > conor+dt@kernel.org; richardcochran@gmail.com;
> > alim.akhtar@samsung.com
> > Cc: jayati.sahu@samsung.com; swathi.ks@samsung.com; linux-arm-
> > kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org;
> > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
> > netdev@vger.kernel.org; pankaj.dubey@samsung.com;
> > ravi.patel@samsung.com; gost.dev@samsung.com
> > Subject: [PATCH v8 0/2] arm64: dts: fsd: Add Ethernet support for FSD
> > SoC
> >
> > FSD platform has two instances of EQoS IP, one is in FSYS0 block and
> > another one is in PERIC block. This patch series add required DT file
> > modifications for the same.
> >
> > Changes since v1:
> > 1. Addressed the format related corrections.
> > 2. Addressed the MAC address correction.
> >
> > Changes since v2:
> > 1. Corrected intendation issues.
> >
> > Changes since v3:
> > 1. Removed alias names of ethernet nodes
> >
> > Changes since v4:
> > 1. Added more details to the commit message as per review comment.
> >
> > Changes since v5:
> > 1. Avoided inserting node in the end and inserted it in between as per
> > address.
> > 2. Changed the node label.
> > 3. Separating DT patches from net patches and posting in different
> branches.
> >
> > Changes since v6:
> > 1. Addressed Andrew's review comment and removed phy-mode from
> .dtsi
> > to .dts
> >
> > Changes since v7:
> > 1. Addressed Russell's review comment-Implemented clock tree setup in
> > DT
> >
> 
> Hi,
> The DT binding and driver patches corresponding to this patch is now
> reflecting in linux-next
> https://web.git.kernel.org/pub/scm/linux/kernel/git/next/linux-
> next.git/diff/Documentation/devicetree/bindings/net/tesla,fsd-
> ethqos.yaml?id=f654ead4682a1d351d4d780b1b59ab02477b1185
> 

Hi reviewers, 
Could you please confirm whether this set of patches can be considered for review or should I resend them?

- Swathi

> Could you consider these DT file patches for review/merge or do I need to
> resend these?
> 
> -Swathi
> 
> > Swathi K S (2):
> >   arm64: dts: fsd: Add Ethernet support for FSYS0 Block of FSD SoC
> >   arm64: dts: fsd: Add Ethernet support for PERIC Block of FSD SoC
> >
> >  arch/arm64/boot/dts/tesla/fsd-evb.dts      |  20 ++++
> >  arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi | 112
> +++++++++++++++++++++
> >  arch/arm64/boot/dts/tesla/fsd.dtsi         |  50 +++++++++
> >  3 files changed, 182 insertions(+)
> >
> > --
> > 2.17.1



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v8 0/2] arm64: dts: fsd: Add Ethernet support for FSD SoC
  2025-03-28  8:36   ` Swathi K S
@ 2025-03-28  9:37     ` Krzysztof Kozlowski
  0 siblings, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2025-03-28  9:37 UTC (permalink / raw)
  To: Swathi K S, krzk+dt, linux-fsd, robh, conor+dt, richardcochran,
	alim.akhtar
  Cc: jayati.sahu, linux-arm-kernel, linux-samsung-soc, devicetree,
	linux-kernel, netdev, pankaj.dubey, ravi.patel, gost.dev

On 28/03/2025 09:36, Swathi K S wrote:
> 
> 
>> -----Original Message-----
>> From: Swathi K S <swathi.ks@samsung.com>
>> Sent: 18 March 2025 16:22
>> To: 'krzk+dt@kernel.org' <krzk+dt@kernel.org>; 'linux-fsd@tesla.com'
>> <linux-fsd@tesla.com>; 'robh@kernel.org' <robh@kernel.org>;
>> 'conor+dt@kernel.org' <conor+dt@kernel.org>; 'richardcochran@gmail.com'
>> <richardcochran@gmail.com>; 'alim.akhtar@samsung.com'
>> <alim.akhtar@samsung.com>
>> Cc: 'jayati.sahu@samsung.com' <jayati.sahu@samsung.com>; 'linux-arm-
>> kernel@lists.infradead.org' <linux-arm-kernel@lists.infradead.org>; 'linux-
>> samsung-soc@vger.kernel.org' <linux-samsung-soc@vger.kernel.org>;
>> 'devicetree@vger.kernel.org' <devicetree@vger.kernel.org>; 'linux-
>> kernel@vger.kernel.org' <linux-kernel@vger.kernel.org>;
>> 'netdev@vger.kernel.org' <netdev@vger.kernel.org>;
>> 'pankaj.dubey@samsung.com' <pankaj.dubey@samsung.com>;
>> 'ravi.patel@samsung.com' <ravi.patel@samsung.com>;
>> 'gost.dev@samsung.com' <gost.dev@samsung.com>
>> Subject: RE: [PATCH v8 0/2] arm64: dts: fsd: Add Ethernet support for FSD
>> SoC
>>
>>
>>
>>> -----Original Message-----
>>> From: Swathi K S <swathi.ks@samsung.com>
>>> Sent: 07 March 2025 10:19
>>> To: krzk+dt@kernel.org; linux-fsd@tesla.com; robh@kernel.org;
>>> conor+dt@kernel.org; richardcochran@gmail.com;
>>> alim.akhtar@samsung.com
>>> Cc: jayati.sahu@samsung.com; swathi.ks@samsung.com; linux-arm-
>>> kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org;
>>> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
>>> netdev@vger.kernel.org; pankaj.dubey@samsung.com;
>>> ravi.patel@samsung.com; gost.dev@samsung.com
>>> Subject: [PATCH v8 0/2] arm64: dts: fsd: Add Ethernet support for FSD
>>> SoC
>>>
>>> FSD platform has two instances of EQoS IP, one is in FSYS0 block and
>>> another one is in PERIC block. This patch series add required DT file
>>> modifications for the same.
>>>
>>> Changes since v1:
>>> 1. Addressed the format related corrections.
>>> 2. Addressed the MAC address correction.
>>>
>>> Changes since v2:
>>> 1. Corrected intendation issues.
>>>
>>> Changes since v3:
>>> 1. Removed alias names of ethernet nodes
>>>
>>> Changes since v4:
>>> 1. Added more details to the commit message as per review comment.
>>>
>>> Changes since v5:
>>> 1. Avoided inserting node in the end and inserted it in between as per
>>> address.
>>> 2. Changed the node label.
>>> 3. Separating DT patches from net patches and posting in different
>> branches.
>>>
>>> Changes since v6:
>>> 1. Addressed Andrew's review comment and removed phy-mode from
>> .dtsi
>>> to .dts
>>>
>>> Changes since v7:
>>> 1. Addressed Russell's review comment-Implemented clock tree setup in
>>> DT
>>>
>>
>> Hi,
>> The DT binding and driver patches corresponding to this patch is now
>> reflecting in linux-next
>> https://web.git.kernel.org/pub/scm/linux/kernel/git/next/linux-
>> next.git/diff/Documentation/devicetree/bindings/net/tesla,fsd-
>> ethqos.yaml?id=f654ead4682a1d351d4d780b1b59ab02477b1185
>>
> 
> Hi reviewers, 
> Could you please confirm whether this set of patches can be considered for review or should I resend them?

Don't ping during merge window.

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v8 0/2] arm64: dts: fsd: Add Ethernet support for FSD SoC
  2025-03-07  4:49 ` [PATCH v8 0/2] arm64: dts: fsd: Add Ethernet support for FSD SoC Swathi K S
                     ` (3 preceding siblings ...)
  2025-03-28  8:36   ` Swathi K S
@ 2025-04-08 16:25   ` Krzysztof Kozlowski
  4 siblings, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2025-04-08 16:25 UTC (permalink / raw)
  To: krzk+dt, linux-fsd, robh, conor+dt, richardcochran, alim.akhtar,
	Swathi K S
  Cc: jayati.sahu, linux-arm-kernel, linux-samsung-soc, devicetree,
	linux-kernel, netdev, pankaj.dubey, ravi.patel, gost.dev


On Fri, 07 Mar 2025 10:19:02 +0530, Swathi K S wrote:
> FSD platform has two instances of EQoS IP, one is in FSYS0 block and
> another one is in PERIC block. This patch series add required DT file
> modifications for the same.
> 
> Changes since v1:
> 1. Addressed the format related corrections.
> 2. Addressed the MAC address correction.
> 
> [...]

Applied, thanks!

[1/2] arm64: dts: fsd: Add Ethernet support for FSYS0 Block of FSD SoC
      https://git.kernel.org/krzk/linux/c/1d62af229b18bff2430ea5dde0e129d43515e12c
[2/2] arm64: dts: fsd: Add Ethernet support for PERIC Block of FSD SoC
      https://git.kernel.org/krzk/linux/c/ebeab0be707ddcffd2b7f6ff4f9bd8e0c1c49fdd

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2025-04-08 16:25 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <CGME20250307045516epcas5p3b4006a5e2005beda04170179dc92ad16@epcas5p3.samsung.com>
2025-03-07  4:49 ` [PATCH v8 0/2] arm64: dts: fsd: Add Ethernet support for FSD SoC Swathi K S
2025-03-07  4:49   ` [PATCH v8 1/2] arm64: dts: fsd: Add Ethernet support for FSYS0 Block of " Swathi K S
2025-03-07  4:49   ` [PATCH v8 2/2] arm64: dts: fsd: Add Ethernet support for PERIC " Swathi K S
2025-03-18 10:52   ` [PATCH v8 0/2] arm64: dts: fsd: Add Ethernet support for " Swathi K S
2025-03-28  8:36   ` Swathi K S
2025-03-28  9:37     ` Krzysztof Kozlowski
2025-04-08 16:25   ` Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).