From: "Paul Rolland" <rol@as2917.net>
To: "'Paul Rolland'" <rol@as2917.net>,
"'Stephen Hemminger'" <shemminger@osdl.org>,
<cfriesen@nortelnetworks.com>, <paulus@samba.org>
Cc: <linux-ppp@vger.kernel.org>, <netdev@oss.sgi.com>
Subject: Re: [BUG]: problem when shutting down ppp connection since 2.5.70
Date: Mon, 14 Jul 2003 13:43:51 +0200 [thread overview]
Message-ID: <018201c349fd$330a6a60$2101a8c0@witbe> (raw)
In-Reply-To:
Hello,
I'm sorry, the patch was not complete, it should have considered the
BUG_ON too...
Here is one that is fine on my system :
--- dev.c.orig 2003-07-14 13:41:33.000000000 +0200
+++ dev.c 2003-07-14 13:34:27.000000000 +0200
@@ -2742,7 +2742,7 @@
unsigned long rebroadcast_time, warning_time;
rebroadcast_time = warning_time = jiffies;
- while (atomic_read(&dev->refcnt) != 0) {
+ while (atomic_read(&dev->refcnt) > 0) {
if (time_after(jiffies, rebroadcast_time + 1 * HZ)) {
rtnl_shlock();
rtnl_exlock();
@@ -2836,7 +2836,7 @@
dev->reg_state = NETREG_UNREGISTERED;
netdev_wait_allrefs(dev);
- BUG_ON(atomic_read(&dev->refcnt));
+ BUG_ON(atomic_read(&dev->refcnt) > 0);
netdev_finish_unregister(dev);
break;
Still don't understand why refcnt is really bad (negative value),
but at least the machine is working...
Paul
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
I have a vitally important role serving as a bad example.
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
next reply other threads:[~2003-07-14 11:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-14 11:43 Paul Rolland [this message]
[not found] <3EFFA1EA.7090502@nortelnetworks.com>
2003-07-03 5:17 ` [BUG]: problem when shutting down ppp connection since 2.5.70 Chris Friesen
2003-07-06 9:43 ` Paul Rolland
2003-07-09 18:43 ` Stephen Hemminger
2003-07-14 9:16 ` Paul Rolland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='018201c349fd$330a6a60$2101a8c0@witbe' \
--to=rol@as2917.net \
--cc=cfriesen@nortelnetworks.com \
--cc=linux-ppp@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=paulus@samba.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).