From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793106122; b=nlO9s0oScWMnw0+9CFGqz8nmxDoIsMNWekGKMmtUo1DYgpzBhdrZT60+IAHVe8APYDdj +FK+I8QvIDqoPbNat+uC4YlfK/H8VZWwC2ierQdBeuFVg4tWwMZSMhMGHB0BEJ0EWLlye LOCyqhZPho8BQoTv3nnOlouNv3myZhcunbkJ7vE43P2aQBIWwWWBMtuthLqt2cxleyJ2s YO16dvwA/AvCoP2Jzn4ppOJYa7txlIMN7ck/9NCl6dRj3dsKcRs8V0Sie6yQA9TNnkDWP jPvCH9fW7tzEayw8wDSPApDKzY5L9Z6Bq9U2sYYEfd0YJJRPldHEWEsrxZu7s0Gw/3Q== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793106122; h=Received:DKIM-Signature:Received:Received:X-ME-Sender: X-ME-Proxy-Cause:X-ME-Proxy:Feedback-ID:Received:X-Mailer: MIME-Version:X-ThreadId:Date:From:To:Cc:Message-Id:In-Reply-To: References:Subject:Content-Type:Content-Transfer-Encoding; bh=i9G2JCIv/JRmW0kQ4TGfObM2TEv6afLzmEbFfR5oV6Q=; b=d2aYode+T8AMzFofDqlxNRum1u7x+EcxVtKPgBu8KSxYnsU3gXHisS8swovM8uqoh8Fn 4evl4ALhZcZLH12p5nMSU5Shj/ZDhKB0MEtD7bXXJQQt4mUFKcw6ypiy1sdCaMragQwaH uN5REjM3PQBufJARlnLZ7NzAgk6pktAhqbURmjjrTqVZFtjD8phckJXshgFIfwo3XVb0p 6eTvDt7/hJhM7M1v4fhWFt2OKlCzeFZPVPmH8C9HuekKYcYOkZ3san0MEw8eNzKIqR+rE TL9HttB7nb1WnPf65O+DpLuNQ75DkGOVnq3bJdJeEFWzNX98OrARwdGpLTg/cZ3T3eg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=LfiJL7Kp; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96C15606A31A for ; Tue, 27 Oct 2026 13:01:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=LfiJL7Kp Received: by smtp.kernel.org (Postfix) with ESMTPSA id D40211F01825; Tue, 27 Oct 2026 13:01:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793106117; bh=i9G2JCIv/JRmW0kQ4TGfObM2TEv6afLzmEbFfR5oV6Q=; h=Date:From:To:Cc:In-Reply-To:References:Subject; b=LfiJL7Kp0zGuKPKa1HkxBdTP/+WegoU7cmRw8MAC9klelGfHV8Wnxpcjqfn9mmu+Y YH71AAHiNlk5EdegPfv61+UJE0E25iZj3y5NjhLK0k9guUNezY/rVCc41p8U6SVqIg kOyiySMmrII1mxtRpNkWwFLiTFr1LDwT5EVIztSuHZcpCxjGvGvh8VjCDtyJCrjN+G HHRlZhCR1iX2jnuiwmHjuVeoijMAWs9grEqLC70Su+seMOkYC/J5pAp7jstTdO/xfB iGhpGeYUdS7m8wr9p9jXv/IEolNYIzQvh391QGQ1J6+uM19FpgRkqW9EXgabFBWkf3 bGMQihrED0FBw== Received: from phl-compute-10.internal (phl-compute-10.internal [10.202.2.50]) by mailfauth.phl.internal (Postfix) with ESMTP id 30629F4006A; Tue, 27 Oct 2026 09:01:56 -0400 (EDT) Received: from phl-imap-15 ([10.202.2.104]) by phl-compute-10.internal (MEProxy); Tue, 27 Oct 2026 09:01:56 -0400 X-ME-Sender: X-ME-Proxy-Cause: dmFkZTFOU1y/OvKrSgcBPQXB3dGTEzPY65VfwI2jHkcwvBEJ7fusGIrsTDPIiT3U2qIKO6 1BU5iLekNYC+Lw+CXK4idgeJYmaDaMT11Oeryr9fmpb9/gyqlkGKYShNKo9wH57EKPgTPg 6MdG0A032ddgvmlRU6KD+vqj93RYQUhpkq6BZcVXklu85y7a7O25YlVIBZ+NIKW5ENCf8Z cicaBDIxq4KhAthXRzgWcqNTPNfcwuTqOf7Vjin9c8Zooj6npV1MqHbtgZZQG2TqWRe++t 9zBYx61VoDDNcMql/nivbpcUmjPpXZVqDm3lxMnXyEclczbYfPaiBxEKMLg83EPt72Hak5 stLyjAtaOiy8Fox+semeihPu0FGK6gQIFIxdPG/QGk25w3KkcTlupJqZbpFga/7i4LCwsK 76vcqCmxO0G3a9fgd0CCfkMZCLkBuoB6G3ad4k7lv1hl0uHYOT7xWQi/WfhUVo7QmGela9 PPnW5u+Ku3vLUjUBXQ5cDc1S0GyE51OBItbw8MKzsQQwsDc1OBs/LU6mKPLE4scEGex/E9 OB0XPeMIZ1FstyP1VjpHlhc41C/LKBV10CTeCy06GB2cYAPBflMEycFPFkGv9o4QMaxnlh hoOMFUf4caQbSGQgL8Ib49EFf9YnCZbI5vTIfQCNXRZ5aCY6zAgz8Cl2wVbw X-ME-Proxy: Feedback-ID: ifa6e4810:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 09958782738; Tue, 27 Oct 2026 09:01:56 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface X-Mailing-List: netdev@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 X-ThreadId: AjA0I-APw1sV Date: Tue, 27 Oct 2026 09:01:35 -0400 From: "Chuck Lever" To: "Jakub Kicinski" Cc: "John Fastabend" , "Sabrina Dubroca" , "David S. Miller" , "Paolo Abeni" , "Simon Horman" , "Dave Watson" , "Shuah Khan" , "Qingfang Deng" , "Eric Dumazet" , netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, sashiko-bot , sashiko-bot Message-Id: <01a7e46d-033c-4a39-ae32-0b7bdde47ca6@app.fastmail.com> In-Reply-To: <20261026153748.29911bae@kernel.org> References: <20261019-tls-follow-on-v6-0-ab01c4ecca0c@kernel.org> <20261026153748.29911bae@kernel.org> Subject: Re: [PATCH net-next v6 0/9] net/tls: Receive-path fixes for zero-length data records Content-Type: text/plain Content-Transfer-Encoding: 7bit On Mon, Oct 26, 2026, at 6:37 PM, Jakub Kicinski wrote: > On Mon, 19 Oct 2026 12:55:16 -0400 Chuck Lever wrote: >> Commit 3be28e2c9cd0 ("net/tls: Consume empty data records in >> tls_sw_read_sock()") fixed one reader. TLS 1.2 and TLS 1.3 both >> permit a zero-length application_data record as a traffic-analysis >> countermeasure (RFC 5246, Section 6.2.1; RFC 8446, Section 5.1), so >> a peer that pads its stream emits them by design. The other two >> software readers still mishandle them. splice(2) reports an empty >> record as EOF, and the caller tears down a connection that is still >> live. recvmsg(2) makes no progress on one, so a peer that streams >> them holds the caller in the kernel past SIGKILL. With MSG_PEEK or >> async decryption, each record is also queued on rx_list, which >> grows without bound. > > The shape of this series is still quite confusing to me. > Let me take over a little bit so that we make some progress > (while retaining your authorship where possible). Fair enough, thanks! The first 2 patches look fine to me. I'm not sure whether I need to add an Ack -- they already carry my SoB. -- Chuck Lever (Come to NFS bake-a-thon! https://nfsv4bat.org)