Re: [EXTERNAL]Re: [PATCH net-next v5 2/2] net: pse-pd: Add Si3474 PSE controller driver

[Piotr Kubik <piotr.kubik@adtran.com>]

On 7/18/25 19:26, Kory Maincent wrote:
> Le Fri, 11 Jul 2025 11:25:02 +0000,
> Piotr Kubik <piotr.kubik@adtran.com> a écrit :
...
> 
>> +static int si3474_pi_get_admin_state(struct pse_controller_dev *pcdev, int
>> id,
>> +				     struct pse_admin_state *admin_state)
>> +{
>> +	struct si3474_priv *priv = to_si3474_priv(pcdev);
>> +	struct i2c_client *client;
>> +	s32 ret;
>> +	u8 chan0, chan1;
>> +	bool is_enabled = false;
> 
> I think you forgot to fix the xmas style here. 
...>> +
>> +static int si3474_pi_disable(struct pse_controller_dev *pcdev, int id)
>> +{
>> +	struct si3474_priv *priv = to_si3474_priv(pcdev);
>> +	struct i2c_client *client;
>> +	s32 ret;
>> +	u8 chan0, chan1;
>> +	u8 val = 0;
> 
> And here, and other places in the patch. Are you sure you did it as you
> described in your cover letter?
> The code seems ok otherwise.

Well, my bad. I read too quickly and understood netdev rev xmas style description:
"Order the variable declaration lines longest to shortest"
as order the variable declaration by their size, longest to shortest (which I even considered reasonable)

Will fix 

Thanks 
/Piotr