From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDE42377577 for ; Fri, 8 May 2026 14:03:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778249027; cv=none; b=TQQo4dHaJMlG9A1vQCAXWR1lwA892XeAWi6KRze2D90wzGZrCCjrdDIeHrVZJoPuIkTq9kxb4W4mRvLKmZLTsnMKlILTi+MtUCuDxAq+aN5mjmK/M0FMT1Xjf2h+TtXcYjMmg/PkQHiKG07qdJiVASE2EE2xmVVOXtJb/nvSODU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778249027; c=relaxed/simple; bh=tVLN9H4wXbxCspwoH2tS6QtKKtprn15Te8BRG+V6lVg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AwepEHB7jByWmHPFhh+aV3TM1h7eSEKR0468CdGfzXgc/o2ABTvna6JvG48tT6UPo/1W3BpQzBeoAp2F6qognqLQ1VWt/+nktNITaUp+6pJb0G6fuzxyYCFdfWI7qWmq4V5YPcTU5omv18dYLn9afC5tFgBRNM/LBT60C8TPTQ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=A/sY6KHY; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RAgxulmI; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="A/sY6KHY"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RAgxulmI" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 648Bf0562778224 for ; Fri, 8 May 2026 14:03:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 6PaLrzZ/Tau/BNFGUX9KOBZJHsqcYNs5C4hkDbabRvQ=; b=A/sY6KHYIFcKhS94 NhiWomB1DvClA0fBtyGO6SgZcMfBuYQ50w+MPtem2yUW8HZxGwFdM22iBWMXYWEK SPLwfIZ7yqcelZQLTFFzBrIEfpTVEPX6pSmM8dQ0fLc77cdDpBzRCkgOnUQXs5xo hrvbnHXiC1I2Yf+kaO2ruFaVnrfojf4/+Rk9k5No29B4iwKmlAjb0mIp4lYGLjHK jMfMZHNnUXlr1+m3x4NrTHDxRXBgOprkfUICLIXLX2sj+tPP026KpsDia3MPJNCK C102f0AIeG6Q9UrWboM111YS23g0oJyYeng21kCsv3dqgcJYLEx5N+4tbmCl6Ftg KRL3NA== Received: from mail-ot1-f71.google.com (mail-ot1-f71.google.com [209.85.210.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e1285kgph-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 08 May 2026 14:03:45 +0000 (GMT) Received: by mail-ot1-f71.google.com with SMTP id 46e09a7af769-7def9da8485so551128a34.1 for ; Fri, 08 May 2026 07:03:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778249024; x=1778853824; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6PaLrzZ/Tau/BNFGUX9KOBZJHsqcYNs5C4hkDbabRvQ=; b=RAgxulmIV9ITf0LZ0rgjIy+Y16/dkHdgdyAIufxSZKriKDoKOSsmzlbLh+ncsMyfio l+MkwJ/xTaIFblmmAnw5HzLRHeHxPnibebOXl+2N7NVvXFR3VK10pfFCWw4RlT2gYq1s 5+eCTX5FmlTtX67Lx/eY+cTysulXK97B1iSDWTEbDH3N0BU3Sk5nZ67bny/eY6ssvwcS 59Iq636N+RssjJhBRVfuZ0oD5jGmdv1YJZlIqUnUrcCruRlsvnORnrRN5pRlhc9/TR7p rVcUmGhMnJDaRalPmFgb3ngd0aailqCqqzWokZh2QlvE7/x8yJ3qvurDNQM0WxuSkXYM fzrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778249024; x=1778853824; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6PaLrzZ/Tau/BNFGUX9KOBZJHsqcYNs5C4hkDbabRvQ=; b=qZMX37eFBSGpCeSstOCpPEUvFm6wTe21OZQEnUns058xValGwHkLT5fKG8XMnVfTXN u81vmjZim9f9hbqbXlF1Q2hGHY53GhfYQJUbQSFG+j6MpHoV71hZ6PSUIvJoBWFmNOmr d6JgPiHyTGHoOkdE9uu/RTp0JFpITVv8IUOzd7Ku3gd6qUrmCd+i0MmXtjj1VjIAoEF8 gIbe/ncIVF9XccVofQ4p2MJrFXISJNxfrmCpHmkjhUUCPPorxPy5ZD56fPuC452t5uEO DNXsr2L4Y5a9CrURo3zW2myk1UI3r7u8UGRMoHOAmHtO2+/08xQ+/fyKOHir5uHCxVXa vQxw== X-Forwarded-Encrypted: i=1; AFNElJ86Nl136ICkKkhhV4Yj59zKImWw55ew7iciA4oIxEzbi/7E9x7W5jEEOubWp8qszBgeMSbgN4U=@vger.kernel.org X-Gm-Message-State: AOJu0YxUxocUZSsLtGUzWonu8VkhLQB39qQmOY2cNTr0/FeeiNZ8hSGl T0TkbqEPjdqRLePdOpF3gupJIIdlCjFm2y6DGHMdyyNFk88Z3hiyidALU2eLg8yqGbzhIXE/+QO dnQ0l7Fp5TeDnDB55mdAp9OV1Ao8qPHtC0HvE4CQvou61FQYy7Ji4Eh0hJJc= X-Gm-Gg: AeBDiet8cyMNIQEIqL+V5eBG5u7MfJ0etvMSVmDdHhaKoJRVL0uSuSZuDJebHsGdLhX 51bMzb50hRI+p7+Dju2dhkbaNN67BwawiPVgSK5k5+w5CcY9g9p/3B+HwTQhYlpGp/ulIy5XcR4 3FSWGrj/v43dx1UjTgbTVl3gkI0VEiGuwAiWO4YPCS2yxRAApSTzWJlqYcyTXKqVgF08VME3G9P qyyT5HQk9RYDGjnnD+stsuTR8GVL5gaMEaxJHU23QXQKzdCfC+uGtQP+z7QIdAufBbb0bA3/Jvy 8lQ6GVBO6IEpX6vLSKuOexqWNfxQS6duHW+Y9M4F2ADKpgHAB08TC/qNPOTqA4JZepcEfaNKdCh +veoo48hNgS6UGMFI28k+4TFsNSEsfsKwsVyY3VdVRmOn+gsWOPywd3pCMX7mxQlDUG0d4xok+l KbZ/E= X-Received: by 2002:a05:6830:2b29:b0:7dc:c31e:7823 with SMTP id 46e09a7af769-7e1df018fc4mr4435633a34.4.1778249024115; Fri, 08 May 2026 07:03:44 -0700 (PDT) X-Received: by 2002:a05:6830:2b29:b0:7dc:c31e:7823 with SMTP id 46e09a7af769-7e1df018fc4mr4435567a34.4.1778249023494; Fri, 08 May 2026 07:03:43 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bcac4358cedsm87169366b.47.2026.05.08.07.03.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 May 2026 07:03:42 -0700 (PDT) Message-ID: <01d6ea18-e022-41c7-a642-ac0321957923@oss.qualcomm.com> Date: Fri, 8 May 2026 16:03:36 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 12/12] arm64: dts: qcom: qcs6490-rb3gen2: enable TC9564 with a single QCS8081 phy To: Alex Elder , andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, maxime.chevallier@bootlin.com, rmk+kernel@armlinux.org.uk, andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linusw@kernel.org, brgl@kernel.org, arnd@arndb.de, gregkh@linuxfoundation.org Cc: Daniel Thompson , mohd.anwar@oss.qualcomm.com, a0987203069@gmail.com, alexandre.torgue@foss.st.com, ast@kernel.org, boon.khai.ng@altera.com, chenchuangyu@xiaomi.com, chenhuacai@kernel.org, daniel@iogearbox.net, hawk@kernel.org, hkallweit1@gmail.com, inochiama@gmail.com, john.fastabend@gmail.com, julianbraha@gmail.com, livelycarpet87@gmail.com, matthew.gerlach@altera.com, mcoquelin.stm32@gmail.com, me@ziyao.cc, prabhakar.mahadev-lad.rj@bp.renesas.com, richardcochran@gmail.com, rohan.g.thomas@altera.com, sdf@fomichev.me, siyanteng@cqsoftware.com.cn, weishangjuan@eswincomputing.com, wens@kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260501155421.3329862-1-elder@riscstar.com> <20260501155421.3329862-13-elder@riscstar.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260501155421.3329862-13-elder@riscstar.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA4MDE0MiBTYWx0ZWRfXxj+EtCIj9X25 egq8ADw4aQiUbf5A0ksYJYSektv4A7Bq4njIcj9/pupae2XluZDf9MkPwze6Z0etjNZMs3fGZhy owOIFi4z8RuyAF0OLAszoM+DrxgTy2hjriB1ondOzJdac5+3f+UFpgK4KbTGMWck+nJvnmwIQHu AaVET950JBoRD1ACytdYpAws9brJluwoEZNM0aiNDc/zEsn+M0k87/lY4elxs9vtGQ07FxZNGQj khq3vGlcyxnbw4hLIirk80DQI6im5GAL9JmijAsv6sFe1qwmRQrBDZoAp8icKgP5/2m1yKG+U1R De3vvGyYUuktTpN5Rfpq9NRjMFcIFyaPtWpNh3aNxtmg8t1i94daHClUieSIJU24FYZPPQS7+pS 0vX70lryYcIk+G7WmfSOWomYYecJDUbQWu9+3qiy2q9BesNG+ybrxIj048Lkzw1FsELNy8FaseC LU9c54+SKO/FQYhIPEw== X-Proofpoint-GUID: VlmUugV48SOlEp3Ssti7bKR4HG4ByQ-9 X-Proofpoint-ORIG-GUID: VlmUugV48SOlEp3Ssti7bKR4HG4ByQ-9 X-Authority-Analysis: v=2.4 cv=NKblPU6g c=1 sm=1 tr=0 ts=69fded41 cx=c_pps a=OI0sxtj7PyCX9F1bxD/puw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=ee_2aqc6AAAA:8 a=lW0hg0oAPnnF6MRRTAsA:9 a=QEXdDO2ut3YA:10 a=Z1Yy7GAxqfX1iEi80vsk:22 a=VOpmJXOdbJOWo2YY3GeN:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-07_02,2026-05-08_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 impostorscore=0 spamscore=0 clxscore=1015 malwarescore=0 lowpriorityscore=0 phishscore=0 priorityscore=1501 suspectscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605080142 On 5/1/26 5:54 PM, Alex Elder wrote: > From: Daniel Thompson > > The QCS6490 RB3Gen2 includes a Toshiba TC9564 (a.k.a. Qualcomm QPS615). > TC9564 is an twin Ethernet-AVB/TSN bridge with an integrated PCIe switch. > > There are multiple builds of RB3Gen2 with components included/excluded. > That means whether or not there is a phy attached to eMAC0 depends on > the exact board. However all versions include a TC9564 combined with a > single QCS8081 attached to eMAC1. > > Add properties to the existing PCI nodes to describe how the TC9564 and > QCS8081 are connected to each other (and to the host SoC). > > (Note: "pci1179,0220" is documented in the "net/toshiba,tc956x-dwmac.yaml" > binding, but checkpatch.pl doesn't recognize that.) This should probably go under the --- line [...] > + qep_1p8: regulator-qep-1p8 { > + compatible = "regulator-fixed"; > + regulator-name = "qep_1p8"; > + gpio = <&pm7325_gpios 8 GPIO_ACTIVE_HIGH>; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + enable-active-high; > + regulator-always-on; > + }; If I'm reading the schematics right, this is only required for the PHY - is it collapsible, or does it really need to be a-on? [...] > + qep_irq_pin: qep-irq-state { > + pins = "gpio101"; > + function = "gpio"; > + drive-strength = <2>; > + bias-disable; There's no pull-up onboard, should we use the on-chip one? Konrad