From: David Ahern <dsahern@gmail.com>
To: Stephen Suryaputra <ssuryaextr@gmail.com>, netdev@vger.kernel.org
Subject: Re: [PATCH net,v3] vrf: check forwarding on the original netdevice when generating ICMP dest unreachable
Date: Wed, 28 Feb 2018 11:19:18 -0700 [thread overview]
Message-ID: <01df17c0-34e4-7e40-746d-0408ff1f3d58@gmail.com> (raw)
In-Reply-To: <1519838444-20309-1-git-send-email-ssuryaextr@gmail.com>
On 2/28/18 10:20 AM, Stephen Suryaputra wrote:
> When ip_error() is called the device is the l3mdev master instead of the
> original device. So the forwarding check should be on the original one.
>
> Changes from v2:
> - Handle the original device disappearing (per David Ahern)
> - Minimize the change in code order
>
> Changes from v1:
> - Only need to reset the device on which __in_dev_get_rcu() is done (per
> David Ahern).
>
> Signed-off-by: Stephen Suryaputra <ssuryaextr@gmail.com>
> ---
> net/ipv4/route.c | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
Acked-by: David Ahern <dsahern@gmail.com>
prev parent reply other threads:[~2018-02-28 18:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 17:20 [PATCH net,v3] vrf: check forwarding on the original netdevice when generating ICMP dest unreachable Stephen Suryaputra
2018-02-28 18:19 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01df17c0-34e4-7e40-746d-0408ff1f3d58@gmail.com \
--to=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=ssuryaextr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).