From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f54.google.com ([74.125.83.54]:44407 "EHLO mail-pg0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932381AbeB1STV (ORCPT ); Wed, 28 Feb 2018 13:19:21 -0500 Received: by mail-pg0-f54.google.com with SMTP id l4so1243720pgp.11 for ; Wed, 28 Feb 2018 10:19:21 -0800 (PST) Subject: Re: [PATCH net,v3] vrf: check forwarding on the original netdevice when generating ICMP dest unreachable To: Stephen Suryaputra , netdev@vger.kernel.org References: <1519838444-20309-1-git-send-email-ssuryaextr@gmail.com> From: David Ahern Message-ID: <01df17c0-34e4-7e40-746d-0408ff1f3d58@gmail.com> Date: Wed, 28 Feb 2018 11:19:18 -0700 MIME-Version: 1.0 In-Reply-To: <1519838444-20309-1-git-send-email-ssuryaextr@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: On 2/28/18 10:20 AM, Stephen Suryaputra wrote: > When ip_error() is called the device is the l3mdev master instead of the > original device. So the forwarding check should be on the original one. > > Changes from v2: > - Handle the original device disappearing (per David Ahern) > - Minimize the change in code order > > Changes from v1: > - Only need to reset the device on which __in_dev_get_rcu() is done (per > David Ahern). > > Signed-off-by: Stephen Suryaputra > --- > net/ipv4/route.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > Acked-by: David Ahern