From: "Steve Wise" <swise@opengridcomputing.com>
To: "'Leon Romanovsky'" <leon@kernel.org>,
"'Doug Ledford'" <dledford@redhat.com>
Cc: <dsahern@gmail.com>, <stephen@networkplumber.org>,
<netdev@vger.kernel.org>, <linux-rdma@vger.kernel.org>
Subject: RE: [PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes
Date: Tue, 15 May 2018 12:51:16 -0500 [thread overview]
Message-ID: <01ee01d3ec75$52feb7b0$f8fc2710$@opengridcomputing.com> (raw)
In-Reply-To: <20180515165955.GD10381@mtr-leonro.mtl.com>
>
> On Tue, May 15, 2018 at 12:35:34PM -0400, Doug Ledford wrote:
> > On Mon, 2018-05-14 at 09:51 -0500, Steve Wise wrote:
> > >
> > > On 5/13/2018 8:24 AM, Leon Romanovsky wrote:
> > > > On Mon, May 07, 2018 at 08:53:16AM -0700, Steve Wise wrote:
> > > > > This enhancement allows printing rdma device-specific state, if
> provided
> > > > > by the kernel. This is done in a generic manner, so rdma tool doesn't
> > > >
> > > > Double space between "." and "This".
> > > >
> > > > > need to know about the details of every type of rdma device.
> > > > >
> > > > > Driver attributes for a rdma resource are in the form of <key,
> > > > > [print_type], value> tuples, where the key is a string and the value can
> > > > > be any supported driver attribute. The print_type attribute, if
> present,
> > > >
> > > > ditto
> > >
> > > I'll fix these.
> >
> > Fix it if you want, but don't do it because Leon told you to. A double
> > space after period is perfectly acceptable.
>
> It is very controversial thing [1],
>
> "Most style guides indicate that single sentence spacing is proper for
> final or published work today, and most publishers require manuscripts
> to be submitted as they will appear in publication—single
> sentence spaced."
>
> [1] https://en.wikipedia.org/wiki/Sentence_spacing
We're not writing a manuscript. 😉 Regardless, I made the changes and they are in v2 of the patch series, which I think is probably ready to merge.
Steve.
next prev parent reply other threads:[~2018-05-15 17:51 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-07 16:06 [PATCH v1 iproute2-next 0/3] RDMA tool driver-specific resource tracking Steve Wise
2018-05-07 15:53 ` [PATCH v1 iproute2-next 1/3] rdma: update rdma_netlink.h to get driver attrs Steve Wise
2018-05-13 13:15 ` Leon Romanovsky
2018-05-14 15:15 ` Steve Wise
2018-05-07 15:53 ` [PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes Steve Wise
2018-05-10 4:08 ` David Ahern
2018-05-10 14:19 ` Steve Wise
2018-05-10 14:20 ` David Ahern
2018-05-13 13:10 ` Leon Romanovsky
2018-05-13 13:24 ` Leon Romanovsky
2018-05-14 14:51 ` Steve Wise
2018-05-15 16:35 ` Doug Ledford
2018-05-15 16:59 ` Leon Romanovsky
2018-05-15 17:51 ` Steve Wise [this message]
2018-05-15 18:00 ` Doug Ledford
2018-05-14 20:41 ` Jason Gunthorpe
2018-05-14 22:04 ` Steve Wise
2018-05-15 8:54 ` Leon Romanovsky
2018-05-15 13:04 ` Steve Wise
2018-05-15 13:18 ` Steve Wise
2018-05-15 13:53 ` Jason Gunthorpe
2018-05-15 14:31 ` Steve Wise
2018-05-15 14:44 ` Jason Gunthorpe
2018-05-15 15:02 ` Steve Wise
2018-05-15 15:14 ` Jason Gunthorpe
2018-05-07 15:53 ` [PATCH v1 iproute2-next 3/3] rdma: update man pages Steve Wise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='01ee01d3ec75$52feb7b0$f8fc2710$@opengridcomputing.com' \
--to=swise@opengridcomputing.com \
--cc=dledford@redhat.com \
--cc=dsahern@gmail.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).