From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yonghong Song Subject: Re: [PATCH bpf-next v2 9/9] tools/bpf: add a test_progs test case for bpf_get_stack helper Date: Thu, 19 Apr 2018 16:42:44 -0700 Message-ID: <01f3c75a-d105-98ce-506d-286b573c7376@fb.com> References: <20180418165444.2263237-1-yhs@fb.com> <20180418165444.2263237-10-yhs@fb.com> <20180419043953.fcv33e2glomg33gp@ast-mbp> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Cc: , , , To: Alexei Starovoitov Return-path: Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:38696 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753649AbeDSXnO (ORCPT ); Thu, 19 Apr 2018 19:43:14 -0400 In-Reply-To: <20180419043953.fcv33e2glomg33gp@ast-mbp> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 4/18/18 9:39 PM, Alexei Starovoitov wrote: > On Wed, Apr 18, 2018 at 09:54:44AM -0700, Yonghong Song wrote: >> The test_stacktrace_map is enhanced to call bpf_get_stack >> in the helper to get the stack trace as well. >> The stack traces from bpf_get_stack and bpf_get_stackid >> are compared to ensure that for the same stack as >> represented as the same hash, their ip addresses >> must be the same. >> >> Signed-off-by: Yonghong Song > > could you please add a test for bpf_get_stack() with buildid as well? > I think patch 2 implementes it correctly, but would be good to have a test for it. Right. Will improve the test to cover buildid as well.