RE: [PATCH net-next v3 1/2] net: txgbe: Support to set UDP tunnel port

["Jiawen Wu" <jiawenwu@trustnetic.com>]

On Fri, Apr 18, 2025 10:20 AM, Jakub Kicinski wrote:
> On Fri, 18 Apr 2025 09:44:00 +0800 Jiawen Wu wrote:
> > On Fri, Apr 18, 2025 7:58 AM, Jakub Kicinski wrote:
> > > On Thu, 17 Apr 2025 16:03:27 +0800 Jiawen Wu wrote:
> > > > @@ -392,6 +393,8 @@ static int txgbe_open(struct net_device *netdev)
> > >                                  ^^^^^^^^^^
> > > >
> > > >  	txgbe_up_complete(wx);
> > > >
> > > > +	udp_tunnel_nic_reset_ntf(netdev);
> > >         ^^^^^^^^^^^^^^^^^^^^^^^^
> > > >  	return 0;
> > >
> > > > +	.flags		= UDP_TUNNEL_NIC_INFO_OPEN_ONLY,
> > >
> > > Documentation says:
> > >
> > >         /* Device only supports offloads when it's open, all ports
> > >          * will be removed before close and re-added after open.
> > >          */
> > >         UDP_TUNNEL_NIC_INFO_OPEN_ONLY   = BIT(1),
> > >
> > > Are you sure you have to explicitly reset?
> >
> > Yes. Stop device will reset hardware, which reset UDP port to the default value.
> > So it has to re-configure the ports.
> 
> My point is that this is basically what the
> UDP_TUNNEL_NIC_INFO_OPEN_ONLY flag already assumes.
> There should be no need to reset if you already told the core
> with the flag that the device forgets everything when closed.
> 
> Could you retest without the reset_ntf ?

Thanks for the guidance.
The test result looks the same as before, when I remove reset_ntf.
I'll fix it in patch v4. :)