From: "Leizhen (ThunderTown)" <thunder.leizhen@huaweicloud.com>
To: Simon Horman <horms@kernel.org>
Cc: Yisen Zhuang <yisen.zhuang@huawei.com>,
Salil Mehta <salil.mehta@huawei.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, Zhen Lei <thunder.leizhen@huawei.com>
Subject: Re: [PATCH] net: hns: Remove a redundant check in hns_mdio_probe()
Date: Sun, 6 Aug 2023 18:08:40 +0800 [thread overview]
Message-ID: <021855b4-972c-4df0-71c3-f1f415f9a881@huaweicloud.com> (raw)
In-Reply-To: <ZM4yrM11M86Qy3vd@vergenet.net>
On 2023/8/5 19:29, Simon Horman wrote:
> On Fri, Aug 04, 2023 at 05:27:53PM +0800, thunder.leizhen@huaweicloud.com wrote:
>> From: Zhen Lei <thunder.leizhen@huawei.com>
>>
>> Traverse all devices when a new driver is installed, or, traverse all
>> drivers when a new device is added. In any case, the input argument
>> 'pdev' of drv->probe() cannot be NULL.
>>
>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
>
> Please specify the target tree, net-next or net, for patches for this
> driver. In this case, as it isn't a bug fix, it would be net-next.
>
> Subject: [PATCH net-next] ...
Sorry, this is my first patch for the net module. Do it next time.
>
> That aside, this looks good to me.
Thanks.
>
> Reviewed-by: Simon Horman <horms@kernel.org>
> .
>
--
Regards,
Zhen Lei
prev parent reply other threads:[~2023-08-06 10:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 9:27 [PATCH] net: hns: Remove a redundant check in hns_mdio_probe() thunder.leizhen
2023-08-05 11:29 ` Simon Horman
2023-08-06 10:08 ` Leizhen (ThunderTown) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=021855b4-972c-4df0-71c3-f1f415f9a881@huaweicloud.com \
--to=thunder.leizhen@huaweicloud.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=salil.mehta@huawei.com \
--cc=thunder.leizhen@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).