From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 297AAC43381 for ; Thu, 21 Feb 2019 20:39:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E8F2520823 for ; Thu, 21 Feb 2019 20:39:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726172AbfBUUjx (ORCPT ); Thu, 21 Feb 2019 15:39:53 -0500 Received: from linode.aoot.com ([69.164.194.13]:44768 "EHLO linode.aoot.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725866AbfBUUjx (ORCPT ); Thu, 21 Feb 2019 15:39:53 -0500 Received: from stevoacer (47-221-167-84.gtwncmta03.res.dyn.suddenlink.net [47.221.167.84]) by linode.aoot.com (Postfix) with ESMTP id 998CB8285; Thu, 21 Feb 2019 14:39:52 -0600 (CST) From: "Steve Wise" To: "'Leon Romanovsky'" , "'David Ahern'" Cc: "'Leon Romanovsky'" , "'netdev'" , "'RDMA mailing list'" , "'Stephen Hemminger'" References: <20190220072136.3840-1-leon@kernel.org> <20190220072136.3840-20-leon@kernel.org> In-Reply-To: <20190220072136.3840-20-leon@kernel.org> Subject: RE: [PATCH iproute2-next v1 19/19] rdma: Provide and reuse filter functions Date: Thu, 21 Feb 2019 14:39:51 -0600 Message-ID: <021f01d4ca25$984115f0$c8c341d0$@opengridcomputing.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQIwsbsn9zZMWAmjbPSjGQqQiUt9PAJ5WfTkpR8cyVA= Content-Language: en-us Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > -----Original Message----- > From: linux-rdma-owner@vger.kernel.org owner@vger.kernel.org> On Behalf Of Leon Romanovsky > Sent: Wednesday, February 20, 2019 1:22 AM > To: David Ahern > Cc: Leon Romanovsky ; netdev > ; RDMA mailing list rdma@vger.kernel.org>; Stephen Hemminger > > Subject: [PATCH iproute2-next v1 19/19] rdma: Provide and reuse filter > functions > > From: Leon Romanovsky > > Globally replace all filter function in safer variants of those > is_filterred functions, which take into account the availability/lack "is_filterred" -> "is_filtered" > of netlink attributes. > > Such conversion allowed to fix a number of places in the code, where > the previous implementation didn't honor filter requests if netlink > attribute wasn't present. > > Signed-off-by: Leon Romanovsky > --- > rdma/rdma.h | 7 +++--- > rdma/res-cmid.c | 57 +++++++++++++++++++++++++++---------------------- > rdma/res-cq.c | 22 +++++++++++-------- > rdma/res-mr.c | 12 +++++++---- > rdma/res-pd.c | 12 +++++++---- > rdma/res-qp.c | 53 ++++++++++++++++++++++----------------------- > rdma/utils.c | 26 ++++++++++++++++++---- > 7 files changed, 112 insertions(+), 77 deletions(-) Reviewed-by: Steve Wise