From: "Steve Wise" <swise@opengridcomputing.com>
To: "'Varun Prakash'" <varun@chelsio.com>, <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <linux-rdma@vger.kernel.org>,
<target-devel@vger.kernel.org>, <nab@linux-iscsi.org>,
<dledford@redhat.com>, <gerlitz.or@gmail.com>,
<indranil@chelsio.com>
Subject: RE: [net-next PATCH 00/11] iw_cxgb4,cxgbit: remove duplicate code
Date: Tue, 13 Sep 2016 15:18:42 -0500 [thread overview]
Message-ID: <022b01d20dfc$05864150$1092c3f0$@opengridcomputing.com> (raw)
In-Reply-To: <cover.1473781521.git.varun@chelsio.com>
> This patch series removes duplicate code from
> iw_cxgb4 and cxgbit by adding common function
> definitions in libcxgb.
>
> Please review.
>
> Thanks
> Varun
>
> Varun Prakash (11):
> libcxgb,iw_cxgb4,cxgbit: add cxgb_get_4tuple()
> libcxgb,iw_cxgb4,cxgbit: add cxgb_find_route()
> libcxgb,iw_cxgb4,cxgbit: add cxgb_find_route6()
> libcxgb,iw_cxgb4,cxgbit: add cxgb_is_neg_adv()
> libcxgb,iw_cxgb4,cxgbit: add cxgb_best_mtu()
> libcxgb,iw_cxgb4,cxgbit: add cxgb_compute_wscale()
> libcxgb,iw_cxgb4,cxgbit: add cxgb_mk_tid_release()
> libcxgb,iw_cxgb4,cxgbit: add cxgb_mk_close_con_req()
> libcxgb,iw_cxgb4,cxgbit: add cxgb_mk_abort_req()
> libcxgb,iw_cxgb4,cxgbit: add cxgb_mk_abort_rpl()
> libcxgb,iw_cxgb4,cxgbit: add cxgb_mk_rx_data_ack()
>
> drivers/infiniband/hw/cxgb4/Kconfig | 1 +
> drivers/infiniband/hw/cxgb4/Makefile | 1 +
> drivers/infiniband/hw/cxgb4/cm.c | 288
++++++----------------
> drivers/infiniband/hw/cxgb4/iw_cxgb4.h | 9 -
> drivers/net/ethernet/chelsio/libcxgb/Makefile | 4 +-
> drivers/net/ethernet/chelsio/libcxgb/libcxgb_cm.c | 149 +++++++++++
> drivers/net/ethernet/chelsio/libcxgb/libcxgb_cm.h | 160 ++++++++++++
> drivers/target/iscsi/cxgbit/cxgbit_cm.c | 234 +++---------------
> 8 files changed, 428 insertions(+), 418 deletions(-)
> create mode 100644 drivers/net/ethernet/chelsio/libcxgb/libcxgb_cm.c
> create mode 100644 drivers/net/ethernet/chelsio/libcxgb/libcxgb_cm.h
>
This series looks good.
Reviewed-by: Steve Wise <swise@opengridcomputing.com>
Thanks Varun!
Steve
next prev parent reply other threads:[~2016-09-13 20:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-13 15:53 [net-next PATCH 00/11] iw_cxgb4,cxgbit: remove duplicate code Varun Prakash
2016-09-13 15:53 ` [net-next PATCH 01/11] libcxgb,iw_cxgb4,cxgbit: add cxgb_get_4tuple() Varun Prakash
2016-09-13 15:53 ` [net-next PATCH 03/11] libcxgb,iw_cxgb4,cxgbit: add cxgb_find_route6() Varun Prakash
2016-09-13 15:53 ` [net-next PATCH 04/11] libcxgb,iw_cxgb4,cxgbit: add cxgb_is_neg_adv() Varun Prakash
2016-09-13 15:54 ` [net-next PATCH 05/11] libcxgb,iw_cxgb4,cxgbit: add cxgb_best_mtu() Varun Prakash
2016-09-13 15:54 ` [net-next PATCH 06/11] libcxgb,iw_cxgb4,cxgbit: add cxgb_compute_wscale() Varun Prakash
[not found] ` <cover.1473781521.git.varun-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
2016-09-13 15:53 ` [net-next PATCH 02/11] libcxgb,iw_cxgb4,cxgbit: add cxgb_find_route() Varun Prakash
2016-09-13 15:54 ` [net-next PATCH 07/11] libcxgb,iw_cxgb4,cxgbit: add cxgb_mk_tid_release() Varun Prakash
2016-09-14 8:32 ` [net-next PATCH 00/11] iw_cxgb4,cxgbit: remove duplicate code Or Gerlitz
2016-09-15 15:16 ` Varun Prakash
2016-09-13 15:54 ` [net-next PATCH 08/11] libcxgb,iw_cxgb4,cxgbit: add cxgb_mk_close_con_req() Varun Prakash
2016-09-13 15:54 ` [net-next PATCH 09/11] libcxgb,iw_cxgb4,cxgbit: add cxgb_mk_abort_req() Varun Prakash
2016-09-13 15:54 ` [net-next PATCH 10/11] libcxgb,iw_cxgb4,cxgbit: add cxgb_mk_abort_rpl() Varun Prakash
2016-09-13 15:54 ` [net-next PATCH 11/11] libcxgb,iw_cxgb4,cxgbit: add cxgb_mk_rx_data_ack() Varun Prakash
2016-09-13 20:18 ` Steve Wise [this message]
2016-09-16 0:50 ` [net-next PATCH 00/11] iw_cxgb4,cxgbit: remove duplicate code David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='022b01d20dfc$05864150$1092c3f0$@opengridcomputing.com' \
--to=swise@opengridcomputing.com \
--cc=davem@davemloft.net \
--cc=dledford@redhat.com \
--cc=gerlitz.or@gmail.com \
--cc=indranil@chelsio.com \
--cc=linux-rdma@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=netdev@vger.kernel.org \
--cc=target-devel@vger.kernel.org \
--cc=varun@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).