From: Cosmin Ratiu <cratiu@nvidia.com>
To: "sd@queasysnail.net" <sd@queasysnail.net>
Cc: "andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
"davem@davemloft.net" <davem@davemloft.net>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>,
Dragos Tatulea <dtatulea@nvidia.com>,
"sdf@fomichev.me" <sdf@fomichev.me>,
"shuah@kernel.org" <shuah@kernel.org>,
"dw@davidwei.uk" <dw@davidwei.uk>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"horms@kernel.org" <horms@kernel.org>,
"edumazet@google.com" <edumazet@google.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net v7 0/4] macsec: Add support for VLAN filtering in offload mode
Date: Thu, 2 Apr 2026 11:52:47 +0000 [thread overview]
Message-ID: <023651d1fd91f99982d3c3253e4d685ecacf6351.camel@nvidia.com> (raw)
In-Reply-To: <ac5Wt4vWxHMTcsae@krikkit>
On Thu, 2026-04-02 at 13:44 +0200, Sabrina Dubroca wrote:
> 2026-04-02, 14:10:30 +0300, Cosmin Ratiu wrote:
> > This short series adds support for VLANs in MACsec devices when
> > offload
> > mode is enabled. This allows VLAN netdevs on top of MACsec netdevs
> > to
> > function, which accidentally used to be the case in the past, but
> > was
> > broken. This series adds back proper support.
> >
> > As part of this, the existing nsim-only MACsec offload tests were
> > translated to Python so they can run against real HW and new
> > traffic-based tests were added for VLAN filter propagation, since
> > there's currently no uAPI to check VLAN filters.
> >
> > ---
> >
> > V7:
> > - Added missing ethtool feature checks.
>
> Sorry that I couldn't get to your patches earlier (-EBUSY,
> progressing
> toward -ENOTRECOVERABLE), but please don't rush to repost while I was
> still going through what you had already posted.
>
Apologies, I thought you are done with the review and just wanted to
get this done with. I'll address your comments in v8...
Cosmin.
prev parent reply other threads:[~2026-04-02 11:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-02 11:10 [PATCH net v7 0/4] macsec: Add support for VLAN filtering in offload mode Cosmin Ratiu
2026-04-02 11:10 ` [PATCH net v7 1/4] selftests: Migrate nsim-only MACsec tests to Python Cosmin Ratiu
2026-04-02 11:10 ` [PATCH net v7 2/4] nsim: Add support for VLAN filters Cosmin Ratiu
2026-04-02 11:10 ` [PATCH net v7 3/4] selftests: Add MACsec VLAN propagation traffic test Cosmin Ratiu
2026-04-02 11:10 ` [PATCH net v7 4/4] macsec: Support VLAN-filtering lower devices Cosmin Ratiu
2026-04-02 11:44 ` [PATCH net v7 0/4] macsec: Add support for VLAN filtering in offload mode Sabrina Dubroca
2026-04-02 11:52 ` Cosmin Ratiu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=023651d1fd91f99982d3c3253e4d685ecacf6351.camel@nvidia.com \
--to=cratiu@nvidia.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dtatulea@nvidia.com \
--cc=dw@davidwei.uk \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sd@queasysnail.net \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox