From: Jason Wang <jasowang@redhat.com>
To: Eli Cohen <elic@nvidia.com>, mst@redhat.com
Cc: virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
lulu@redhat.com
Subject: Re: [PATCH 1/2] vdpa/mlx5: Avoid unnecessary query virtqueue
Date: Fri, 29 Jan 2021 11:48:19 +0800 [thread overview]
Message-ID: <024560f4-51bd-af11-a9aa-48682d4e7f5f@redhat.com> (raw)
In-Reply-To: <20210128134130.3051-2-elic@nvidia.com>
On 2021/1/28 下午9:41, Eli Cohen wrote:
> suspend_vq should only suspend the VQ on not save the current available
> index. This is done when a change of map occurs when the driver calls
> save_channel_info().
>
> Signed-off-by: Eli Cohen <elic@nvidia.com>
Acked-by: Jason Wang <jasowang@redhat.com>
> ---
> drivers/vdpa/mlx5/net/mlx5_vnet.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> index 88dde3455bfd..549ded074ff3 100644
> --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
> +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> @@ -1148,8 +1148,6 @@ static int setup_vq(struct mlx5_vdpa_net *ndev, struct mlx5_vdpa_virtqueue *mvq)
>
> static void suspend_vq(struct mlx5_vdpa_net *ndev, struct mlx5_vdpa_virtqueue *mvq)
> {
> - struct mlx5_virtq_attr attr;
> -
> if (!mvq->initialized)
> return;
>
> @@ -1158,12 +1156,6 @@ static void suspend_vq(struct mlx5_vdpa_net *ndev, struct mlx5_vdpa_virtqueue *m
>
> if (modify_virtqueue(ndev, mvq, MLX5_VIRTIO_NET_Q_OBJECT_STATE_SUSPEND))
> mlx5_vdpa_warn(&ndev->mvdev, "modify to suspend failed\n");
> -
> - if (query_virtqueue(ndev, mvq, &attr)) {
> - mlx5_vdpa_warn(&ndev->mvdev, "failed to query virtqueue\n");
> - return;
> - }
> - mvq->avail_idx = attr.available_index;
> }
>
> static void suspend_vqs(struct mlx5_vdpa_net *ndev)
next prev parent reply other threads:[~2021-01-29 3:50 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 13:41 [PATCH 0/2] Fix failure to hot add memory Eli Cohen
2021-01-28 13:41 ` [PATCH 1/2] vdpa/mlx5: Avoid unnecessary query virtqueue Eli Cohen
2021-01-29 3:48 ` Jason Wang [this message]
2021-02-01 18:51 ` Si-Wei Liu
2021-02-01 19:17 ` Si-Wei Liu
2021-02-02 3:12 ` Jason Wang
2021-02-02 4:15 ` Si-Wei Liu
2021-02-02 6:02 ` Jason Wang
2021-02-02 7:06 ` Eli Cohen
2021-02-02 8:38 ` Si-Wei Liu
2021-02-02 9:22 ` Eli Cohen
2021-02-02 17:54 ` Si-Wei Liu
2021-02-03 5:16 ` Jason Wang
2021-02-03 23:19 ` Si-Wei Liu
2021-02-04 2:57 ` Jason Wang
2021-02-04 6:53 ` Eli Cohen
2021-02-02 7:00 ` Eli Cohen
2021-02-02 14:06 ` Michael S. Tsirkin
2021-02-02 6:57 ` Eli Cohen
2021-01-28 13:41 ` [PATCH 2/2] vdpa/mlx5: Restore the hardware used index after change map Eli Cohen
2021-01-29 3:49 ` Jason Wang
2021-01-31 18:55 ` Eli Cohen
2021-02-01 3:36 ` Jason Wang
2021-02-01 5:52 ` Eli Cohen
2021-02-01 6:00 ` Jason Wang
2021-02-01 6:38 ` Eli Cohen
2021-02-01 7:23 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=024560f4-51bd-af11-a9aa-48682d4e7f5f@redhat.com \
--to=jasowang@redhat.com \
--cc=elic@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).