From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAE89C77B79 for ; Mon, 17 Apr 2023 03:17:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229948AbjDQDRf (ORCPT ); Sun, 16 Apr 2023 23:17:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42726 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229547AbjDQDRe (ORCPT ); Sun, 16 Apr 2023 23:17:34 -0400 Received: from smtpbguseast1.qq.com (smtpbguseast1.qq.com [54.204.34.129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E97B71FDA; Sun, 16 Apr 2023 20:17:30 -0700 (PDT) X-QQ-mid: Yeas43t1681701430t120t13849 Received: from 7082A6556EBF4E69829842272A565F7C (jiawenwu@trustnetic.com [183.129.236.74]) X-QQ-SSF: 00400000000000F0FL9000000000000 From: =?utf-8?b?Smlhd2VuIFd1?= X-BIZMAIL-ID: 17039639388339495222 To: "'Wolfram Sang'" , "'Jarkko Nikula'" Cc: , , , , References: <20230411092725.104992-1-jiawenwu@trustnetic.com> <20230411092725.104992-3-jiawenwu@trustnetic.com> <00cf01d96c58$8d3e9130$a7bbb390$@trustnetic.com> <09dc3146-a1c6-e1a3-c8bd-e9fe547f9b99@linux.intel.com> <01ec01d96ec0$f2e10670$d8a31350$@trustnetic.com> In-Reply-To: <01ec01d96ec0$f2e10670$d8a31350$@trustnetic.com> Subject: RE: [PATCH net-next v2 2/6] net: txgbe: Implement I2C bus master driver Date: Mon, 17 Apr 2023 11:17:07 +0800 Message-ID: <024701d970db$17335890$459a09b0$@trustnetic.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Content-Language: zh-cn Thread-Index: AQJXy8bYFbRwx/PFgpvJPX7PgyT97wJCMZrbAk6D9c4BtpNb5AI7nLSFAlh8gEOt2z+agA== X-QQ-SENDSIZE: 520 Feedback-ID: Yeas:trustnetic.com:qybglogicsvr:qybglogicsvr5 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Friday, April 14, 2023 7:05 PM, Jiawen Wu wrote: > On Friday, April 14, 2023 12:29 AM, Wolfram Sang wrote: > > > > > Implement I2C bus driver to send and receive I2C messages. > > > > > > > > > > This I2C license the IP of Synopsys Designware, but without interrupt > > > > > support on the hardware design. It seems that polling mode needs to be > > > > > added in Synopsys Designware I2C driver. But currently it can only be > > > > > driven by this I2C bus master driver. > > > > > > > > > > Signed-off-by: Jiawen Wu > > > > > --- > > > > > drivers/net/ethernet/wangxun/Kconfig | 1 + > > > > > .../net/ethernet/wangxun/txgbe/txgbe_phy.c | 153 > > > > > ++++++++++++++++++ > > > > > .../net/ethernet/wangxun/txgbe/txgbe_type.h | 23 +++ > > > > > 3 files changed, 177 insertions(+) > > > > > > > > Looks like your use case has similarities with the commit 17631e8ca2d3 > > > ("i2c: designware: Add driver support for AMD NAVI GPU"). > > > > Yes, can you please check if you can't use the current i2c designware > > driver? > > Hi Jarkko & Wolfram, > > I read the i2c designware driver code, and found that 'dev->ss_hcnt' can > only be obtained by i2c_dw_acpi_configure() or calculated by clock rate. > > I don't quite understand how to get the clock rate. I tried to add a software > node of clock with property ("clock-frequency", 100000) and referenced by > I2C node. But it didn't work. > > Can I deliver 'dev->ss_hcnt' via platform data? Or how should I fill in the > software node? > The above question is in the case of platform driver. Moreover, why 'dev->fs_hcnt' and 'dev->fs_lcont' must be set when I use the standard mode? Should it be set only if I2C_MAX_FAST_MODE_* ?