netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Jesse Huang" <jesse@icplus.com.tw>
To: "Jeff Garzik" <jgarzik@pobox.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
	<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
	<akpm@osdl.org>, "Francois Romieu" <romieu@fr.zoreil.com>
Subject: Re: [PATCH] Create IP100A Driver
Date: Thu, 3 Aug 2006 10:03:17 +0800	[thread overview]
Message-ID: <024c01c6b6a0$fcf783e0$4964a8c0@icplus.com.tw> (raw)
In-Reply-To: 44C9E369.7070703@pobox.com

Dear Jeff:

    I had discuss with our peoples. We decided to use sundance.c to support
IP100A. We will also update some bug fix to this driver.

Thanks for your suggestion.

Best Regards,
Jesse Huang

----- Original Message ----- 
From: "Jeff Garzik" <jgarzik@pobox.com>
To: "Jesse Huang" <jesse@icplus.com.tw>
Cc: "John W. Linville" <linville@tuxdriver.com>;
<linux-kernel@vger.kernel.org>; <netdev@vger.kernel.org>; <akpm@osdl.org>
Sent: Friday, July 28, 2006 6:14 PM
Subject: Re: [PATCH] Create IP100A Driver

Although it is occasionally OK to duplicate a driver, I do not see a
compelling case with ip100a.

The stronger case for a single codebase is won on the strengths of lower
long-term maintenance costs, increased strength of review, doesn't break
existing sundance driver uses, and re-use of existing testing benefits.

If you feel strongly about not showing "sundance" to your users, you can
always submit a one-line MODULE_ALIAS() change which permits users to
load "ip100a" (really sundance.c).  Using MODULE_ALIAS() seems quite
reasonable, given that IC Plus appears to be taking the lead in future
Sundance-like chip development.

So, please resubmit as changes to the existing sundance.c.  This is
better for the standard Linux kernel engineering process.

Thanks,

Jeff



      reply	other threads:[~2006-08-03  2:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-27 19:54 [PATCH] Create IP100A Driver Jesse Huang
2006-07-27  8:40 ` Andrey Panin
2006-07-27 11:53 ` Neil Horman
2006-07-27 12:54 ` John W. Linville
2006-07-27 13:06   ` Neil Horman
2006-07-28  2:28     ` Jesse Huang
2006-07-28  2:23   ` Jesse Huang
2006-07-28 10:14     ` Jeff Garzik
2006-08-03  2:03       ` Jesse Huang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='024c01c6b6a0$fcf783e0$4964a8c0@icplus.com.tw' \
    --to=jesse@icplus.com.tw \
    --cc=akpm@osdl.org \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=netdev@vger.kernel.org \
    --cc=romieu@fr.zoreil.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).