From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ka-Cheong Poon <ka-cheong.poon@oracle.com>
Subject: Re: [PATCH v4 net-next 2/3] rds: Enable RDS IPv6 support
Date: Tue, 24 Jul 2018 11:18:24 +0800
Message-ID: <0257db98-60d4-6bca-66b5-c0bd0f63d234@oracle.com>
References: <cover.1532318752.git.ka-cheong.poon@oracle.com>
 <cover.1532318752.git.ka-cheong.poon@oracle.com>
 <4dc7ee44840f6166cec8847aefc2bc51e072a7ac.1532318752.git.ka-cheong.poon@oracle.com>
 <20180723.111545.2052989865778508499.davem@davemloft.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, santosh.shilimkar@oracle.com,
        rds-devel@oss.oracle.com, sowmini.varadhan@oracle.com
To: David Miller <davem@davemloft.net>
Return-path: <netdev-owner@vger.kernel.org>
Received: from userp2120.oracle.com ([156.151.31.85]:57452 "EHLO
        userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725922AbeGXEWx (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 24 Jul 2018 00:22:53 -0400
In-Reply-To: <20180723.111545.2052989865778508499.davem@davemloft.net>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 07/24/2018 02:15 AM, David Miller wrote:
> From: Ka-Cheong Poon <ka-cheong.poon@oracle.com>
> Date: Mon, 23 Jul 2018 07:16:11 -0700
> 
>> @@ -163,15 +165,29 @@ int rds_tcp_accept_one(struct socket *sock)
>>   
>>   	inet = inet_sk(new_sock->sk);
>>   
>> +	my_addr = &new_sock->sk->sk_v6_rcv_saddr;
>> +	peer_addr = &new_sock->sk->sk_v6_daddr,
>>   	rdsdebug("accepted tcp %pI6c:%u -> %pI6c:%u\n",
> 
> Note that comma, instead of a semicolon, at the end of the peer_addr
> assignment.
> 
> This doesn't even compile.


Strange, the compiler did not complain.  Will check why's
that.

Thanks.


-- 
K. Poon
ka-cheong.poon@oracle.com