From: "chaithrika" <chaithrika@ti.com>
To: "'David Miller'" <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>,
<davinci-linux-open-source@linux.davincidsp.com>,
<nsekhar@ti.com>, <anantgole@ti.com>,
<khilman@deeprootsystems.com>
Subject: RE: [PATCH net-next-2.6] TI DaVinci EMAC driver
Date: Mon, 11 May 2009 09:52:00 +0530 [thread overview]
Message-ID: <026301c9d1f0$07aa5750$16ff05f0$@com> (raw)
In-Reply-To: <20090509.131638.112506027.davem@davemloft.net>
> -----Original Message-----
> From: David Miller [mailto:davem@davemloft.net]
> Sent: Sunday, May 10, 2009 1:47 AM
> To: chaithrika@ti.com
> Cc: netdev@vger.kernel.org; davinci-linux-open-
> source@linux.davincidsp.com; nsekhar@ti.com; anantgole@ti.com;
> khilman@deeprootsystems.com
> Subject: Re: [PATCH net-next-2.6] TI DaVinci EMAC driver
>
> From: Chaithrika U S <chaithrika@ti.com>
> Date: Fri, 8 May 2009 09:34:22 -0400
>
> > diff --git a/drivers/net/Makefile b/drivers/net/Makefile
> > index dcd5f15..34f1253 100644
> > --- a/drivers/net/Makefile
> > +++ b/drivers/net/Makefile
> > @@ -2,6 +2,9 @@
> > # Makefile for the Linux network (ethercard) device drivers.
> > #
> >
> > +davinci_emac_driver-objs := davinci_emac.o
> > +obj-$(CONFIG_TI_DAVINCI_EMAC) += davinci_emac_driver.o
> > +
> > obj-$(CONFIG_E1000) += e1000/
> > obj-$(CONFIG_E1000E) += e1000e/
> > obj-$(CONFIG_IBM_NEW_EMAC) += ibm_newemac/
>
> If there is only one source file, this complicated construct
> is overkill. Simply do something like:
>
> obj-$(CONFIG_TI_DAVINCI_EMAC) += davinci_emac.o
OK. Will change the makefile entry.
Regards,
Chaithrika
prev parent reply other threads:[~2009-05-11 4:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-08 13:34 [PATCH net-next-2.6] TI DaVinci EMAC driver Chaithrika U S
2009-05-09 20:16 ` David Miller
2009-05-11 4:22 ` chaithrika [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='026301c9d1f0$07aa5750$16ff05f0$@com' \
--to=chaithrika@ti.com \
--cc=anantgole@ti.com \
--cc=davem@davemloft.net \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=khilman@deeprootsystems.com \
--cc=netdev@vger.kernel.org \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).