From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84F99C43387 for ; Thu, 17 Jan 2019 19:12:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 45A5620868 for ; Thu, 17 Jan 2019 19:12:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="t5hCvRBc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727327AbfAQTM3 (ORCPT ); Thu, 17 Jan 2019 14:12:29 -0500 Received: from mail-pg1-f194.google.com ([209.85.215.194]:39022 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725878AbfAQTM2 (ORCPT ); Thu, 17 Jan 2019 14:12:28 -0500 Received: by mail-pg1-f194.google.com with SMTP id w6so4849643pgl.6 for ; Thu, 17 Jan 2019 11:12:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Yn98y9jl9cn2gNqup0E2ZaKbF6OuxMH5ODEemNGHJ0U=; b=t5hCvRBcd0EKxFm+oQt4U/HK3BODFprFWmCJN4G/TxAK5gg0BVWsO7cWPFM85k4OFu uLgHoli2epEmKYIvhM/CwxbokAEVxMaytSepoqW52gSV2hBQrW+nGroV3r/45WhGjhrp IK035Qku6oVV80HqWJ5n6glYek+0NIL+Sf3sPnQbjbI7B/67d1HS5a25gqAbMTHsdIPY 8WfjTPWSr3ieUHlDyFvsZkE24jvK2aeRvn58lC5tQYoMphJI2t1KP257vhXKEH7wmwe6 Ur6X+Ykaxeohfc0yA/6J7/5U4njnWOZdbPdl4brFixoGJ8qxs8Ofhi8M9DeCB04GVwR4 RQyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=Yn98y9jl9cn2gNqup0E2ZaKbF6OuxMH5ODEemNGHJ0U=; b=mINH3kY/2kSH5O5OP2BcOLQbwAvwJtfBqfUesyGNp6QmY11pbPmRRWG0Ql5oSOmywQ L5jKbyGeLRk1fhYe4VkOsMXrNLQntZdLjfjrn2vfRFGGIHpnTX81CfX+EtYxjNhN23MT I1VKbOQxMM2OS/k96gYtT09Lbl1ItM3hp+ip9Nrim6tX0ywWrkILo2HStKIk21nLLmad YgI+ku7DQOsnFr1GeUgXXasxtHlaPy6VIapEW18ejGQv2DAAA20YEbMuX5hvZiRWO/F3 pKb/xDtVKVNkFJ+Ww7ftGjYLWbgfaZc7tdnUoEWQ8KkPrgukyq8j5jld46IJ5LVfw9mK 5Tjg== X-Gm-Message-State: AJcUukdyK8xLJaNZE7yJ6WFfFCH+aHezlbMiKsz0oCHiLt5+E99g7m8D j7tezSyBQab1qMlKTo9F52k= X-Google-Smtp-Source: ALg8bN4zvdS/XFwcr/Mesh8cv/MgeqaQR1fdTzA2LGEFOH8tCYErmlI21sDTbHiATtbWT0JmhS99lQ== X-Received: by 2002:a65:434d:: with SMTP id k13mr14710784pgq.269.1547752347299; Thu, 17 Jan 2019 11:12:27 -0800 (PST) Received: from [10.67.49.9] ([192.19.223.250]) by smtp.googlemail.com with ESMTPSA id u186sm3643350pfu.51.2019.01.17.11.12.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 17 Jan 2019 11:12:26 -0800 (PST) Subject: Re: [PATCH net-next 10/14] net: vlan: Propagate MC addresses with VID through switchdev To: Ido Schimmel Cc: "netdev@vger.kernel.org" , "andrew@lunn.ch" , "vivien.didelot@gmail.com" , "davem@davemloft.net" , Jiri Pirko , "ilias.apalodimas@linaro.org" , "ivan.khoronzhuk@linaro.org" , "roopa@cumulusnetworks.com" , "nikolay@cumulusnetworks.com" References: <20190116200102.2749-1-f.fainelli@gmail.com> <20190116200102.2749-11-f.fainelli@gmail.com> <20190117144941.GA24079@splinter> From: Florian Fainelli Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9Za0Dx0yyp44iD1OvHtkEI M5kY0ACeNhCZJvZ5g4C2Lc9fcTHu8jxmEkI= Message-ID: <026a9003-63cd-ab28-5e43-819f6fa5c1f8@gmail.com> Date: Thu, 17 Jan 2019 11:12:24 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20190117144941.GA24079@splinter> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 1/17/19 6:49 AM, Ido Schimmel wrote: > On Wed, Jan 16, 2019 at 12:00:58PM -0800, Florian Fainelli wrote: >> The VLAN real device could be an Ethernet switch port and that switch >> might have VLAN filtering globally enabled (because of a bridge >> requesting VLAN filtering on the switch on another port) and so when >> programming multicast addresses, we need the multicast filter >> programming to be aware of the correct VLAN ID as well. > > This looks like a quirk of a specific device. How bad is it to patch the > driver to add a multicast address for every configured VLAN? There is at least another driver that can be benefit from that which is cpsw, if I understand Ivan's use case correctly. If there is a ndo_set_rx_mode() function implemented by the virtual device, and that does call dev_{mc,uc}_sync(master, dev), then this means that you do want to be able to filter UC and MC addresses. If we added the entire class D range of multicast addresses to the switch's MDB, that would not be filtering, we would be passing up everything to the stack and let it filter in software because there is no multicast socket listening on that address. > > Also, I think it's weird that we have one API to program address and a > completely different API (via switchdev) to program address+VID pairs. > Extending current API might make more sense. > Do you mean ndo_set_rx_mode() and dev_mc_sync()? That is what Ivan proposed doing not so long ago here: https://www.spinics.net/lists/netdev/msg537424.html but that is IMHO wasting storage space, because the kernel is maintaining the address lists, and now also needs to gain knowledge about the VID. With up to 4K - 2 VLAN interfaces per switch port, this bloats the memory footprint, we arguably still need to maintain those address lists anyway... The reason why I chose switchdev here is because: - this is mostly relevant for switch devices, not so much for NICs (it seems), if it was, they would have solved the problem by now - this allows to have an unified path from the switch driver perspective to program MDB addresses targeting the CPU/management port, no need to have X different ways of doing the same operation -- Florian