From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Keller, Jacob E" Subject: RE: [RFC PATCH 0/4] More accurate PHC<->system clock synchronization Date: Fri, 26 Oct 2018 16:51:25 +0000 Message-ID: <02874ECE860811409154E81DA85FBB5884CE4B79@ORSMSX115.amr.corp.intel.com> References: <20181026162742.631-1-mlichvar@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Cc: "intel-wired-lan@lists.osuosl.org" , Richard Cochran To: Miroslav Lichvar , "netdev@vger.kernel.org" Return-path: Received: from mga03.intel.com ([134.134.136.65]:36381 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726159AbeJ0B3T (ORCPT ); Fri, 26 Oct 2018 21:29:19 -0400 In-Reply-To: <20181026162742.631-1-mlichvar@redhat.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: > -----Original Message----- > From: Miroslav Lichvar [mailto:mlichvar@redhat.com] > Sent: Friday, October 26, 2018 9:28 AM > To: netdev@vger.kernel.org > Cc: intel-wired-lan@lists.osuosl.org; Richard Cochran ; > Keller, Jacob E ; Miroslav Lichvar > Subject: [RFC PATCH 0/4] More accurate PHC<->system clock synchronization > I read the whole series, and it looks good to me. Acked-by: Jacob Keller > There is some duplication of code in the igb and ixgbe drivers, which I > don't like very much, but I thought it's better than extending and > wrapping the existing functions like in the e1000e driver. Also, mixing > SYSTIM and "system time" in the code will probably be confusing. > > I wasn't able to find a better name for the ioctl, the structures, and > the driver function. If anyone has suggestions, please let me know. > Hmm.. Yea, I don't really have better names either. > Miroslav Lichvar (4): > ptp: add PTP_SYS_OFFSET_EXTENDED ioctl > e1000e: add support for extended PHC gettime > igb: add support for extended PHC gettime > ixgbe: add support for extended PHC gettime > > drivers/net/ethernet/intel/e1000e/e1000.h | 3 ++ > drivers/net/ethernet/intel/e1000e/netdev.c | 48 +++++++++++++---- > drivers/net/ethernet/intel/e1000e/ptp.c | 21 ++++++++ > drivers/net/ethernet/intel/igb/igb_ptp.c | 43 +++++++++++++++ > drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c | 57 ++++++++++++++++++++ > drivers/ptp/ptp_chardev.c | 39 ++++++++++++++ > include/linux/ptp_clock_kernel.h | 26 +++++++++ > include/uapi/linux/ptp_clock.h | 12 +++++ > 8 files changed, 239 insertions(+), 10 deletions(-) > > -- > 2.17.2