netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Jiawen Wu" <jiawenwu@trustnetic.com>
To: "'Andrew Lunn'" <andrew@lunn.ch>
Cc: <netdev@vger.kernel.org>, <davem@davemloft.net>,
	<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
	<linux@armlinux.org.uk>, <horms@kernel.org>,
	<mengyuanlou@net-swift.com>
Subject: RE: [PATCH net-next 2/5] net: wangxun: add ethtool_ops for ring parameters
Date: Thu, 30 Nov 2023 11:32:22 +0800	[thread overview]
Message-ID: <029601da233d$d4b8a9a0$7e29fce0$@trustnetic.com> (raw)
In-Reply-To: <4a36b46d-3f71-430f-8158-da58769ae52a@lunn.ch>

> > +int wx_set_ring(struct wx *wx, u32 new_tx_count, u32 new_rx_count)
> > +{
> > +	struct wx_ring *temp_ring;
> > +	int i, err = 0;
> > +
> > +	/* allocate temporary buffer to store rings in */
> > +	i = max_t(int, wx->num_tx_queues, wx->num_rx_queues);
> > +	temp_ring = vmalloc(i * sizeof(struct wx_ring));
> 
> So it is O.K. for the pages to be scattered around the physical
> address space, not contiguous. Does this memory ever get passed to the
> hardware?

No, this memory is only used to temporarily store ring info. It will be freed after
restoring the ring info.


  parent reply	other threads:[~2023-11-30  3:34 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-22 10:22 [PATCH net-next 0/5] Implement more ethtool_ops for Wangxun Jiawen Wu
2023-11-22 10:22 ` [PATCH net-next 1/5] net: wangxun: add flow control support Jiawen Wu
2023-11-22 16:15   ` Andrew Lunn
2023-11-22 16:30     ` Russell King (Oracle)
2023-11-22 17:24       ` Andrew Lunn
2023-11-22 17:26         ` Russell King (Oracle)
2023-11-23  9:20     ` Jiawen Wu
2023-11-22 10:22 ` [PATCH net-next 2/5] net: wangxun: add ethtool_ops for ring parameters Jiawen Wu
2023-11-22 16:24   ` Andrew Lunn
2023-11-23  9:25     ` Jiawen Wu
2023-11-23 15:14       ` Andrew Lunn
2023-11-30  3:32     ` Jiawen Wu [this message]
2023-11-22 10:22 ` [PATCH net-next 3/5] net: wangxun: add coalesce options support Jiawen Wu
2023-11-22 10:22 ` [PATCH net-next 4/5] net: wangxun: add ethtool_ops for channel number Jiawen Wu
2023-11-22 16:35   ` Andrew Lunn
2023-11-22 10:22 ` [PATCH net-next 5/5] net: wangxun: add ethtool_ops for msglevel Jiawen Wu
2023-11-22 16:36   ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='029601da233d$d4b8a9a0$7e29fce0$@trustnetic.com' \
    --to=jiawenwu@trustnetic.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mengyuanlou@net-swift.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).