From: Daniele Venzano <webvenza@libero.it>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: netdev@oss.sgi.com
Subject: Re: [PATCH 1/1] More ethtool support for sis900
Date: Sat, 5 Mar 2005 21:53:37 +0100 [thread overview]
Message-ID: <02a49476862ae18433e5b80aafa616fd@libero.it> (raw)
In-Reply-To: <4229FA32.4000401@pobox.com>
On 05/mar/05, at 19:28, Jeff Garzik wrote:
>> +static int sis900_set_settings(struct net_device *net_dev,
>> + struct ethtool_cmd *cmd)
>> +{
>> + struct sis900_private *sis_priv = net_dev->priv;
>> + return mii_ethtool_sset(&sis_priv->mii_info, cmd);
>> +}
>> +
>> +static int sis900_nway_reset(struct net_device *net_dev)
>> +{
>> + struct sis900_private *sis_priv = net_dev->priv;
>> + return mii_nway_restart(&sis_priv->mii_info);
>> +}
>
> I should think you want locking for these, as is present in other
> drivers...
I saw the locking, but I couldn't come up with a reason for it. Is it
needed because of kernel wide preemption ?
I don't like copying blindly and the documentation for the mii
interface is a bit lacking...
Will follow up with a new patch in a few minutes...
--
Daniele Venzano
http://www.brownhat.org
next prev parent reply other threads:[~2005-03-05 20:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-05 13:40 [PATCH 1/1] More ethtool support for sis900 Daniele Venzano
2005-03-05 18:28 ` Jeff Garzik
2005-03-05 20:53 ` Daniele Venzano [this message]
2005-03-06 0:15 ` Francois Romieu
2005-03-06 10:03 ` Daniele Venzano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02a49476862ae18433e5b80aafa616fd@libero.it \
--to=webvenza@libero.it \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).