From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCC3C2DCBF7 for ; Fri, 7 Nov 2025 13:27:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762522028; cv=none; b=rMw3lS3QjatGBgKdbUNvAMu0eNUycJSmmWdlK3iGlcniTJ4mkn859pbKsmdeGMaccGY5TrTxmmj5gC+wifLtlrAHcnsWjLJpq/fKHz1Vl2jAOpoamMR79t9VxyWRvvbnn//q99lXgOET8EKonaMJNDIkmS80C5+EasFnJfIZACQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762522028; c=relaxed/simple; bh=ggiLc3LlQ7lbR3z3zNcYhEBwmCAkHGIafHeVgYQPRTs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ntkEgjFRFLzIA956c3sdIkYitRv1ZzO645XJ6jbgXWMf/Noq29otmPHXZs5hx7LmJSy5EFydni4EfISjRTVVpFu0r8uqtdmTtKO6RUu+MvAZ6E9H1aXnBIyyrcDnSZKmo9vCLbws0U8l1BQKLigubo0X210eFo7ziroicL6AuwA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=RuRWa6r0; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="RuRWa6r0" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=0TlTDYtiaJ9miWBMsHG0UIX4wj2i6JSLkx+62UAG9Os=; b=RuRWa6r0yM+xgROPsTVfxzptWL q4VL6pg+040m145rQBtJjONpAUV0GjxW09thiJaxYTN/Tonj2FQA1LeoLSh1nAHzFjoqiCXeR6md0 x8LkSHQOMO9xFgDeJt3k9WB4CoKER40H2zSca2HN8DxAPZdi7xjlBBn2Lij4sh1D4W2Y=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1vHMUa-00DEFs-Au; Fri, 07 Nov 2025 14:27:04 +0100 Date: Fri, 7 Nov 2025 14:27:04 +0100 From: Andrew Lunn To: Vladimir Oltean Cc: netdev@vger.kernel.org, Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Marek Vasut , Wei Fang , Clark Wang Subject: Re: [PATCH v2 net-next 1/6] net: phy: realtek: create rtl8211f_config_rgmii_delay() Message-ID: <02ad7418-7043-4968-b34a-6fa9142e85ea@lunn.ch> References: <20251107110817.324389-1-vladimir.oltean@nxp.com> <20251107110817.324389-2-vladimir.oltean@nxp.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251107110817.324389-2-vladimir.oltean@nxp.com> On Fri, Nov 07, 2025 at 01:08:12PM +0200, Vladimir Oltean wrote: > The control flow in rtl8211f_config_init() has some pitfalls which were > probably unintended. Specifically it has an early return: > > switch (phydev->interface) { > ... > default: /* the rest of the modes imply leaving delay as is. */ > return 0; > } > > which exits the entire config_init() function. This means it also skips > doing things such as disabling CLKOUT or disabling PHY-mode EEE. > > For the RTL8211FS, which uses PHY_INTERFACE_MODE_SGMII, this might be a > problem. However, I don't know that it is, so there is no Fixes: tag. > The issue was observed through code inspection. > > Signed-off-by: Vladimir Oltean Pulling this out into a helper makes sense. Reviewed-by: Andrew Lunn Andrew