From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yonghong Song Subject: Re: [PATCH bpf-next v2 13/13] tools/bpf: bpftool: add support for jited func types Date: Wed, 17 Oct 2018 17:28:30 +0000 Message-ID: <02b9227e-81a2-54fe-9832-dadb30520004@fb.com> References: <20181017072400.2768484-1-yhs@fb.com> <20181017072400.2768484-4-yhs@fb.com> <0b60d21b-dcbf-a0df-7b2c-b0506463af1f@solarflare.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: Kernel Team To: Edward Cree , Alexei Starovoitov , Martin Lau , "daniel@iogearbox.net" , "netdev@vger.kernel.org" Return-path: Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:44034 "EHLO mx0b-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727013AbeJRB0R (ORCPT ); Wed, 17 Oct 2018 21:26:17 -0400 In-Reply-To: <0b60d21b-dcbf-a0df-7b2c-b0506463af1f@solarflare.com> Content-Language: en-US Content-ID: <5F703A5085B2C74196985E0F44964B5B@namprd15.prod.outlook.com> Sender: netdev-owner@vger.kernel.org List-ID: DQoNCk9uIDEwLzE3LzE4IDQ6MTEgQU0sIEVkd2FyZCBDcmVlIHdyb3RlOg0KPiBPbiAxNy8xMC8x OCAwODoyNCwgWW9uZ2hvbmcgU29uZyB3cm90ZToNCj4+IFRoaXMgcGF0Y2ggYWRkZWQgc3VwcG9y dCB0byBwcmludCBmdW5jdGlvbiBzaWduYXR1cmUNCj4+IGlmIGJ0ZiBmdW5jX2luZm8gaXMgYXZh aWxhYmxlLiBOb3RlIHRoYXQga3N5bQ0KPj4gbm93IHVzZXMgZnVuY3Rpb24gbmFtZSBpbnN0ZWFk IG9mIHByb2dfbmFtZSBhcw0KPj4gcHJvZ19uYW1lIGhhcyBhIGxpbWl0IG9mIDE2IGJ5dGVzIGlu Y2x1ZGluZw0KPj4gZW5kaW5nICdcMCcuDQo+Pg0KPj4gVGhlIGZvbGxvd2luZyBpcyBhIHNhbXBs ZSBvdXRwdXQgZm9yIHNlbGZ0ZXN0cw0KPj4gdGVzdF9idGYgd2l0aCBmaWxlIHRlc3RfYnRmX2hh c2t2Lm86DQo+Pg0KPj4gICAgJCBicGZ0b29sIHByb2cgZHVtcCBqaXRlZCBpZCAxDQo+PiAgICBp bnQgX2R1bW15X3RyYWNlcG9pbnQoc3RydWN0IGR1bW15X3RyYWNlcG9pbnRfYXJncyAqICk6DQo+ PiAgICBicGZfcHJvZ19iMDdjY2I4OTI2N2NmMjQyX19kdW1teV90cmFjZXBvaW50Og0KPj4gICAg ICAgMDogICBwdXNoICAgJXJicA0KPj4gICAgICAgMTogICBtb3YgICAgJXJzcCwlcmJwDQo+PiAg ICAgIC4uLi4uLg0KPj4gICAgICAzYzogICBhZGQgICAgJDB4MjgsJXJicA0KPj4gICAgICA0MDog ICBsZWF2ZXENCj4+ICAgICAgNDE6ICAgcmV0cQ0KPj4NCj4+ICAgIGludCB0ZXN0X2xvbmdfZm5h bWVfMShzdHJ1Y3QgZHVtbXlfdHJhY2Vwb2ludF9hcmdzICogKToNCj4+ICAgIGJwZl9wcm9nXzJk Y2VjYzE4MDcyNjIzZmNfdGVzdF9sb25nX2ZuYW1lXzE6DQo+PiAgICAgICAwOiAgIHB1c2ggICAl cmJwDQo+PiAgICAgICAxOiAgIG1vdiAgICAlcnNwLCVyYnANCj4+ICAgICAgLi4uLi4uDQo+PiAg ICAgIDNhOiAgIGFkZCAgICAkMHgyOCwlcmJwDQo+PiAgICAgIDNlOiAgIGxlYXZlcQ0KPj4gICAg ICAzZjogICByZXRxDQo+Pg0KPj4gICAgaW50IHRlc3RfbG9uZ19mbmFtZV8yKHN0cnVjdCBkdW1t eV90cmFjZXBvaW50X2FyZ3MgKiApOg0KPj4gICAgYnBmX3Byb2dfODlkNjRlNGFiZjBmMDEyNl90 ZXN0X2xvbmdfZm5hbWVfMjoNCj4+ICAgICAgIDA6ICAgcHVzaCAgICVyYnANCj4+ICAgICAgIDE6 ICAgbW92ICAgICVyc3AsJXJicA0KPj4gICAgICAuLi4uLi4NCj4+ICAgICAgODA6ICAgYWRkICAg ICQweDI4LCVyYnANCj4+ICAgICAgODQ6ICAgbGVhdmVxDQo+PiAgICAgIDg1OiAgIHJldHENCj4+ DQo+PiBTaWduZWQtb2ZmLWJ5OiBZb25naG9uZyBTb25nIDx5aHNAZmIuY29tPg0KPj4gLS0tDQo+ PiAgIHRvb2xzL2JwZi9icGZ0b29sL2J0Zl9kdW1wZXIuYyB8IDk2ICsrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysNCj4+ICAgdG9vbHMvYnBmL2JwZnRvb2wvbWFpbi5oICAgICAgIHwg IDIgKw0KPj4gICB0b29scy9icGYvYnBmdG9vbC9wcm9nLmMgICAgICAgfCA1NCArKysrKysrKysr KysrKysrKysrDQo+PiAgIDMgZmlsZXMgY2hhbmdlZCwgMTUyIGluc2VydGlvbnMoKykNCj4+DQo+ PiBkaWZmIC0tZ2l0IGEvdG9vbHMvYnBmL2JwZnRvb2wvYnRmX2R1bXBlci5jIGIvdG9vbHMvYnBm L2JwZnRvb2wvYnRmX2R1bXBlci5jDQo+PiBpbmRleCA1NWJjNTEyYTE4MzEuLmEzMWRmNDIwMjMz NSAxMDA2NDQNCj4+IC0tLSBhL3Rvb2xzL2JwZi9icGZ0b29sL2J0Zl9kdW1wZXIuYw0KPj4gKysr IGIvdG9vbHMvYnBmL2JwZnRvb2wvYnRmX2R1bXBlci5jDQo+PiBAQCAtMjQ5LDMgKzI0OSw5OSBA QCBpbnQgYnRmX2R1bXBlcl90eXBlKGNvbnN0IHN0cnVjdCBidGZfZHVtcGVyICpkLCBfX3UzMiB0 eXBlX2lkLA0KPj4gICB7DQo+PiAgIAlyZXR1cm4gYnRmX2R1bXBlcl9kb190eXBlKGQsIHR5cGVf aWQsIDAsIGRhdGEpOw0KPj4gICB9DQo+PiArDQo+PiArI2RlZmluZSBCVEZfUFJJTlRfU1RSSU5H KHN0cikJCQkJCQlcDQo+PiArCXsJCQkJCQkJCVwNCj4+ICsJCXBvcyArPSBzbnByaW50ZihmdW5j X3NpZyArIHBvcywgc2l6ZSAtIHBvcywgc3RyKTsJXA0KPj4gKwkJaWYgKHBvcyA+PSBzaXplKQkJ CQkJXA0KPj4gKwkJCXJldHVybiAtMTsJCQkJCVwNCj4+ICsJfQ0KPiBVc3VhbCBrZXJuZWwgcHJh Y3RpY2UgZm9yIHRoaXMgc29ydCBvZiBtYWNybyBpcyB0byB1c2UNCj4gIMKgwqDCoCBkbyB7IFwN Cj4gIMKgwqDCoCB9IHdoaWxlKDApDQo+ICDCoHRvIGVuc3VyZSBjb3JyZWN0IGJlaGF2aW91ciBp ZiB0aGUgbWFjcm8gaXMgdXNlZCB3aXRoaW4gYW5vdGhlciBjb250cm9sDQo+ICDCoGZsb3cgc3Rh dGVtZW50LCBlLmcuDQo+ICDCoMKgwqAgaWYgKHgpDQo+ICDCoMKgwqDCoMKgwqDCoCBCVEZfUFJJ TlRfU1RSSU5HKHgpOw0KPiAgwqDCoMKgIGVsc2UNCj4gIMKgwqDCoMKgwqDCoMKgIGRvX3NvbWV0 aGluZ19lbHNlKCk7DQo+ICDCoHdpbGwgbm90IGNvbXBpbGUgd2l0aCB0aGUgYmFyZSBicmFjZXMg YXMgdGhlIGVsc2Ugd2lsbCBiZSBkZXRhY2hlZC4NCg0KVGhhbmtzIGZvciB0aGUgcmV2aWV3ISBX aWxsIGNoYW5nZSB0byB1c2UgdGhlICJkbyB3aGlsZSIgZm9ybWF0DQphcyB5b3Ugc3VnZ2VzdGVk Lg0KDQo+PiArI2RlZmluZSBCVEZfUFJJTlRfT05FX0FSRyhmbXQsIGFyZykJCQkJCVwNCj4+ICsJ ewkJCQkJCQkJXA0KPj4gKwkJcG9zICs9IHNucHJpbnRmKGZ1bmNfc2lnICsgcG9zLCBzaXplIC0g cG9zLCBmbXQsIGFyZyk7CVwNCj4+ICsJCWlmIChwb3MgPj0gc2l6ZSkJCQkJCVwNCj4+ICsJCQly ZXR1cm4gLTE7CQkJCQlcDQo+PiArCX0NCj4gQW55IHJlYXNvbiBmb3Igbm90IGp1c3QgdXNpbmcg YSB2YXJpYWRpYyBtYWNybz8NCg0KTm8gcGFydGljdWxhciByZWFzb24uIEkgd2lsbCB0cnkgdG8g dXNlIGl0IGluIHRoZSBuZXh0IHJldmlzaW9uLg0KDQo+PiArI2RlZmluZSBCVEZfUFJJTlRfVFlQ RV9PTkxZKHR5cGUpCQkJCQlcDQo+PiArCXsJCQkJCQkJCVwNCj4+ICsJCXBvcyA9IF9fYnRmX2R1 bXBlcl90eXBlX29ubHkoYnRmLCB0eXBlLCBmdW5jX3NpZywJXA0KPj4gKwkJCQkJICAgICBwb3Ms IHNpemUpOwkJXA0KPj4gKwkJaWYgKHBvcyA9PSAtMSkJCQkJCQlcDQo+PiArCQkJcmV0dXJuIC0x OwkJCQkJXA0KPj4gKwl9DQo+PiArDQo+PiArc3RhdGljIGludCBfX2J0Zl9kdW1wZXJfdHlwZV9v bmx5KHN0cnVjdCBidGYgKmJ0ZiwgX191MzIgdHlwZV9pZCwNCj4+ICsJCQkJICBjaGFyICpmdW5j X3NpZywgaW50IHBvcywgaW50IHNpemUpDQo+PiArew0KPj4gKwljb25zdCBzdHJ1Y3QgYnRmX3R5 cGUgKnQgPSBidGZfX3R5cGVfYnlfaWQoYnRmLCB0eXBlX2lkKTsNCj4+ICsJY29uc3Qgc3RydWN0 IGJ0Zl9hcnJheSAqYXJyYXk7DQo+PiArCWludCBpLCB2bGVuOw0KPj4gKw0KPj4gKwlzd2l0Y2gg KEJURl9JTkZPX0tJTkQodC0+aW5mbykpIHsNCj4+ICsJY2FzZSBCVEZfS0lORF9JTlQ6DQo+PiAr CQlCVEZfUFJJTlRfT05FX0FSRygiJXMgIiwNCj4+ICsJCQkJICBidGZfX25hbWVfYnlfb2Zmc2V0 KGJ0ZiwgdC0+bmFtZV9vZmYpKTsNCj4+ICsJCWJyZWFrOw0KPj4gKwljYXNlIEJURl9LSU5EX1NU UlVDVDoNCj4+ICsJCUJURl9QUklOVF9PTkVfQVJHKCJzdHJ1Y3QgJXMgIiwNCj4+ICsJCQkJICBi dGZfX25hbWVfYnlfb2Zmc2V0KGJ0ZiwgdC0+bmFtZV9vZmYpKTsNCj4+ICsJCWJyZWFrOw0KPj4g KwljYXNlIEJURl9LSU5EX1VOSU9OOg0KPj4gKwkJQlRGX1BSSU5UX09ORV9BUkcoInVuaW9uICVz ICIsDQo+PiArCQkJCSAgYnRmX19uYW1lX2J5X29mZnNldChidGYsIHQtPm5hbWVfb2ZmKSk7DQo+ PiArCQlicmVhazsNCj4+ICsJY2FzZSBCVEZfS0lORF9FTlVNOg0KPj4gKwkJQlRGX1BSSU5UX09O RV9BUkcoImVudW0gJXMgIiwNCj4+ICsJCQkJICBidGZfX25hbWVfYnlfb2Zmc2V0KGJ0ZiwgdC0+ bmFtZV9vZmYpKTsNCj4+ICsJCWJyZWFrOw0KPj4gKwljYXNlIEJURl9LSU5EX0FSUkFZOg0KPj4g KwkJYXJyYXkgPSAoc3RydWN0IGJ0Zl9hcnJheSAqKSh0ICsgMSk7DQo+PiArCQlCVEZfUFJJTlRf VFlQRV9PTkxZKGFycmF5LT50eXBlKTsNCj4+ICsJCUJURl9QUklOVF9PTkVfQVJHKCJbJWRdIiwg YXJyYXktPm5lbGVtcyk7DQo+PiArCQlicmVhazsNCj4+ICsJY2FzZSBCVEZfS0lORF9QVFI6DQo+ PiArCQlCVEZfUFJJTlRfVFlQRV9PTkxZKHQtPnR5cGUpOw0KPj4gKwkJQlRGX1BSSU5UX1NUUklO RygiKiAiKTsNCj4+ICsJCWJyZWFrOw0KPj4gKwljYXNlIEJURl9LSU5EX1VOS046DQo+PiArCWNh c2UgQlRGX0tJTkRfRldEOg0KPj4gKwljYXNlIEJURl9LSU5EX1RZUEVERUY6DQo+PiArCQlyZXR1 cm4gLTE7DQo+PiArCWNhc2UgQlRGX0tJTkRfVk9MQVRJTEU6DQo+PiArCQlCVEZfUFJJTlRfU1RS SU5HKCJ2b2xhdGlsZSAiKTsNCj4+ICsJCUJURl9QUklOVF9UWVBFX09OTFkodC0+dHlwZSk7DQo+ PiArCQlicmVhazsNCj4+ICsJY2FzZSBCVEZfS0lORF9DT05TVDoNCj4+ICsJCUJURl9QUklOVF9T VFJJTkcoImNvbnN0ICIpOw0KPj4gKwkJQlRGX1BSSU5UX1RZUEVfT05MWSh0LT50eXBlKTsNCj4+ ICsJCWJyZWFrOw0KPj4gKwljYXNlIEJURl9LSU5EX1JFU1RSSUNUOg0KPj4gKwkJQlRGX1BSSU5U X1NUUklORygicmVzdHJpY3QgIik7DQo+PiArCQlCVEZfUFJJTlRfVFlQRV9PTkxZKHQtPnR5cGUp Ow0KPj4gKwkJYnJlYWs7DQo+PiArCWNhc2UgQlRGX0tJTkRfRlVOQzoNCj4+ICsJY2FzZSBCVEZf S0lORF9GVU5DX1BST1RPOg0KPj4gKwkJQlRGX1BSSU5UX1RZUEVfT05MWSh0LT50eXBlKTsNCj4+ ICsJCUJURl9QUklOVF9PTkVfQVJHKCIlcygiLCBidGZfX25hbWVfYnlfb2Zmc2V0KGJ0ZiwgdC0+ bmFtZV9vZmYpKTsNCj4+ICsJCXZsZW4gPSBCVEZfSU5GT19WTEVOKHQtPmluZm8pOw0KPj4gKwkJ Zm9yIChpID0gMDsgaSA8IHZsZW47IGkrKykgew0KPj4gKwkJCV9fdTMyIGFyZ190eXBlID0gKChf X3UzMiAqKSh0ICsgMSkpW2ldOw0KPj4gKw0KPj4gKwkJCUJURl9QUklOVF9UWVBFX09OTFkoYXJn X3R5cGUpOw0KPj4gKwkJCWlmIChpICE9ICh2bGVuIC0gMSkpDQo+PiArCQkJCUJURl9QUklOVF9T VFJJTkcoIiwgIik7DQo+PiArCQl9DQo+IEluIHRoaXMga2luZCBvZiBsb29wIEkgZmluZCBpdCBj bGVhbmVyIHRvIHByaW50IHRoZSBjb21tYSBiZWZvcmUgdGhlIGl0ZW07DQo+ICDCoHRoYXQgd2F5 IHRoZSB0ZXN0IGJlY29tZXMgaSAhPSAwLsKgIFRodXM6DQo+ICDCoMKgwqAgZm9yIChpID0gMDsg aSA8IHZsZW47IGkrKykgew0KPiAgwqDCoMKgwqDCoMKgwqAgX191MzIgYXJnX3R5cGUgPSAoKF9f dTMyICopKHQgKyAxKSlbaV07DQo+IA0KPiAgwqDCoMKgwqDCoMKgwqAgaWYgKGkpDQo+ICDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgIEJURl9QUklOVF9TVFJJTkcoIiwgIik7DQo+ICDCoMKgwqDCoMKg wqDCoCBCVEZfUFJJTlRfVFlQRV9PTkxZKGFyZ190eXBlKTsNCj4gIMKgwqDCoCB9DQoNCkdvb2Qg c3VnZ2VzdGlvbi4gV2lsbCBtYWtlIGNoYW5nZSBpbiB0aGUgbmV4dCByZXZpc2lvbi4NCg0KPiAN Cj4gLUVkDQo+IA0K