From: "Jiawen Wu" <jiawenwu@trustnetic.com>
To: "'Jakub Kicinski'" <kuba@kernel.org>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<linux@armlinux.org.uk>, <andrew@lunn.ch>,
<netdev@vger.kernel.org>, <mengyuanlou@net-swift.com>
Subject: RE: [PATCH net-next v5 6/8] net: wangxun: add coalesce options support
Date: Fri, 22 Dec 2023 16:20:58 +0800 [thread overview]
Message-ID: <02bf01da34af$cad838a0$6088a9e0$@trustnetic.com> (raw)
In-Reply-To: <20231215183826.7bc82ef0@kernel.org>
On Saturday, December 16, 2023 10:38 AM, Jakub Kicinski wrote:
> On Thu, 14 Dec 2023 10:54:54 +0800 Jiawen Wu wrote:
> > + ec->tx_max_coalesced_frames_irq = wx->tx_work_limit;
> > + /* only valid if in constant ITR mode */
> > + if (wx->rx_itr_setting <= 1)
> > + ec->rx_coalesce_usecs = wx->rx_itr_setting;
> > + else
> > + ec->rx_coalesce_usecs = wx->rx_itr_setting >> 2;
> > +
> > + /* if in mixed tx/rx queues per vector mode, report only rx settings */
>
> What if there's only a Tx queue? You'll report both rx and tx
> coalescing params?
The current driver does not support this case.
>
> > + if (wx->q_vector[0]->tx.count && wx->q_vector[0]->rx.count)
> > + return 0;
> > +
> > + /* only valid if in constant ITR mode */
> > + if (wx->tx_itr_setting <= 1)
> > + ec->tx_coalesce_usecs = wx->tx_itr_setting;
> > + else
> > + ec->tx_coalesce_usecs = wx->tx_itr_setting >> 2;
>
next prev parent reply other threads:[~2023-12-22 8:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-14 2:54 [PATCH net-next v5 0/8] Implement more ethtool_ops for Wangxun Jiawen Wu
2023-12-14 2:54 ` [PATCH net-next v5 1/8] net: libwx: add phylink to libwx Jiawen Wu
2023-12-14 2:54 ` [PATCH net-next v5 2/8] net: txgbe: use phylink bits added in libwx Jiawen Wu
2023-12-14 2:54 ` [PATCH net-next v5 3/8] net: ngbe: convert phylib to phylink Jiawen Wu
2023-12-14 2:54 ` [PATCH net-next v5 4/8] net: wangxun: add flow control support Jiawen Wu
2023-12-14 2:54 ` [PATCH net-next v5 5/8] net: wangxun: add ethtool_ops for ring parameters Jiawen Wu
2023-12-16 2:36 ` Jakub Kicinski
2023-12-14 2:54 ` [PATCH net-next v5 6/8] net: wangxun: add coalesce options support Jiawen Wu
2023-12-16 2:38 ` Jakub Kicinski
2023-12-22 8:20 ` Jiawen Wu [this message]
2023-12-14 2:54 ` [PATCH net-next v5 7/8] net: wangxun: add ethtool_ops for channel number Jiawen Wu
2023-12-16 2:41 ` Jakub Kicinski
2023-12-14 2:54 ` [PATCH net-next v5 8/8] net: wangxun: add ethtool_ops for msglevel Jiawen Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='02bf01da34af$cad838a0$6088a9e0$@trustnetic.com' \
--to=jiawenwu@trustnetic.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).