From: "John Efstathiades" <john.efstathiades@pebblebay.com>
To: "'Jakub Kicinski'" <kuba@kernel.org>
Cc: <linux-usb@vger.kernel.org>, <UNGLinuxDriver@microchip.com>,
<woojung.huh@microchip.com>, <davem@davemloft.net>,
<netdev@vger.kernel.org>
Subject: RE: [PATCH net-next 05/10] lan78xx: Disable USB3 link power state transitions
Date: Tue, 24 Aug 2021 16:52:45 +0100 [thread overview]
Message-ID: <02dc01d79900$20a60580$61f21080$@pebblebay.com> (raw)
In-Reply-To: <20210824081958.407b4009@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
> > I like the sound of the device match list but I don't know what you
> mean.
> > Is there a driver or other reference you could point me at that provides
> > additional info?
>
> Depends on what the discriminator is. If problems happen with
> a particular ASIC revisions driver needs to read the revision
> out and make a match. If it's product by product you can use
> struct usb_device_id :: driver_info to attach metadata per
> device ID. If it's related to the platform things like DMI
> matching are sometimes used. I have very limited experience
> with Android / embedded ARM so not sure what would work there.
Thanks. Based on that I will remove this change from the patch set and
discuss again with the driver maintainer.
next prev parent reply other threads:[~2021-08-24 15:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 13:52 [PATCH net-next 00/10] LAN7800 driver improvements John Efstathiades
2021-08-23 13:52 ` [PATCH net-next 01/10] lan78xx: Fix white space and style issues John Efstathiades
2021-08-23 13:52 ` [PATCH net-next 02/10] lan78xx: Remove unused timer John Efstathiades
2021-08-23 13:52 ` [PATCH net-next 03/10] lan78xx: Set flow control threshold to prevent packet loss John Efstathiades
2021-08-23 13:52 ` [PATCH net-next 04/10] lan78xx: Remove unused pause frame queue John Efstathiades
2021-08-23 13:52 ` [PATCH net-next 05/10] lan78xx: Disable USB3 link power state transitions John Efstathiades
2021-08-23 22:40 ` Jakub Kicinski
2021-08-24 8:59 ` John Efstathiades
2021-08-24 13:53 ` Jakub Kicinski
2021-08-24 14:33 ` John Efstathiades
2021-08-24 15:19 ` Jakub Kicinski
2021-08-24 15:52 ` John Efstathiades [this message]
2021-08-23 13:52 ` [PATCH net-next 06/10] lan78xx: Fix exception on link speed change John Efstathiades
2021-08-23 22:42 ` Jakub Kicinski
2021-08-23 13:52 ` [PATCH net-next 07/10] lan78xx: Fix partial packet errors on suspend/resume John Efstathiades
2021-08-23 13:52 ` [PATCH net-next 08/10] lan78xx: Fix race conditions in suspend/resume handling John Efstathiades
2021-08-23 13:52 ` [PATCH net-next 09/10] lan78xx: Fix race condition in disconnect handling John Efstathiades
2021-08-23 13:52 ` [PATCH net-next 10/10] lan78xx: Limit number of driver warning messages John Efstathiades
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='02dc01d79900$20a60580$61f21080$@pebblebay.com' \
--to=john.efstathiades@pebblebay.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).