Re: [PATCH net] net: bcmasp: fix double frees during remove

[Justin Chen <justin.chen@broadcom.com>]

On 3/13/26 9:55 AM, Simon Horman wrote:
> On Thu, Mar 12, 2026 at 01:08:14PM -0700, justin.chen@broadcom.com wrote:
>> From: Justin Chen <justin.chen@broadcom.com>
>>
>> We have two double frees during remove.
>> - We do not need to free wol_irq since it was instantiated with
>>    devm_request_irq(). So devres will free for us.
> 
> Hi Justin,
> 
> The above seems clear enough.
> 
>> - Switch to devm_clk_get_optional() instead of
>>    devm_clk_get_optional_enabled() so we can manage the clock ourselves.
> 
> But it is unclear to me what problem this is solving.
> Or how it relates to the first point - usually the aim
> is to have one fix per patch.
> 
> Could you elaborate?
> 
The double free happens because we double disable the clock. Guess it is 
not exactly a double free. We manage the clock at the driver level so we 
disable it when it is unneeded. The default state is clock disabled when
no interfaces are up. After we bring down the interfaces, the clock is 
disabled, then when we unbind the driver, it hits a double disable.

Sure I can turn this into two fixes.

Thanks,
Justin
>>
>> Fixes: a2f0751206b0 ("net: bcmasp: Add support for WoL magic packet")
>> Fixes: 490cb412007d ("net: bcmasp: Add support for ASP2.0 Ethernet controller")
>> Signed-off-by: Justin Chen <justin.chen@broadcom.com>