From: "Jiawen Wu" <jiawenwu@trustnetic.com>
To: "'Simon Horman'" <horms@kernel.org>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <linux@armlinux.org.uk>, <andrew@lunn.ch>,
<netdev@vger.kernel.org>, <mengyuanlou@net-swift.com>
Subject: RE: [PATCH net-next v3 2/2] net: txgbe: use irq_domain for interrupt controller
Date: Thu, 25 Jan 2024 10:21:40 +0800 [thread overview]
Message-ID: <02e301da4f35$3ae8d790$b0ba86b0$@trustnetic.com> (raw)
In-Reply-To: <20240124103438.GX254773@kernel.org>
On Wednesday, January 24, 2024 6:35 PM, Simon Horman wrote:
> On Wed, Jan 24, 2024 at 10:45:25AM +0800, Jiawen Wu wrote:
>
> ...
>
> > +static int txgbe_misc_irq_domain_map(struct irq_domain *d,
> > + unsigned int irq,
> > + irq_hw_number_t hwirq)
> > +{
> > + struct txgbe *txgbe = d->host_data;
> > +
> > + irq_set_chip_data(irq, txgbe);
> > + irq_set_chip(irq, &txgbe->misc.chip);
> > + irq_set_nested_thread(irq, TRUE);
>
> Hi Jiawen Wu,
>
> 'TRUE' seems undefined, causing a build failure.
> Should this be 'true' instead?
Oops. I built it with 'true' but sent the patch with 'TRUE'. ☹
>
> > + irq_set_noprobe(irq);
> > +
> > + return 0;
> > +}
>
> --
> pw-bot: changes-requested
>
next prev parent reply other threads:[~2024-01-25 2:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-24 2:45 [PATCH net-next v3 0/2] Implement irq_domain for TXGBE Jiawen Wu
2024-01-24 2:45 ` [PATCH net-next v3 1/2] net: txgbe: move interrupt codes to a separate file Jiawen Wu
2024-01-25 16:43 ` Andrew Lunn
2024-01-24 2:45 ` [PATCH net-next v3 2/2] net: txgbe: use irq_domain for interrupt controller Jiawen Wu
2024-01-24 10:34 ` Simon Horman
2024-01-25 2:21 ` Jiawen Wu [this message]
2024-01-26 21:04 ` Simon Horman
2024-01-25 16:44 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='02e301da4f35$3ae8d790$b0ba86b0$@trustnetic.com' \
--to=jiawenwu@trustnetic.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).