From: David Ahern <dsahern@kernel.org>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: selftest fib_nexthop_multiprefix failed due to route mismatch
Date: Fri, 8 Dec 2023 12:21:55 -0700 [thread overview]
Message-ID: <02ef5de4-d57f-4037-8968-d9bf791bd903@kernel.org> (raw)
In-Reply-To: <ZW_u7VWTpWAuub4L@Laptop-X1>
On 12/5/23 8:47 PM, Hangbin Liu wrote:
> On Tue, Nov 21, 2023 at 09:40:02AM -0800, David Ahern wrote:
>> On 11/20/23 10:40 PM, Hangbin Liu wrote:
>>> Hi David,
>>>
>>> Recently when run fib_nexthop_multiprefix test I saw all IPv6 test failed.
>>> e.g.
>>>
>>> # ./fib_nexthop_multiprefix.sh
>>> TEST: IPv4: host 0 to host 1, mtu 1300 [ OK ]
>>> TEST: IPv6: host 0 to host 1, mtu 1300 [FAIL]
>>>
>>> With -v it shows
>>>
>>> COMMAND: ip netns exec h0 /usr/sbin/ping6 -s 1350 -c5 -w5 2001:db8:101::1
>>> PING 2001:db8:101::1(2001:db8:101::1) 1350 data bytes
>>> From 2001:db8:100::64 icmp_seq=1 Packet too big: mtu=1300
>>>
>>> --- 2001:db8:101::1 ping statistics ---
>>> 1 packets transmitted, 0 received, +1 errors, 100% packet loss, time 0ms
>>>
>>> Route get
>>> 2001:db8:101::1 via 2001:db8:100::64 dev eth0 src 2001:db8:100::1 metric 1024 expires 599sec mtu 1300 pref medium
>>> Searching for:
>>> 2001:db8:101::1 from :: via 2001:db8:100::64 dev eth0 src 2001:db8:100::1 .* mtu 1300
>>>
>>> TEST: IPv6: host 0 to host 1, mtu 1300 [FAIL]
>>>
>>> So we can get the Packet too big from 2001:db8:100::64 successfully. There
>>> is no "from ::" anymore. I plan to fix this issue. But I can't find which
>>> commit changed the behavior and the client could receive Packet too big
>>> message with correct src address.
>>>
>>> Do you have any hints?
>>>
>>> Thanks
>>> Hangbin
>>
>> v6.3.12:
>>
>> $ sudo /mnt/hostshare/fib_nexthop_multiprefix.sh
>> TEST: IPv4: host 0 to host 1, mtu 1300 [ OK ]
>> TEST: IPv6: host 0 to host 1, mtu 1300 [ OK ]
>>
>> v6.4.13 all passed as well, so it is something recent. I do not have a
>> 6.5 or 6.6 kernels compiled at the moment.
>
> Hi David,
>
> I re-test this on 6.4.0 and it also failed. So this looks like an env issue
> on your side?
>
> # uname -r
> 6.4.0
> # ./fib_nexthop_multiprefix.sh
> TEST: IPv4: host 0 to host 1, mtu 1300 [ OK ]
> TEST: IPv6: host 0 to host 1, mtu 1300 [FAIL]
>
> And from the test result, it looks we should receive the Packet too big message
> from r1. So look the current checking is incorrect and the "from ::" checking
> should be removed.
>
> Please fix me if I missed anything?
>
I ran it in a ubuntu 20.04 VM. Do not recall any specific sysctl
settings to the VM, but maybe something is different between U20.04 and
your OS
next prev parent reply other threads:[~2023-12-08 19:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 6:40 selftest fib_nexthop_multiprefix failed due to route mismatch Hangbin Liu
2023-11-21 17:40 ` David Ahern
2023-12-06 3:47 ` Hangbin Liu
2023-12-08 19:21 ` David Ahern [this message]
2023-12-11 9:22 ` Hangbin Liu
2023-12-11 13:45 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02ef5de4-d57f-4037-8968-d9bf791bd903@kernel.org \
--to=dsahern@kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).