netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: Ian Kumlien <ian.kumlien@gmail.com>,
	Stephen Hemminger <stephen@networkplumber.org>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
	jeffrey.t.kirsher@intel.com,
	Roopa Prabhu <roopa@cumulusnetworks.com>,
	nikolay@cumulusnetworks.com,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [BUG] v4.20 - bridge not getting DHCP responses? (works in 4.19.13)
Date: Tue, 8 Jan 2019 15:09:38 -0800	[thread overview]
Message-ID: <02fbd1e8-8ad1-3a47-c3e1-86adbb73185d@gmail.com> (raw)
In-Reply-To: <CAA85sZt=mrqprwkKLGbv2UMy6vQb0XSc58YrWvqxzK4yhdbpGQ@mail.gmail.com>

On 1/8/19 3:00 PM, Ian Kumlien wrote:
> On Tue, Jan 8, 2019 at 11:51 PM Stephen Hemminger
> <stephen@networkplumber.org> wrote:
>> On Tue, 8 Jan 2019 23:10:04 +0100
>> Ian Kumlien <ian.kumlien@gmail.com> wrote:
>>> On Sun, Jan 6, 2019 at 11:21 PM Ian Kumlien <ian.kumlien@gmail.com> wrote:
>>>>
>>>> [Sorry for the repost, screwed up the netdev address...]
>>>>
>>>> Hi,
>>>>
>>>> Switching from 4.19.x -> 4.20 resulted in DHCP not working for my VM:s.
>>>>
>>>> My firewall (which also runs the dhcpd) runs VM:s and it does this by
>>>> having physical
>>>> interfaces attached to bridges - which the VM:s in turn attach to.
>>>>
>>>> Since 4.20 the VM:s can't use DHCP, it's odd since the requests are
>>>> seen - a response is sent but
>>>> it never enters the interface attached to the bridge.
>>>>
>>>> Basically:
>>>> VM vnet2: -> br0 -> eno2 -> switch -> eno1 (dhcpd)
>>>> dhcpd eno1 -> siwtch and... gone.
>>>>
>>>> Any clues?
>>>>
>>>> All the nics are handled by ixgbe
>>>
>>> So, doing similar tests at work with other drivers works - could it be
>>> related to the mac address filter that was added?
>>> I don't *really* use VF:s though... (can't really find anything else atm)
>>>
>>> Will try to test, but the VM:s on this machine is in use.
>>
>> The default MAC address of the bridge device is the first device assigned
>> to the bridge.  Remember most VF interfaces will only allow single MAC address
>> and no promiscious mode.
> 
> Yeah, I'm not running any VF:s and it just seems like the responses
> are dropped somewhere
> 
> when looking at "git log v4.19...v4.20
> drivers/net/ethernet/intel/ixgbe/" nothing else really stands out...
> The machine is also running NAT for my home network and all of that
> works just fine...
> 
> I started with tcpdump, prooving that packets reached all the way
> outside but replies never made it, reboorting
> with 4.19.13 resulted in replies appearing in the tcpdump.
> 
> I don't quite know where to look - and what can i do to test - i tried
> disabling all offloading (due to the UDP
> offloading changes) but nothing helped...
> 
> Ideas? Patches? ;)

Running a bisection would certainly help find the offending commit if
that is something that you can do?
-- 
Florian

  reply	other threads:[~2019-01-08 23:09 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAA85sZsiifWTKq=Mw30f-UVyrzywnYYX7GvyqG+O+ndSYBML9A@mail.gmail.com>
2019-01-06 22:21 ` Fwd: [BUG] v4.20 - bridge not getting DHCP responses? (works in 4.19.13) Ian Kumlien
2019-01-08 22:10   ` Ian Kumlien
2019-01-08 22:51     ` Stephen Hemminger
2019-01-08 22:51       ` Stephen Hemminger
2019-01-08 23:00       ` Ian Kumlien
2019-01-08 23:09         ` Florian Fainelli [this message]
2019-01-08 23:09           ` Florian Fainelli
     [not found]           ` <CAA85sZvVHCYFRXp5cYzSDNpesNMtCZOB+Gnb+N+SmraD6eke1A@mail.gmail.com>
2019-01-10  0:16             ` Ian Kumlien
2019-01-10  0:16               ` Ian Kumlien
2019-01-10  0:38               ` Ian Kumlien
2019-01-10  8:08                 ` Paolo Abeni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=02fbd1e8-8ad1-3a47-c3e1-86adbb73185d@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=ian.kumlien@gmail.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@cumulusnetworks.com \
    --cc=roopa@cumulusnetworks.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).